Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6271895rwn; Tue, 13 Sep 2022 01:23:10 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Si+kcFLDsv8TC/ZQZVW62SmWWtvNP0w6dp3XMNiqdOt8Bjiy0jcBApJhwG8CpST316FzB X-Received: by 2002:a17:902:8307:b0:172:e611:491f with SMTP id bd7-20020a170902830700b00172e611491fmr30326797plb.111.1663057389984; Tue, 13 Sep 2022 01:23:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663057389; cv=none; d=google.com; s=arc-20160816; b=icXw5u61sd1ca+51s6GyQALHlTsM78qkJnMwK6P8L/uudY9jpW0eBOcgjwS0jt3RAC /2QG+iXI/ybUkI5bqN5gSnHDdd5uEbPyuFsuqAFXs4AtnkWvgJSUuo6wwADYFePY438z ugQErxI4cPl4G3j9F9wb87I1DnQZKNHTyjTozDVefVimNpecIZnb6LZRInCcTULl5Fwy WDFcv43ZeUiLQ4r+GpJLYXoK2x3IYDJGTmBSoLBBUMjjXCT1JhiOxS9p3ZdNObHHNbKI B85agz0eU/wv8TegsXperNnyGG9dhUbE/IatejNPgOjdEqErNMBdJ9BYYugxw9/MCKsz QAmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qI2gzG9lvMfYSooF8IMZyqtD/TNF2oo0z1OfNw4K4Gs=; b=OD01bqROc44POvTOwqApi0UQXdSXFjcQhyGiQTwmPsVlE8vGxLksdFMtn36xLTbvyF BwL6q4x5L/ZphzqELwwo41oVwGdpSUPg++y2E7zAJYM+53J47yjHIySAd5UvMeHi1Nvk hQe5jLq3cIJbg/9l3+j7m2yKY7stETqIothCDOr6PFV+CpS/VKUl3xDl4GEjn4FHwIRW 90D+B7ZcFwl/MQiRohiKQmSj3KE5KL9SgDaR7UVCbke8D1i74PXLQTL9KlO1SA5Y/40G 1UnoGh3iQk64LBebWRlMf/8lZ2S93aEesIsnBWpOHQqcoSfR7OF3gmYEtUDc1ygsc+gn Fr6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hlGrmphS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oa15-20020a17090b1bcf00b0020297249987si12795076pjb.124.2022.09.13.01.22.56; Tue, 13 Sep 2022 01:23:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hlGrmphS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbiIMHxt (ORCPT + 99 others); Tue, 13 Sep 2022 03:53:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbiIMHxs (ORCPT ); Tue, 13 Sep 2022 03:53:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5323554651; Tue, 13 Sep 2022 00:53:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D74A6612E7; Tue, 13 Sep 2022 07:53:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39DA7C433D7; Tue, 13 Sep 2022 07:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663055626; bh=rFPbnv2DxX3rBK1a7Jmm1zE+iq04DfP9/i/2IqvALRc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hlGrmphSQgEThIAQsJUpshNn2BE0nacqeqs8Un/E4gMkyv1wHHJevTQNjLxpzPwPO 79tm1goievGKLE8mqyJYBRtHSP2cbkez1QlJfEtWCp67OAaS1wkzYC+Hsv+r++ibRf +8s88EmcISfP1CLtcVK9YQKe2RNDEMYIHwq0SB+zhJrR30JQm34isT9nd2jzII2ddg Gh+XeLDhPYWBdpk2sp1AlTHVOv4V363IpEu8P2J+90YBc5ZBH+w7iKtiVuOS45et7I eTtpsdSjQrXqo2fLL3nixe2uzN8mejPBbKLMNWXIFmeQidRgiWQmzL0fBwOiOhT7XR fA5hXas4pgW8w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oY0jo-00010R-LD; Tue, 13 Sep 2022 09:53:44 +0200 Date: Tue, 13 Sep 2022 09:53:44 +0200 From: Johan Hovold To: Dmitry Baryshkov Cc: Johan Hovold , Douglas Anderson , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Sean Paul , Stephen Boyd , Bjorn Andersson , Manivannan Sadhasivam , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] drm/msm: drop modeset sanity checks Message-ID: References: <20220912154046.12900-1-johan+linaro@kernel.org> <20220912154046.12900-8-johan+linaro@kernel.org> <39cbf0cb-9f25-6a0d-6e56-3f9e0aaa0296@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39cbf0cb-9f25-6a0d-6e56-3f9e0aaa0296@linaro.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 09:06:28PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Signed-off-by: Johan Hovold > > Again, please split into dp and dsi patches. After that: Sure, if you prefer. But without the stable-tree argument I think there's little point in splitting. > Reviewed-by: Dmitry Baryshkov > > > --- > > drivers/gpu/drm/msm/dp/dp_display.c | 7 +------ > > drivers/gpu/drm/msm/dsi/dsi.c | 7 +------ > > 2 files changed, 2 insertions(+), 12 deletions(-) Johan