Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220909130309.25458-1-vincent.guittot@linaro.org>
 <20220909130309.25458-7-vincent.guittot@linaro.org> <Yx+wKhhk5niBZMNO@slm.duckdns.org>
In-Reply-To: <Yx+wKhhk5niBZMNO@slm.duckdns.org>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Tue, 13 Sep 2022 10:31:31 +0200
Message-ID: <CAKfTPtBFTbQC8S+Y1pWwWcXY-u4xH2WTpxmvisVFFP=zK5=xww@mail.gmail.com>
Subject: Re: [PATCH v3 6/8] sched/fair: Add sched group latency support
To:     Tejun Heo <tj@kernel.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        linux-kernel@vger.kernel.org, parth@linux.ibm.com,
        qais.yousef@arm.com, chris.hyser@oracle.com,
        valentin.schneider@arm.com, patrick.bellasi@matbug.net,
        David.Laight@aculab.com, pjt@google.com, pavel@ucw.cz,
        qperret@google.com, tim.c.chen@linux.intel.com, joshdon@google.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 13 Sept 2022 at 00:18, Tejun Heo <tj@kernel.org> wrote:
>
> Hello,
>
> On Fri, Sep 09, 2022 at 03:03:07PM +0200, Vincent Guittot wrote:
> > +     {
> > +             .name = "latency",
> > +             .read_s64 = cpu_latency_read_s64,
> > +             .write_s64 = cpu_latency_write_s64,
> > +     },
>
> You're still using the nice value here, right? If so, can you please use the
> filename "latency.nice" so that it's consistent with "weight.nice"?

This cpu.latency is not a nice priority but the signed offset used by
the scheduler at wakeup. On previous version you raised concern about
having a nice value for cgroup so I removed it for cgroup and directly
exposed the latency offset with cpu.latency similarly to the weight
that is exposed with cpu.shares.

Vincent
>
> Thanks.
>
> --
> tejun