Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d47faa55-9b3e-022a-c074-080ddbe0658b@quicinc.com>
Date:   Tue, 13 Sep 2022 16:30:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH] interconnect: qcom: Add the missing MODULE_LICENSE
Content-Language: en-US
To:     Leo Yan <leo.yan@linaro.org>
CC:     <agross@kernel.org>, <bjorn.andersson@linaro.org>,
        <konrad.dybcio@somainline.org>, <djakov@kernel.org>,
        <dmitry.baryshkov@linaro.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220913062721.5986-1-quic_hyiwei@quicinc.com>
 <YyAscuyA1pKmEDH1@leoy-huanghe.lan>
From:   Huang Yiwei <quic_hyiwei@quicinc.com>
In-Reply-To: <YyAscuyA1pKmEDH1@leoy-huanghe.lan>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Leo,

On 9/13/2022 Tue 15:08, Leo Yan wrote:
> Hi Yiwei,
> 
> On Tue, Sep 13, 2022 at 02:27:21PM +0800, Huang Yiwei wrote:
>> Since icc-common.c can be compiled as module, add the missing
>> MODULE_LICENSE to avoid compile errors.
> 
> Just curious how you can enable config INTERCONNECT_QCOM as "m"
> (module)?
> 
> I checked the config INTERCONNECT_QCOM which is dependent on
> INTERCONNECT, and INTERCONNECT has below dependency:
> 
>    - DRM_TEGRA [=n] && HAS_IOMEM [=y] && (ARCH_TEGRA [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && DRM [=m] && OF [=y]
>    - TEGRA_MC [=n] && MEMORY [=y] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n] && COMMON_CLK [=y])
> 
> Seems to me, it's impossible to enable INTERCONNECT as "m" because the
> dependency ARCH_TEGRA/OF/COMMON_CLK cannot be configured as "m".
> 
> Thanks,
> Leo
> 
Found the problem, INTERCONNECT_QCOM is modified to tristate internally
so we can compile it as a module, and the new added icc-common.c uses
INTERCONNECT_QCOM config to compile, then cause the problem. So shall we
change INTERCONNECT_QCOM config to tristate?

Thanks,
Yiwei