Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220913052203.177071-1-apopple@nvidia.com>
 <53390539-cfa9-7498-5b69-8fb8b307182d@redhat.com>
User-agent: mu4e 1.6.9; emacs 27.1
From:   Alistair Popple <apopple@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        John Hubbard <jhubbard@nvidia.com>,
        Peter Xu <peterx@redhat.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        huang ying <huang.ying.caritas@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Ralph Campbell <rcampbell@nvidia.com>,
        Matthew Wilcox <willy@infradead.org>,
        Karol Herbst <kherbst@redhat.com>,
        Lyude Paul <lyude@redhat.com>, Ben Skeggs <bskeggs@redhat.com>,
        Logan Gunthorpe <logang@deltatee.com>, paulus@ozlabs.org,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] hmm-tests: Fix migrate_dirty_page test
Date:   Tue, 13 Sep 2022 18:20:45 +1000
In-reply-to: <53390539-cfa9-7498-5b69-8fb8b307182d@redhat.com>
Message-ID: <878rmnn0jq.fsf@nvdebian.thelocal>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fKciIpJS29LoFTQ3B63334qq2pn17Ej+D0J8y1ZYXJw4Guf4Qo8RzzDWTX4Q?=
 =?us-ascii?Q?ZITbMJFI9OxWdHupwiR+IRRKO0aWx0hmYsGvodIBPB2EWACIp15sWFhudtaO?=
 =?us-ascii?Q?263nDO70GFrqvc1Fr04zph8q6QLz0gqpxaFcr+zG6vSCgP1h8dcJWzx+Cto2?=
 =?us-ascii?Q?/AbLjMl1CB1ml2n591CA8VA5Zql+5TD3U4jjppeCAV0o4xHic+mVcKnBFhtC?=
 =?us-ascii?Q?qu38mxL8S/NmTB3YObdWM+36f0qJskue7TAzwtQaKqUOjADu5bLsgqpJwaFr?=
 =?us-ascii?Q?RPT2ER4lSQADLEWwPX42FJs0GnvXEiQr5oCYuf8LVbOBGdwIx4p8IDNjEfNb?=
 =?us-ascii?Q?5tZzBz5UCw7c/L0e4tCvyZlGslSV4TRMXafVF2L5c0K4L66Ge9UcAPKeioBg?=
 =?us-ascii?Q?cwp7/sGZdZWfK63wUpsZYVzSC+p8mEZ5nJEO4kmKlDNM4QIPQuuTC8u7B6ud?=
 =?us-ascii?Q?IRo52nVm4ytVcjhlrGvzvdb1slzRQRhD69kbZsTh5GtwMsIq6uTtm+QDpSuD?=
 =?us-ascii?Q?rxCqKGvw4BSu/91bADhgsVAkiYxVMEQSy+UIweZNIDw8c3REKe0jbjhoT7x/?=
 =?us-ascii?Q?hIeBnChpD/G3N3thMYbajvFC8yUkC8hpA/oQRZA0ueMMWiraT1OtUAyEtlhV?=
 =?us-ascii?Q?nRxwbJmOpF4hpljYy5vmqnOVsz6LbrVOgGZyzo9UVoA6GtXF0Ismyo3tVxuh?=
 =?us-ascii?Q?hGLOm9oSxujpNveSOuad3Oh/lo8mg0ZQzWEqZtn2kqf96ZgTXobtYzyp7wNR?=
 =?us-ascii?Q?i4PU8+vzxzLHrlWZNgZScMC9mFJsgAma47K41cJFWEEgRmqcpcSBeyuy+Af8?=
 =?us-ascii?Q?nkMgzGitYEFnt5vwlfIYYsXDiUBXZuFpANV+sjqQ8/2kwt/aCvnhVI9nmsI7?=
 =?us-ascii?Q?vR11t0Xptus0zcWg1wGISNHAqu3zp1qsEDeXXWJRppMwen/POJs4ALtG7YN/?=
 =?us-ascii?Q?fRfWw96b4R5WzuL9ktkw7AM5pEEptYbAhh2NmMEpRbxVllI5dMeMMhl1C02q?=
 =?us-ascii?Q?aTyj3bGq8Lj5nhxxyLTZi064C0Si1eJeS6EMLL1DHXyC11L3XiZ3vhimQpyb?=
 =?us-ascii?Q?h2DNQUfW5o6ceX5gn1y5P6BdonNQ33Tx0K4tihXFDSEjb5n47rgy+dzAOaM2?=
 =?us-ascii?Q?x28RWYNW59UDNWgLFimpt9greNNeXw7LYG131LwF+d/ZUQi832hTq4XgsBc3?=
 =?us-ascii?Q?Yrugl73LnAKRUoGePR1MsAIMCdNbemCuEOPkqxkpZlz13+9w2qOH68MXhvO2?=
 =?us-ascii?Q?CexJOFeDEbeLzzj62xMCYb0cSVT7n0nxCM3wiv3Ym27F7CMtOFKLtFCirBOh?=
 =?us-ascii?Q?MUTdpQIpGDCYb5pD4twlI1Yq7IJ0G3ACtfxHP3qj8ptbZtOD5CoMYDTLuc35?=
 =?us-ascii?Q?3r/06E3rMqbHkgvmvIvrHim3VJT6gv2huxPH119lFaeLDliTQMzOFV8NM2eJ?=
 =?us-ascii?Q?n+jDE3K2b+IOAPS5GKJSTJVbhPoJUvX9snS/jC8Gc4qUm2HK+QyWGIuLtpPo?=
 =?us-ascii?Q?pjMq31wM1RcP8cIBYHONftOa50rCnKlBtyf/aDN5ViChAF6wdb9UqUryWLt8?=
 =?us-ascii?Q?GRGO6pvRPfnokPQmlC9m9RdPQZo/p26LbZPGphyt?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cd608f0-1082-41da-62d4-08da95618796
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 08:25:34.7211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C8qUkMshBr99AcFXXyO+7QqgsIpyXgx9i5FEdTE1+w5TW2SSEt13arlqDzJfTtwBnW0wAqf9+L4eRNbcHSXIjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6873
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


David Hildenbrand <david@redhat.com> writes:

> On 13.09.22 07:22, Alistair Popple wrote:
>> As noted by John Hubbard the original test relied on side effects of the
>> implementation of migrate_vma_setup() to detect if pages had been
>> swapped to disk or not. This is subject to change in future so
>> explicitly check for swap entries via pagemap instead. Fix a spelling
>> mistake while we're at it.
>> Signed-off-by: Alistair Popple <apopple@nvidia.com>
>> Fixes: 5cc88e844e87 ("selftests/hmm-tests: add test for dirty bits")
>> ---
>>   tools/testing/selftests/vm/hmm-tests.c | 50 +++++++++++++++++++++++---
>>   1 file changed, 46 insertions(+), 4 deletions(-)
>> diff --git a/tools/testing/selftests/vm/hmm-tests.c
>> b/tools/testing/selftests/vm/hmm-tests.c
>> index 70fdb49b59ed..b5f6a7dc1f12 100644
>> --- a/tools/testing/selftests/vm/hmm-tests.c
>> +++ b/tools/testing/selftests/vm/hmm-tests.c
>> @@ -1261,9 +1261,47 @@ static int destroy_cgroup(void)
>>   	return 0;
>>   }
>>   +static uint64_t get_pfn(int fd, uint64_t ptr)
>> +{
>> +	uint64_t pfn;
>> +	int ret;
>> +
>> +	ret = pread(fd, &pfn, sizeof(ptr),
>> +		(uint64_t) ptr / getpagesize() * sizeof(ptr));
>> +	if (ret != sizeof(ptr))
>> +		return 0;
>> +
>> +	return pfn;
>> +}
>> +
>> +#define PAGEMAP_SWAPPED (1ULL << 62)
>> +
>> +/* Returns true if at least one page in the range is on swap */
>> +static bool pages_swapped(void *ptr, unsigned long pages)
>> +{
>> +	uint64_t pfn;
>> +	int fd = open("/proc/self/pagemap", O_RDONLY);
>> +	unsigned long i;
>> +
>> +	if (fd < 0)
>> +		return false;
>> +
>> +	for (i = 0; i < pages; i++) {
>> +		pfn = get_pfn(fd, (uint64_t) ptr + i * getpagesize());
>> +
>> +		if (pfn & PAGEMAP_SWAPPED) {
>> +			close(fd);
>> +			return true;
>> +		}
>
> We do have pagemap_get_entry() in vm_util.c to query the pagemap entry.

Thanks. I'd missed that, although `grep pagemap
tools/testing/selftests/vm` suggests I'm not the first to follow a
tradition of open-coding this :-)

But there's no need to perpetuate that tradition, so will redo this to
use vm_util.c instead.

> Can you further, add pagemap_is_swapped() to vm_util.c?
>
> I'll be also needing that (including a variant for testing a range) in anon COW
> tests.