Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 09:57:19 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Michael Walle <michael@walle.cc>
CC:     <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <claudiu.beznea@microchip.com>, <nicolas.ferre@microchip.com>
Subject: Re: [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal
 PHYs
Message-ID: <20220913075719.y63uvvwzquk435ht@soft-dev3-1.localhost>
References: <20220912192629.461452-1-horatiu.vultur@microchip.com>
 <caf34bf663601404df4021bc14297eeb@walle.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <caf34bf663601404df4021bc14297eeb@walle.cc>
Precedence: bulk

The 09/13/2022 09:18, Michael Walle wrote:
> 
> Hi Horatiu,

Hi Walle,

> 
> Am 2022-09-12 21:26, schrieb Horatiu Vultur:
> > According to the datasheet the interrupts for internal PHYs are
> > 80 and 81.
> 
> Can you point me to that documentation?

I have not found yet one on the microchip.com

> 
> Accoring to Table 3-155: Shared Peripheral Interrupts
> There are ID47 and ID48 listed as "MIIM controller 0 interrupt".
> Whatever that is, because the internal PHYs are on MIIM
> controller 1.
> 
> But 80 and 81 would be ID48 and ID49. Did you test the
> interrupts?

Looking the same table (3-155) in the documentation that I have these
interrupts correspond to ID112 and ID113 (Embedded CuPHY port 0/1 interrupt).
And because these are shared peripheral interrupts, it is required to
substract 32. Therefore I got the numbers 80 and 81.

As the internal PHYs don't have yet interrupt support, I have sent a
patch here [1] and I have tested it with this.

[1] https://www.spinics.net/lists/kernel/msg4511731.html

> 
> -michael
> 
> > Fixes: 6ad69e07def67c ("ARM: dts: lan966x: add MIIM nodes")
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> >  arch/arm/boot/dts/lan966x.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi
> > b/arch/arm/boot/dts/lan966x.dtsi
> > index bcb130a2471d..23665a042990 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -547,13 +547,13 @@ mdio1: mdio@e200413c {
> > 
> >                       phy0: ethernet-phy@1 {
> >                               reg = <1>;
> > -                             interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > +                             interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> >                               status = "disabled";
> >                       };
> > 
> >                       phy1: ethernet-phy@2 {
> >                               reg = <2>;
> > -                             interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> > +                             interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> >                               status = "disabled";
> >                       };
> >               };

-- 
/Horatiu