Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6326473rwn; Tue, 13 Sep 2022 02:30:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR6pUXGxfBEtmZS1Col2owOwnfdWUMRrkkzEvN8tGeF5YBR75EDnRqce8gLyc12BeEXv4MND X-Received: by 2002:a17:907:2ced:b0:773:6f77:f10f with SMTP id hz13-20020a1709072ced00b007736f77f10fmr18198717ejc.34.1663061418823; Tue, 13 Sep 2022 02:30:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663061418; cv=none; d=google.com; s=arc-20160816; b=MU7i3ar+q7Tfd2CEggQauE83JKL6oqwdyNqAu5Fkev2VYzsXyhmJ9neL6zLWn5A5/N DhwCvRCUOkTe2/HWYS2XlkqjyGJ8Sm2FtjsM9OtcdlJtfE7iypJpmAjKPOywv0Wsdsc/ BMrxZpouSA6OWaSrVrlAgietU6cxX4SE7WT085ubb7SbHFrbnzZsmYpYbV8rkXNi1XTm djRjkmVT+KDPZlgL5rFurmVFKV2/9Tzed1D5QVxuidGqz6P0W63nSHAS5C2pLzogMsht FXrjhMrzJEalZZ/ongh9l5VQm+a9k6yxMzutdZ8tutPHi2ozKtnfL76M3AscIkF7J+VG Wshg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=3I7tR4tx1GAwmtz8utnK2R7eX1ItvJgn2setxh8GvEU=; b=C0ITc9a3k8OxZ3v3rbr+h+67AyLKZLV/g7TNtRG4gOIP15qd5a1RT8kVmTMR/ldbPT zOAkflEQDt9IL6UlQFCX4V0bQf+RyqoZbXqnKviJ5st3n2gyv8OVxiBjY1+EjX1TZgvT /2MuTgb9f2fSV8ovnhhjWROSxK1KvLfAgRufPDxIGsTqMinAAop26jY9yB5fHvAm5/Hr cGUUrxdNXiTkmkAqjSEj2+MLJkCtp4cy9rnVrK3xLgxfoyUxg8GeM3Bc7WF+cW9s8XIi zYVbBTIDR6mfEAV5scA20c01wKCA+h51GxANBZ5b/mgNZf6xenIwHbvpT2YZK4Fz3VLX EofA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz3-20020a1709072ce300b007730e4861b5si10604704ejc.516.2022.09.13.02.29.53; Tue, 13 Sep 2022 02:30:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbiIMIpM (ORCPT + 99 others); Tue, 13 Sep 2022 04:45:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbiIMIpH (ORCPT ); Tue, 13 Sep 2022 04:45:07 -0400 Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 057E81CB09 for ; Tue, 13 Sep 2022 01:45:03 -0700 (PDT) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 793671A3289; Tue, 13 Sep 2022 10:45:02 +0200 (CEST) Received: from aprdc01srsp001v.ap-rdc01.nxp.com (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 426311A3279; Tue, 13 Sep 2022 10:45:02 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 06C72180219B; Tue, 13 Sep 2022 16:45:00 +0800 (+08) From: Shengjiu Wang To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: kuninori.morimoto.gx@renesas.com Subject: [PATCH] ASoC: ak4458: Add ak4458_reset in device probe and remove Date: Tue, 13 Sep 2022 16:26:34 +0800 Message-Id: <1663057594-29141-1-git-send-email-shengjiu.wang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch fixup this warning when CONFIG_PM not defined linux/sound/soc/codecs/ak4458.c:631:13: error: 'ak4458_reset' defined but\ not used [-Werror=unused-function] 631 | static void ak4458_reset(struct ak4458_priv *ak4458, bool active) | ^~~~~~~~~~~~ cc1: all warnings being treated as errors Fixes: e9e7df88996d64 ("ASoC: ak4458: Remove component probe() and remove()") Reported-by: Kuninori Morimoto Signed-off-by: Shengjiu Wang --- sound/soc/codecs/ak4458.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/codecs/ak4458.c b/sound/soc/codecs/ak4458.c index b534212096ee..626310859814 100644 --- a/sound/soc/codecs/ak4458.c +++ b/sound/soc/codecs/ak4458.c @@ -781,12 +781,16 @@ static int ak4458_i2c_probe(struct i2c_client *i2c) pm_runtime_enable(&i2c->dev); regcache_cache_only(ak4458->regmap, true); + ak4458_reset(ak4458, false); return 0; } static int ak4458_i2c_remove(struct i2c_client *i2c) { + struct ak4458_priv *ak4458 = i2c_get_clientdata(i2c); + + ak4458_reset(ak4458, true); pm_runtime_disable(&i2c->dev); return 0; -- 2.34.1