Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 12:27:25 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Yevhen Orlov <yevhen.orlov@plvision.eu>,
        netdev@vger.kernel.org
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>,
        Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
        Stephen Hemminger <stephen@networkplumber.org>,
        linux-kernel@vger.kernel.org,
        Yevhen Orlov <yevhen.orlov@plvision.eu>,
        Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Subject: Re: [PATCH net-next v5 8/9] net: marvell: prestera: Add neighbour
 cache accounting
Message-ID: <202209111637.zSGjIXwb-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220908225211.31482-9-yevhen.orlov@plvision.eu>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7WM3/4IijlQeYjvKSaNLFBCxeMZ7PGtflscISfkfBGZRdkdShgxo31KaoohG?=
 =?us-ascii?Q?U3TsjKHqpfdmtwI7isX5dI8L0wOem44XvccPeXasWJUd0c0wMiFfhzKVopp+?=
 =?us-ascii?Q?brjFDoyIhypL13L1RYbm7WdQ47xROncj6kR7Dei0nVNM8qutvl+ixTEeEYAz?=
 =?us-ascii?Q?oqd23rq2MrHOh5QqAv3osowOHnS9+O8T6X0OrX1gYGLoDoZOCtK1AXDOFfBM?=
 =?us-ascii?Q?gA7o2z9IpRMH0foZ3eqfRbfXCY7cUnJCXc03c208H5pxfrrqVm+WR0BfaVst?=
 =?us-ascii?Q?Uj8YPmvENuDk4biYvgu6eES6WjrGtbsX9ahcVN5YcER5CxG7Me9qP5xemBoB?=
 =?us-ascii?Q?I7zeoAs9edgaaFAW/WoDcoXF+GZnB24hAb2urnJdvNe8deXxKuquip51L4LK?=
 =?us-ascii?Q?e6jiYUyUmWw2culdqOgzU+epDiuKAxbgDejWiH26EI3Zd6arqzAlpYp5L81F?=
 =?us-ascii?Q?qUg3wmzEdH4+f1xVIKejR9k8JPfzQs9/beuRGxcdv+F7kbsa5DUTkTw82E8j?=
 =?us-ascii?Q?2eCa0JTsAxx4MwxE/SUOMips3SfKHYro7oIYkzIF+CuLj4q+pf2hC7pJm1j5?=
 =?us-ascii?Q?U5L7ZKOopBgTeHiuZmT/2GvXseKH5QPRfZQFNGtR/BV1aHix9BPyKwtEdDik?=
 =?us-ascii?Q?FZjK1J9oHJ5VhR+bdNht2VowZ9Iek6LVbLi+Xw54xmIB1kM3kh4AH9V2mTcx?=
 =?us-ascii?Q?mDKuACn+RQBzJIORMSzJiXCDaVbMRxjmrDzTfjhmJd1V7Q6o5lY1W54qrg24?=
 =?us-ascii?Q?YWORBgUbiqyur05LbQCDOeSDElE2l6kM/lRMm5jtbgggVX8mQ2MzBrbpvNwW?=
 =?us-ascii?Q?ewYVcDbgBT8Bq0ipbfRr8eXSCW7do7ntlpZjgHj+F7feGgFnaPNd9Ydvw1Aq?=
 =?us-ascii?Q?WJLwrpdfA9BaAns4Z/zfjY1YfOUGNGIO9Au6FyW3BIWqKcuh68eqJbTa6bI1?=
 =?us-ascii?Q?f7Ia3bgKu4Dee0szpqfZ4uajePP+YixaIlbzGA03OS68whtPSifSILLqlDAV?=
 =?us-ascii?Q?01bZtXSnBc+Exz0Eq16TY2BTSN29kyNyjEnY/5sqpBDuHDNBC3BsYtIfMqwo?=
 =?us-ascii?Q?qqjZ87hHIw2Q4pfPBSTxjJ5bA/4wvnrEYlWb1lghd5XgGkRU2+pI+uFgEiDU?=
 =?us-ascii?Q?B9lqXMWBAakvbdp6uHybN4pRLgJIbHn1qI7MjqjbX9wOH+cbWc2ejuwuHqYr?=
 =?us-ascii?Q?mCbi10r/Fm9xHVWiKwUE6xPWfeHrAEa5I8ZyvQwrQbcyyHfj+1bRCJZidF/G?=
 =?us-ascii?Q?iCUmewaTpvqHq1ZVJcWgBE1xxcf4olHKQs9+lEj06N62Y93W123+GzKd2Sed?=
 =?us-ascii?Q?4Y07REMyVkBZZlYTJbu3biSFH/PrOL/IvDBnl2iI0+ipuDDBjpdDzBKLGSei?=
 =?us-ascii?Q?bIvz38CKc81rqJ2jccZesPK5G7By1QoTRfRSzogk3pWVyEAbKFiF6OD2srRS?=
 =?us-ascii?Q?GbNx/uKcH/r5uGY/z/tfgrC8BUIQWoQvaVLz94NkvQDtORajBdAzw4pu8gkF?=
 =?us-ascii?Q?0aYrq0a1hkDxuAOlSgvjZQn0IBCtlvhcATQhrdGPAlMpvWoZ7455bvZvAbsY?=
 =?us-ascii?Q?OR9H9n330OonBe+5m3pcwrxGYd4yz72YoogqC3gKsK9mHfAo+zrYe6/ZGjGx?=
 =?us-ascii?Q?Vg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d4c83c9-1ebd-4b2e-03d8-08da956a345d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 09:27:40.7366
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AFO6u/NB5qhnsx6bJavoid+7oux9uKQDfwjB87K5SAvFtJ3bLuAVelku1xu24ywHRpwuuaYvQLFQjH/3UL/FqihUasBUiXiKTuT0YLxbziM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4129
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-13_03,2022-09-12_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 malwarescore=0
 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209130041
X-Proofpoint-GUID: bXvh0PFQBdotrNYznora7dulUOJWSCwU
X-Proofpoint-ORIG-GUID: bXvh0PFQBdotrNYznora7dulUOJWSCwU
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEXHASH_WORD,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yevhen,

url:    https://github.com/intel-lab-lkp/linux/commits/Yevhen-Orlov/net-marvell-prestera-add-nexthop-routes-offloading/20220909-065815
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9f8f1933dce555d3c246f447f54fca8de8889da9
config: openrisc-randconfig-m041-20220907
compiler: or1k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/net/ethernet/marvell/prestera/prestera_router.c:751 __prestera_k_arb_n_lpm_set() error: uninitialized symbol 'fib_node'.

vim +/fib_node +751 drivers/net/ethernet/marvell/prestera/prestera_router.c

5a826d874f2b0e Yevhen Orlov 2022-09-09  715  static void
5a826d874f2b0e Yevhen Orlov 2022-09-09  716  __prestera_k_arb_n_lpm_set(struct prestera_switch *sw,
5a826d874f2b0e Yevhen Orlov 2022-09-09  717  			   struct prestera_kern_neigh_cache *n_cache,
5a826d874f2b0e Yevhen Orlov 2022-09-09  718  			   bool enabled)
5a826d874f2b0e Yevhen Orlov 2022-09-09  719  {
5a826d874f2b0e Yevhen Orlov 2022-09-09  720  	struct prestera_nexthop_group_key nh_grp_key;
5a826d874f2b0e Yevhen Orlov 2022-09-09  721  	struct prestera_kern_fib_cache_key fc_key;
5a826d874f2b0e Yevhen Orlov 2022-09-09  722  	struct prestera_kern_fib_cache *fib_cache;
5a826d874f2b0e Yevhen Orlov 2022-09-09  723  	struct prestera_fib_node *fib_node;
5a826d874f2b0e Yevhen Orlov 2022-09-09  724  	struct prestera_fib_key fib_key;
5a826d874f2b0e Yevhen Orlov 2022-09-09  725  
5a826d874f2b0e Yevhen Orlov 2022-09-09  726  	/* Exception for fc with prefix 32: LPM entry is already used by fib */
5a826d874f2b0e Yevhen Orlov 2022-09-09  727  	memset(&fc_key, 0, sizeof(fc_key));
5a826d874f2b0e Yevhen Orlov 2022-09-09  728  	fc_key.addr = n_cache->key.addr;
5a826d874f2b0e Yevhen Orlov 2022-09-09  729  	fc_key.prefix_len = PRESTERA_IP_ADDR_PLEN(n_cache->key.addr.v);
5a826d874f2b0e Yevhen Orlov 2022-09-09  730  	/* But better to use tb_id of route, which pointed to this neighbour. */
5a826d874f2b0e Yevhen Orlov 2022-09-09  731  	/* We take it from rif, because rif inconsistent.
5a826d874f2b0e Yevhen Orlov 2022-09-09  732  	 * Must be separated in_rif and out_rif.
5a826d874f2b0e Yevhen Orlov 2022-09-09  733  	 * Also note: for each fib pointed to this neigh should be separated
5a826d874f2b0e Yevhen Orlov 2022-09-09  734  	 *            neigh lpm entry (for each ingress vr)
5a826d874f2b0e Yevhen Orlov 2022-09-09  735  	 */
5a826d874f2b0e Yevhen Orlov 2022-09-09  736  	fc_key.kern_tb_id = l3mdev_fib_table(n_cache->key.dev);
5a826d874f2b0e Yevhen Orlov 2022-09-09  737  	fib_cache = prestera_kern_fib_cache_find(sw, &fc_key);
5a826d874f2b0e Yevhen Orlov 2022-09-09  738  	if (!fib_cache || !fib_cache->reachable) {
5a826d874f2b0e Yevhen Orlov 2022-09-09  739  		memset(&fib_key, 0, sizeof(fib_key));
5a826d874f2b0e Yevhen Orlov 2022-09-09  740  		fib_key.addr = n_cache->key.addr;
5a826d874f2b0e Yevhen Orlov 2022-09-09  741  		fib_key.prefix_len = PRESTERA_IP_ADDR_PLEN(n_cache->key.addr.v);
5a826d874f2b0e Yevhen Orlov 2022-09-09  742  		fib_key.tb_id = prestera_fix_tb_id(fc_key.kern_tb_id);
5a826d874f2b0e Yevhen Orlov 2022-09-09  743  		fib_node = prestera_fib_node_find(sw, &fib_key);
5a826d874f2b0e Yevhen Orlov 2022-09-09  744  		if (!enabled && fib_node) {
5a826d874f2b0e Yevhen Orlov 2022-09-09  745  			if (prestera_fib_node_util_is_neighbour(fib_node))
5a826d874f2b0e Yevhen Orlov 2022-09-09  746  				prestera_fib_node_destroy(sw, fib_node);
5a826d874f2b0e Yevhen Orlov 2022-09-09  747  			return;
5a826d874f2b0e Yevhen Orlov 2022-09-09  748  		}
5a826d874f2b0e Yevhen Orlov 2022-09-09  749  	}

fib_node not initialized on else path.

5a826d874f2b0e Yevhen Orlov 2022-09-09  750  
5a826d874f2b0e Yevhen Orlov 2022-09-09 @751  	if (enabled && !fib_node) {
5a826d874f2b0e Yevhen Orlov 2022-09-09  752  		memset(&nh_grp_key, 0, sizeof(nh_grp_key));
5a826d874f2b0e Yevhen Orlov 2022-09-09  753  		prestera_util_nc_key2nh_key(&n_cache->key,
5a826d874f2b0e Yevhen Orlov 2022-09-09  754  					    &nh_grp_key.neigh[0]);
5a826d874f2b0e Yevhen Orlov 2022-09-09  755  		fib_node = prestera_fib_node_create(sw, &fib_key,
5a826d874f2b0e Yevhen Orlov 2022-09-09  756  						    PRESTERA_FIB_TYPE_UC_NH,
5a826d874f2b0e Yevhen Orlov 2022-09-09  757  						    &nh_grp_key);
5a826d874f2b0e Yevhen Orlov 2022-09-09  758  		if (!fib_node)
5a826d874f2b0e Yevhen Orlov 2022-09-09  759  			pr_err("%s failed ip=%pI4n", "prestera_fib_node_create",
5a826d874f2b0e Yevhen Orlov 2022-09-09  760  			       &fib_key.addr.u.ipv4);
5a826d874f2b0e Yevhen Orlov 2022-09-09  761  		return;
5a826d874f2b0e Yevhen Orlov 2022-09-09  762  	}
5a826d874f2b0e Yevhen Orlov 2022-09-09  763  }