Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <826a10fa-7dc3-887d-8a08-e03dcf1fa59c@linux.intel.com>
Date:   Tue, 13 Sep 2022 17:25:00 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Cc:     baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>
References: <20220912024826.1684913-1-baolu.lu@linux.intel.com>
 <BN9PR11MB52766A868879689D55AE9DC68C479@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Baolu Lu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/1] iommu/vt-d: Enable PASID during iommu device probe
In-Reply-To: <BN9PR11MB52766A868879689D55AE9DC68C479@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/9/13 16:01, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@linux.intel.com>
>> Sent: Monday, September 12, 2022 10:48 AM
>>
>> @@ -1401,7 +1403,6 @@ static void iommu_enable_dev_iotlb(struct
>> device_domain_info *info)
> 
> This is not the right name now as dev_iotlb is only related to ATS.

Yes. This name is confusing. Perhaps we can split it into some specific
helpers,

- intel_iommu_enable_pci_ats()
- intel_iommu_enabel_pci_pri()
- intel_iommu_enable_pci_pasid()
?

> 
>>   		info->pfsid = pci_dev_id(pf_pdev);
>>   	}
>>
>> -#ifdef CONFIG_INTEL_IOMMU_SVM
>>   	/* The PCIe spec, in its wisdom, declares that the behaviour of
>>   	   the device if you enable PASID support after ATS support is
>>   	   undefined. So always enable PASID support on devices which
>> @@ -1414,7 +1415,7 @@ static void iommu_enable_dev_iotlb(struct
>> device_domain_info *info)
>>   	    (info->pasid_enabled ? pci_prg_resp_pasid_required(pdev) : 1)
>> &&
>>   	    !pci_reset_pri(pdev) && !pci_enable_pri(pdev, PRQ_DEPTH))
>>   		info->pri_enabled = 1;
>> -#endif
>> +
>>   	if (info->ats_supported && pci_ats_page_aligned(pdev) &&
>>   	    !pci_enable_ats(pdev, VTD_PAGE_SHIFT)) {
>>   		info->ats_enabled = 1;
> 
> iommu_enable_dev_iotlb() is currently called both when the device is probed
> and when sva is enabled (which is actually useless). From this angle the commit
> msg is inaccurate.

The logic is a bit tricky. iommu_support_dev_iotlb() only returns a
devinfo pointer when ATS is supported on the device. So, you are right
if device supports both ATS and PASID; otherwise PASID will not be
enabled.

> 
>> diff --git a/drivers/iommu/intel/Kconfig b/drivers/iommu/intel/Kconfig
>> index 39a06d245f12..b3f40375f214 100644
>> --- a/drivers/iommu/intel/Kconfig
>> +++ b/drivers/iommu/intel/Kconfig
>> @@ -21,6 +21,8 @@ config INTEL_IOMMU
>>   	select IOASID
>>   	select IOMMU_DMA
>>   	select PCI_ATS
>> +	select PCI_PRI
>> +	select PCI_PASID
>>   	help
>>   	  DMA remapping (DMAR) devices support enables independent
>> address
>>   	  translations for Direct Memory Access (DMA) from devices.
>> @@ -48,8 +50,6 @@ config INTEL_IOMMU_DEBUGFS
>>   config INTEL_IOMMU_SVM
>>   	bool "Support for Shared Virtual Memory with Intel IOMMU"
>>   	depends on X86_64
>> -	select PCI_PASID
>> -	select PCI_PRI
>>   	select MMU_NOTIFIER
>>   	select IOASID
> 
> this is already selected by CONFIG_INTEL_IOMMU

Yes. Should be removed.

> 
>>   	select IOMMU_SVA
>> --
>> 2.25.1
> 
> 

Best regards,
baolu