Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 18:06:25 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Huang Yiwei <quic_hyiwei@quicinc.com>
Cc:     agross@kernel.org, andersson@kernel.org,
        konrad.dybcio@somainline.org, djakov@kernel.org,
        dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: qcom: Add the missing MODULE_LICENSE
Message-ID: <YyBWIUjvnHqmeWCG@leoy-yangtze.lan>
References: <20220913062721.5986-1-quic_hyiwei@quicinc.com>
 <YyAscuyA1pKmEDH1@leoy-huanghe.lan>
 <d47faa55-9b3e-022a-c074-080ddbe0658b@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d47faa55-9b3e-022a-c074-080ddbe0658b@quicinc.com>
Precedence: bulk

Changed to Bjorn's updated email.

On Tue, Sep 13, 2022 at 04:30:50PM +0800, Huang Yiwei wrote:
> Hi Leo,
> 
> On 9/13/2022 Tue 15:08, Leo Yan wrote:
> > Hi Yiwei,
> > 
> > On Tue, Sep 13, 2022 at 02:27:21PM +0800, Huang Yiwei wrote:
> > > Since icc-common.c can be compiled as module, add the missing
> > > MODULE_LICENSE to avoid compile errors.
> > 
> > Just curious how you can enable config INTERCONNECT_QCOM as "m"
> > (module)?
> > 
> > I checked the config INTERCONNECT_QCOM which is dependent on
> > INTERCONNECT, and INTERCONNECT has below dependency:
> > 
> >    - DRM_TEGRA [=n] && HAS_IOMEM [=y] && (ARCH_TEGRA [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && DRM [=m] && OF [=y]
> >    - TEGRA_MC [=n] && MEMORY [=y] && (ARCH_TEGRA [=y] || COMPILE_TEST [=n] && COMMON_CLK [=y])
> > 
> > Seems to me, it's impossible to enable INTERCONNECT as "m" because the
> > dependency ARCH_TEGRA/OF/COMMON_CLK cannot be configured as "m".
> > 
> > Thanks,
> > Leo
> > 
> Found the problem, INTERCONNECT_QCOM is modified to tristate internally
> so we can compile it as a module, and the new added icc-common.c uses
> INTERCONNECT_QCOM config to compile, then cause the problem.

Thanks for confirmation, Yiwei.

> So shall we change INTERCONNECT_QCOM config to tristate?

I personally think modularization is the right thing to do; to avoid
misleading you, I would leave your question to interconnect
maintainers.

Thanks,
Leo