Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6455756rwn; Tue, 13 Sep 2022 04:42:13 -0700 (PDT) X-Google-Smtp-Source: AA6agR6dUfB9VnIxfSyl+FK5cKhJJBB4tvXAVupzELda4IeH4ydmOtpEGJiQLD0ehTiF7xtUAJAU X-Received: by 2002:a05:6402:5409:b0:44f:1e05:1e8 with SMTP id ev9-20020a056402540900b0044f1e0501e8mr24470093edb.373.1663069332881; Tue, 13 Sep 2022 04:42:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663069332; cv=none; d=google.com; s=arc-20160816; b=djZt0HQJzsK391soFz5rVjpSJYjS5QO5A1EQhS6Ye7ocB7T7bw4gwS3uC6LPvVsP+3 oVsjQTeLukLZsNLYialp//3aUn2qDtCf1KSvxqnoRq88zg6uPwm1Rqk6RowfypRXFEmu uFCIt2AYlmF5z+vfYlMVka0ykPl/gI57Zmhmfq3Rz0JLUyEUorPxOIUBa3oRuxJQYz/c MerrWZeEPp7dSiyMkOaS1UeZzlzL+nshkG6nCAjqjJpjCc8H7rGVW97wSSOJTyQyPPo+ fiPIKnbhniX1vzA+XYdiT6N/o+CPeGkPVGWMIRmb5kzybev5abuJop91NLC+fV+NBCZH VXhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=IE4qSm2covL7obNP5jH9hsDfLsNvoyMXBotSNYGXp+A=; b=da2ECQdY/VW8B/jMlud2WlETtc53nM30STtWBumtzBTQrUT/3xZsoC7/bizQcEB6ix SY2Z/pq7i290V03/9q4lrLY1UwRmKFyPvh5i1UMYys5ifn1/THjplwE9aAh9lettyxKK X9Cuphx0LVsyxbLPa1gBZJ4G9cjIRxVu5yexhN4Jn+Zr/8rpWWyOAil9Ow3UqsYek/0z fTluVpuTwkBr9HZx4LF91D4tuQkS8tzbXxxHTo+YSWvf81fr0/39OeWQce7rfFeQ7AaA 2BYHVw50Vr+YuBsd0KBII0uEYN7ZXFBFbC01UOPg35WaiVGM/YKsO1YRFx02Ljs3YZ/v 5nZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UhfEBLtk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr11-20020a170907720b00b0073d594889fasi9531475ejc.314.2022.09.13.04.41.40; Tue, 13 Sep 2022 04:42:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=UhfEBLtk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231561AbiIMLTS (ORCPT + 99 others); Tue, 13 Sep 2022 07:19:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbiIMLTQ (ORCPT ); Tue, 13 Sep 2022 07:19:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2EEF248EA; Tue, 13 Sep 2022 04:19:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 36BD46142A; Tue, 13 Sep 2022 11:19:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FBC9C433D6; Tue, 13 Sep 2022 11:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663067954; bh=8WL+2ChhNqJlCeEkSghkmVAikI1JBjjo/JWZKZfMn+A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UhfEBLtkgUc3lrz38hjnenMo+Rg51QOM1iTk1lKYeEgONVhVxyeH3CGOrJw68hTV6 7jHgezmYrca3LZj1v+4hhN791suCz3UG9K9vWr4AsXS8+NGkB++3IVcLjEfr/OhNj6 1DsTUc6SUW31x79tpKfQbuU5YMehEz8dafiHWM01nVwvKRPlzazhtlJbJxkotBnNYV rBpHAmzgoUsvAcjspfavQ4X6fhp31cH6AVI6kKTsw14N2zZKnCIYrbm3WsuzNlzGN3 R9uNKDAjHumn5p9xb/T6kR2qfrskiGYaFTT+iCy2vrXySykOI/RxJ/3RC04WV2Qx5Q tBP94Ih85TpVg== Date: Tue, 13 Sep 2022 20:19:09 +0900 From: Masami Hiramatsu (Google) To: Liao Chang Cc: , , , , , , , , , , , , Subject: Re: [PATCH V2 0/3] kprobe: Optimize the performance of patching ss Message-Id: <20220913201909.2c7e38a40e719461e3c19b12@kernel.org> In-Reply-To: <20220913033454.104519-1-liaochang1@huawei.com> References: <20220913033454.104519-1-liaochang1@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Sep 2022 11:34:51 +0800 Liao Chang wrote: > Single-step slot would not be used until kprobe is enabled, that means > no race condition occurs on it under SMP, hence it is safe to pacth ss > slot without stopping machine. All these patches look good to me, since single-step slot must not be executed until it is prepared. Acked-by: Masami Hiramatsu (Google) for this series. But I need Ack by each architecture maintainer. Thank you, > > v2: > Backport riscv patch to cksy and arm64. > > Liao Chang (3): > riscv/kprobe: Optimize the performance of patching single-step slot > csky/kprobe: Optimize the performance of patching single-step slot > arm64/kprobe: Optimize the performance of patching single-step slot > > arch/arm64/kernel/probes/kprobes.c | 5 ++--- > arch/csky/kernel/probes/kprobes.c | 6 +++++- > arch/riscv/kernel/probes/kprobes.c | 8 +++++--- > 3 files changed, 12 insertions(+), 7 deletions(-) > > -- > 2.17.1 > -- Masami Hiramatsu (Google)