Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 12:26:09 +0100
From:   Oliver Upton <oliver.upton@linux.dev>
To:     Kunkun Jiang <jiangkunkun@huawei.com>
Cc:     Mark Rutland <mark.rutland@arm.com>, Marc Zyngier <maz@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        wanghaibin.wang@huawei.com, yuzenghui@huawei.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: arch_timer: Fix the lack of set_next_event* for
 workaround of Cortex-A73 erratum 858921
Message-ID: <YyBo0SPalTLsqYbS@google.com>
References: <20220913104723.332-1-jiangkunkun@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220913104723.332-1-jiangkunkun@huawei.com>
Precedence: bulk

On Tue, Sep 13, 2022 at 06:47:23PM +0800, Kunkun Jiang wrote:
> The patch a38b71b0833e moves the programming of the timers from

Please check your patch with scripts/checkpatch.pl next time.
Use this pattern when referring to a commit in the changelog:

commit a38b71b0833e ("clocksource/drivers/arm_arch_timer: Move
system register timer programming over to CVAL") moved the
programming...

> the countdown timer (TVAL) over to the comparator (CVAL). This
> makes it necessary to read the counter when setting next event.
> However, the workaround of Cortex-A73 erratum 858921 does not
> set the corresponding set_next_event_phys and set_next_event_virt.
> This patch fixes it.

Avoid referring to 'this patch', and just state imperatively what the
change does, perhaps:

Add the appropriate hooks to apply the erratum mitigation when
programming the next timer event.

Thanks for catching this!

--
Best,
Oliver