Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: A question about Cortex-A73 erratum 858921
To:     Marc Zyngier <maz@kernel.org>
CC:     Mark Rutland <mark.rutland@arm.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "wanghaibin.wang@huawei.com" <wanghaibin.wang@huawei.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <cce62c36-c2f4-7e0e-ad6d-6eae98f45aee@huawei.com>
 <87czc4rb1x.wl-maz@kernel.org>
From:   Kunkun Jiang <jiangkunkun@huawei.com>
Message-ID: <7f9bc4fb-67f5-5989-21ba-0833bd3cdd78@huawei.com>
Date:   Tue, 13 Sep 2022 18:52:09 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <87czc4rb1x.wl-maz@kernel.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi Marc,

Thank you for your reply, I've sent a fix.
https://lore.kernel.org/all/20220913104723.332-1-jiangkunkun@huawei.com/

Thanks,
Kunkun Jiang

On 2022/9/9 20:23, Marc Zyngier wrote:
> On Fri, 09 Sep 2022 08:31:43 +0100,
> Kunkun Jiang <jiangkunkun@huawei.com> wrote:
>> Hi all,
>>
>> Recently I am learning the code related to Arm arch timer. I found that the
>> Cortex-A73 erratum 858921 does not set the corresponding callback functions:
>> set_next_event_phys and set_next_event_virt like other erratums. Won't it
>> get the wrong value when reading the counter during setting next event?
> Yup, you're correct.
>
> This is a regression introduced by a38b71b0833e
> ("clocksource/drivers/arm_arch_timer: Move system register timer
> programming over to CVAL"). We used to use the TVAL accessor which
> doesn't need a read of the counter, while the switch to CVAL needs
> one. Obviously, I didn't enough pay attention to the A73 erratum.
>
> Please send in a fix for this.
>
> Thanks,
>
> 	M.
>