Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Heiko Stuebner <heiko@sntech.de>
To:     paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu
Cc:     samuel@sholland.org, guoren@kernel.org,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] riscv: make t-head erratas depend on MMU
Date:   Tue, 13 Sep 2022 13:38:36 +0200
Message-ID: <3452718.iIbC2pHGDl@phil>
In-Reply-To: <20220907154932.2858518-1-heiko@sntech.de>
References: <20220907154932.2858518-1-heiko@sntech.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Hi Palmer,

Am Mittwoch, 7. September 2022, 17:49:32 CEST schrieb Heiko Stuebner:
> Both basic extensions of SVPBMT and ZICBOM depend on CONFIG_MMU.
> Make the T-Head errata implementations of the similar functionality
> also depend on it to prevent build errors.
> 
> Fixes: a35707c3d850 ("riscv: add memory-type errata for T-Head")
> Fixes: d20ec7529236 ("riscv: implement cache-management errata for T-Head SoCs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

could you take a look at this too please?

As it would make the lkp robot happy :-)


Thanks
Heiko

> ---
>  arch/riscv/Kconfig.erratas | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/Kconfig.erratas b/arch/riscv/Kconfig.erratas
> index 6850e9389930..f3623df23b5f 100644
> --- a/arch/riscv/Kconfig.erratas
> +++ b/arch/riscv/Kconfig.erratas
> @@ -46,7 +46,7 @@ config ERRATA_THEAD
>  
>  config ERRATA_THEAD_PBMT
>  	bool "Apply T-Head memory type errata"
> -	depends on ERRATA_THEAD && 64BIT
> +	depends on ERRATA_THEAD && 64BIT && MMU
>  	select RISCV_ALTERNATIVE_EARLY
>  	default y
>  	help
> @@ -57,7 +57,7 @@ config ERRATA_THEAD_PBMT
>  
>  config ERRATA_THEAD_CMO
>  	bool "Apply T-Head cache management errata"
> -	depends on ERRATA_THEAD
> +	depends on ERRATA_THEAD && MMU
>  	select RISCV_DMA_NONCOHERENT
>  	default y
>  	help
>