Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6494822rwn; Tue, 13 Sep 2022 05:15:13 -0700 (PDT) X-Google-Smtp-Source: AA6agR7k6PgY8gXDs4jUBkO1mYC2T78WS5GDjVbkuyNwWP8bucOSu4xASlCp/BLRnB0QFnDt2jZZ X-Received: by 2002:a17:902:eb90:b0:178:25ab:b3ee with SMTP id q16-20020a170902eb9000b0017825abb3eemr13735131plg.23.1663071312843; Tue, 13 Sep 2022 05:15:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663071312; cv=none; d=google.com; s=arc-20160816; b=KdMSv9XHjkYNkmwJVW3hsbAguhoFD25bU0hKRH3qKi7HrNrDLnjLQ0RAv4B4mtHEz7 /allTfbXJTggT5MSd75fmRW1pEPzDCiJJ1KgVwuSx5EjbUFOLIiDHdH/Km8PpfnzlHjD Q+l41qUBpIzSNjNgSoBF56X0pyWVlQdonL8ZzfwPG/3vW2Rn8HGjYoso/CuAk5ONJIGR 208WGTad0Mqv6i9msa/WRcnF7P7qaQTrgPW4BvebNrxBAf9p4TSzXlMf7O3J+hCs6ZpF KZM+juGSszRIDthNrY8UqUM4iUvH98YdRGbF5dnwI3N4OxlEKgYu9IsX8Rfo01Cblhhu ZuQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ca9drreHgOfQ9dPhtIyG8mcL3Qh2aXaVamluHD1NqEo=; b=WH5FNaN2ImNJR8ih04UJUeSTmb1wFk2Lgxdgjdawcxyl5f5oZroo46mX58hOA12Wau UXo2MK/VJpxg8HXZ2kzJEJJjH9eerLc12RhSj/6rrofboLLdDwB1eRTweMXXdRjkq5Dh 4nRHThrVIDkGGyeq1h1c8sVmC8WOSmikaxTo/zfDRCt7H3sdvkqjBIKjrwJfu1BHcOgh RM5tSLd38r7pCguzyq/gu+diKzQBbAvE4FdmW+vB1cBlU1ZZWvhZx/wQA7zWElc/XyFw OzIMXYLv8ms21dfpRPMKULJ/syoV2Hjtb+7VKa40bccLso/q60j9LvXCpUKkmWoHDb1y 8zdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QWEDd01P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b4-20020a170902d40400b00176d0b3d571si10850341ple.406.2022.09.13.05.14.49; Tue, 13 Sep 2022 05:15:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=QWEDd01P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231838AbiIMLEq (ORCPT + 99 others); Tue, 13 Sep 2022 07:04:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231844AbiIMLEm (ORCPT ); Tue, 13 Sep 2022 07:04:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11921B873; Tue, 13 Sep 2022 04:04:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B7A0FB80E45; Tue, 13 Sep 2022 11:04:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7E4CC433C1; Tue, 13 Sep 2022 11:04:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663067079; bh=IQyyHTBiUn1e9HWsmP2j5v65pldmRulf8fHO7IJYFtM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QWEDd01PIjqB7OcnVpxXvXnS3gfd6kb7MgDe21h5dnGOMX15D4+cOnBOGf7N9BfRu AC8n3ykg6zoSdoRBJO1iJBwwWSYdjotWdkN4x2DXBeUFRgwLnrUsx+VD2o6ko3cB9o CKg0NVnNHlFXbMXu1viaqqepLF0/wEss8GNHx530= Date: Tue, 13 Sep 2022 13:05:03 +0200 From: Greg KH To: sunghwan jung Cc: stern@rowland.harvard.edu, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Revert "usb: storage: Add quirk for Samsung Fit flash" Message-ID: References: <20220913105059.10248-1-onenowy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913105059.10248-1-onenowy@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 07:50:59PM +0900, sunghwan jung wrote: > This reverts commit 86d92f5465958752481269348d474414dccb1552, which fix the timeout issue for "Samsung Fit Flash". > > But the commit affects not only "Samsung Fit Flash" but also other usb storages that use the same controller and causes severe performance regression. Please wrap your changelog text at 72 columns like your editor asked you to when you made the commit. Also, this is v2, please mark it as such and properly describe what changed from v1 in the properly location as the documentation asks you to. Please fix up and send v3. thanks, greg k-h