Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <336cb80f-8f58-92ba-aa92-1bb57a75f0fb@suse.com>
Date:   Tue, 13 Sep 2022 13:51:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml
To:     Lee Jones <lee@kernel.org>, matthias.bgg@kernel.org
Cc:     robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        mandyjh.liu@mediatek.com, linux-arm-kernel@lists.infradead.org
References: <20220830091110.27857-1-matthias.bgg@kernel.org>
 <YxnGBN4QEb1yMrGw@google.com>
Content-Language: en-US
From:   Matthias Brugger <mbrugger@suse.com>
In-Reply-To: <YxnGBN4QEb1yMrGw@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGhSZ3p4TzEyc3ZYM2VvMGc0WmFCNDJZSENuZHdVNDZlbnlncHhURVVHY1Rr?=
 =?utf-8?B?L3pHMDNZTGw5N1FwaGlZejdHd1RsZVM2SVhJK0k5QU5WeTVOZktEaytpSytx?=
 =?utf-8?B?b3FTL3V0dFlPeWVYbEhtMGdQMit4aTNQWWhmQUxZaFlCODc2WHprbXRobkxH?=
 =?utf-8?B?V1FvMjN3U21Sa05ORHpOdTA5VVlXVGZaNHdNNU55ZnZKcFVCQTczK3crSFEw?=
 =?utf-8?B?bG5Scm5uUG9ONnZBNFpxMHhNS0ZjYWpJL2hIYkt1R1NpQnFvM0ZoT09BVjFF?=
 =?utf-8?B?TEFYa0FsdnZZQi9VWjE5Skh2V1FPMDhPRkI3NDVDei9WcEdoUTk2NmZLRTNr?=
 =?utf-8?B?ZjJQRUlFNEttOHRqN04zMHlJNDF0MC9ZU1pMbGVSeVd5bmRtYkFZU0JWemVC?=
 =?utf-8?B?QmRhSFVMNU1uMmxabUJ4T1JoUVlsdjQwMEhOekE4WGpTYXRwZ3pJMlgyMnND?=
 =?utf-8?B?OE10WGxBN2NiNmRqRGNkcTRCNWFZVTVDd1VkY2FSUE0wbkpJZkdObnNkdjg3?=
 =?utf-8?B?UmowcURINHpaNEx4dG80cjRlajNvQ3ZjYzBnQWNwS25IRjAwRFR0TE5VZ0Fy?=
 =?utf-8?B?T2lmTFpyd0VkRHNhTHpmdnQ3UCtSRWREc3dhcWtpY2FJVkMxTFVYT0RUaUQ3?=
 =?utf-8?B?QWV6T25NVlo4VmZjUXpGbU93MCs4QjRSVjhoM0V3VERqRStSQXcxN2lmeEtw?=
 =?utf-8?B?dEJGa3NMZlY0aFAvQWVUNkFvaTZLRUZBK0IwR3REZGUvekV4YTRWSWlueWZt?=
 =?utf-8?B?RXI0S00xK2hlSDdhcGNoK2FETXdYY3laWGFtQ2l1NCtRN2hZR2UwQzlVcW1a?=
 =?utf-8?B?S2FKSE1jbHdSdnhhdlRqUVQ0MkhSYjVzR08wUWYySk4wNGIwZnpwSWd6Uys3?=
 =?utf-8?B?em1PUDl0QitMZElFbS9sOGRad01nQnhobHI4clgyNEhxaUtnMGd2Z2Z2RWZY?=
 =?utf-8?B?bzhXVElBOWs1c1NzbFowVTFXMlZEajBKbjgrSGFzeldaWGlFWFUrZUhZVXRV?=
 =?utf-8?B?OE9Jem0vc29sL1IwMC9DQ080dlpBZ1NTc2hlL1hJZHIxT2tDMFdSb3NrMnJZ?=
 =?utf-8?B?MWhmd2NEU0c3WUQ4OFlzbGtjZWc5dTQ2bGp6RTV0UlVtSGxPUWsyeGwrVWtN?=
 =?utf-8?B?dDVRWldhU3o1OHB1MVRuWk44dm9hWkwzUVRaMHZNSEFMN1BXMkJub0thWDRo?=
 =?utf-8?B?aGdzdTZTWEQ0Umd0REJvNjQzN0l2OWxRRzNsNlhkbnNQc2I1anhpWXJOaUNw?=
 =?utf-8?B?VzVNR0cvMTVDNGljTllTakFCUUQrZW55amt0OG5ITHZxOWREcEtKanRjaUFx?=
 =?utf-8?B?QUNiS3JNL1llVzA1WDlUd080blJWYys2Q2llclZjV0o3Vm5qSStxQitjZUVj?=
 =?utf-8?B?N1pTejhSV1lKdUlsTHNIeTMycThHeVlVdHNmOGwweDFFbHN1MGw5cFZCcm55?=
 =?utf-8?B?MU9rRnMvcWw2MEpGK0JOQ2MvS29iRG15bnZvYXNGUE9tTG9LeEVpc1lSakZm?=
 =?utf-8?B?RVlnV3REL1gwdHJHcmlxK2Z4bEQ5TWJVV0VZdzRENU9DMEkxV3ZjblRHSkt5?=
 =?utf-8?B?d2ZZRzVVTzlUbUs3T1hjekYzUnFyaUo4dXExUmwrU2dpZld4SEVBMnZiUDJK?=
 =?utf-8?B?dWJ6bktvbkNiSXo4ZG1yVFV4ZWV3eC9xTUY0bFZuM00rYk1oU1NJMmhRN1Jj?=
 =?utf-8?B?b2lHU1c3MjFPSmMvVU0xR2JWVm4rTHNLSGFFZGdLZSt4Vm5BRzBrY2pFc1Nq?=
 =?utf-8?B?cVpLczhCZVRKbVljZzFFUk5hVkgyNktocFFGMFB0WjFNQXJwRnhpSG1EK1hy?=
 =?utf-8?B?bm9ZSG5iNXIwVExOVG14N1ZZVGpFMjJldGdvenJPRm9NN3Avb1dHbWNJYzM5?=
 =?utf-8?B?V2tOdmdKSmFoajZtdk1pWlB0WnE1UzRHTjZOMmxla29HVHVDcXpKdWRaL3M4?=
 =?utf-8?B?a0xMZk9oYkc0TzdTQnhmSDdSLzhUZDMwbG9jN3dnbWNKemFLTE5tLzdORVZj?=
 =?utf-8?B?S0VjNktXZm12SFFVL2RIL2w2YTRGN2RhaEN2Y1NiQU1UTERuYTBvb1dQWkJG?=
 =?utf-8?B?bCtQMk11WEliWVhtOTBrRDl4WUdiTDUzS1JBYU1ZclhDL0VEWjkwcUlmMFpK?=
 =?utf-8?Q?MHXz7Y7qD+zsieO5hdz+q96QG?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01fcf582-b185-443e-4e88-08da957e57ca
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 11:51:50.2796
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GNABLcf9XIkEEko3g8K2ysxsr7o5MJtEDukhmXfnpFJdAR7TTi7d47btWl2qb3oMLXTNMXFIzjZna7yHliDHTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8908
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 08/09/2022 12:37, Lee Jones wrote:
> On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote:
> 
>> From: Matthias Brugger <mbrugger@suse.com>
>>
>> The file describes the scpsys node for all SoCs and not only the mt8195.
>> Rename it to reflect this fact.
> 
> Actually, this is fairly typical.  Same with actual drivers.
> 
> Both tend to adopt the name of the module first supported.
> 

Well I think that's unfortunate as it can create confusion for people searching 
for the binding as well as people adding a new compatible as they might think 
each SoC should have a independent yaml file. For that I reason I think it makes 
sense to fix the naming.

Regards,
Matthias

>> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>>
>> ---
>>
>> Changes in v2:
>> - Fix id
>>
>>   .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml}   | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>   rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> similarity index 96%
>> rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>> rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> index 3737207d8504..1a5901ca90f5 100644
>> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml
>> @@ -1,7 +1,7 @@
>>   # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>>   %YAML 1.2
>>   ---
>> -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml#
>> +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml#
>>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>>   
>>   title: MediaTek System Control Processor System
>