Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6747468rwn; Tue, 13 Sep 2022 08:30:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR5xPzGRJdnYQCh51ygji6ZDE7/syMxQWNdrHfVXEKCGx5sBHR+HEQRsva8HuNCp81Lmxu8F X-Received: by 2002:a17:906:ee8e:b0:730:3646:d178 with SMTP id wt14-20020a170906ee8e00b007303646d178mr22664889ejb.426.1663083022536; Tue, 13 Sep 2022 08:30:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663083022; cv=none; d=google.com; s=arc-20160816; b=Yamnu/pifK3Px8vIKCVfrzS8ct8WHL/lWCU/l7dYqT67KnEwMCU9cRwJURA9PJpa2x mVzOpN53H97Nu4//b5/SUt7X3kpU5kL8gOK964gDQngtwBI/ywxoWzTL3SPwheJfMYtj ZwQitp5kmxk3of6tB5KiR+aLSeKVmoT6CC3fnRHlLKt6tezdS1Z9Y4y86ovTy/yvAws6 C/HIXLr1hWC5ka1GiaxMrQjtjr88dVU8QXei1lAHlQxWY5BsjZ3mf9q4IUyaQD//cF9/ 3G5m9SSeYR1Xh1eioS2tXmgQKoHzpPT0+xywgaN9+rZe7CXMH/q3Vf/4LbaC8/5SQ2K9 VQjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1DBbHtLz/017b7FsvgaSnTYG3n/xte2jlXxnr/RqI6k=; b=WHXgBQbRmQEqHO2xaSpVZOPisz8IQhJkEqi2Tjmpjm7pTXMjdlThk6+0RMHSglH/39 p+fWyLogfjeRRvwvTl0k6e+9CrLS9BpBAA/j7Gf/nA4Nuiw03rhax/UoyCVLd2/zTKKo vpjyIdOp4Nj0MYRyuEbKAzgnrXv4VtTcgvCkwwb18SK1I4ajD/VLj3Vrk5cldMK3G8by PJaLqnN7dquvog2SsIwmQbTDgMkJEsJc1qWqTib8YS1Joco32a3m36i84oQ285Si/7gp rJg1nvyeO1xB40OX9sHYEDTDiCjp7BZgv3c5MlJM+HEV4RBuJY+JYPssQnsBLncGOCH6 OisQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a056402274800b0043d9ec0eb4fsi11101911edd.16.2022.09.13.08.29.56; Tue, 13 Sep 2022 08:30:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234378AbiIMOhy (ORCPT + 99 others); Tue, 13 Sep 2022 10:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234123AbiIMOf4 (ORCPT ); Tue, 13 Sep 2022 10:35:56 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 797FB6B179 for ; Tue, 13 Sep 2022 07:20:20 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY6l5-0003zp-Ah; Tue, 13 Sep 2022 16:19:27 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:e27a:1417:2420:c072]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 20A36E2236; Tue, 13 Sep 2022 14:19:26 +0000 (UTC) Date: Tue, 13 Sep 2022 16:19:17 +0200 From: Marc Kleine-Budde To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?B?Q3PDs2vDoXM=?= Bence , Jakub Kicinski , Sasha Levin , Francesco Dolcini Subject: Re: [PATCH 5.19 123/192] net: fec: Use a spinlock to guard `fep->ptp_clk_on` Message-ID: <20220913141917.ukoid65sqao5f4lg@pengutronix.de> References: <20220913140410.043243217@linuxfoundation.org> <20220913140416.124325107@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="af6c52mww4vpchdw" Content-Disposition: inline In-Reply-To: <20220913140416.124325107@linuxfoundation.org> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --af6c52mww4vpchdw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Greg, On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote: > From: Cs=C3=B3k=C3=A1s Bence >=20 > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ] >=20 > Mutexes cannot be taken in a non-preemptible context, > causing a panic in `fec_ptp_save_state()`. Replacing > `ptp_clk_mutex` by `tmreg_lock` fixes this. >=20 > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock= is disabled") > Fixes: f79959220fa5 ("fec: Restart PPS after link state change") > Reported-by: Marc Kleine-Budde > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@pengutr= onix.de/ > Signed-off-by: Cs=C3=B3k=C3=A1s Bence > Tested-by: Francesco Dolcini # Toradex Ap= alis iMX6 > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@prola= n.hu > Signed-off-by: Jakub Kicinski > Signed-off-by: Sasha Levin there's a revert pending for this patch: | https://lore.kernel.org/all/20220912070143.98153-1-francesco.dolcini@tora= dex.com =2E..as it causes troubles in 6.0-rc4: | https://lore.kernel.org/all/20220907143915.5w65kainpykfobte@pengutronix.d= e/ | https://lore.kernel.org/all/CAHk-=3Dwj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eh= eb3A9WHw@mail.gmail.com/ please drop this patch. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --af6c52mww4vpchdw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmMgkWIACgkQrX5LkNig 012O6Qf+IMmJPdO6Klc+65dYelBzSP71ECLl5oevZ3+kFxdgPaUdeuQUbjt/d7q1 daOodkWOcmkL/NStL6xRJJ/0SZ0q0hfP0KqP4BbIjaGSiox/C4lD1Feo/hRTHs+z Qmvh5a7wdzXMqCKx8pF439QAaKetnwKwS8ZcIJ282clRy+KqQU7i57N/4S82qpKO g1Q6KS3JWZF3a/8GK4sSh07jAa2W1CaPkMhxjNXnSHhk8OomKCvVrt4c5eN+YJu5 RoZ/0Hb9z2dWBAFyqeyB0zkiN76c7aqCxcy61eofobdhT1ypzOnTtDvxa95Xdz2V w5JiujUU7gnQLoIAT9SyXG+TmcUidQ== =v56d -----END PGP SIGNATURE----- --af6c52mww4vpchdw--