Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6763945rwn; Tue, 13 Sep 2022 08:42:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR5F1dDzgvh7bY3dEP6RSLynwv4ZGjYOT4+44jM4GTmM+LKP6mirZ0qEZtnPFtb+jQRhpZ4o X-Received: by 2002:aa7:d703:0:b0:44e:a7b9:d5bd with SMTP id t3-20020aa7d703000000b0044ea7b9d5bdmr26705793edq.425.1663083767699; Tue, 13 Sep 2022 08:42:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663083767; cv=none; d=google.com; s=arc-20160816; b=qq4P8DLMFb5sjBzPbu6yjccqF3W6wgBuYC9jWbfjVAGw63r0twMb9ztkI/hMwxjCdK WO11mgfxBaC/dsQsLcaMxbFTRksbeAty4q+WiPvWWwBucdUkXfGdL6dWtdPy9WJqtoTG MLS9XL3HUatjESx/Y1nch1U83Ku59sAc8+AkaasS1VcqwRQBoYITQktek317MsVW8BXP JbBtpt9t/rD/NH27hHTkXv015WTep21X3fWRJDb2oZkxOqjSMVe1qks4Aznbh9G0Hvj/ GH7IL1o6ZUi2wc4iomXzEmVwh65x+36NVJbDW1GtS2c/pPu7gQ17MzmDxtOVFa+WCxzn oAjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ZY7QWSIRRaOJVzM7e/047MqauMlT9lEzySs40qcBmSU=; b=CH84e8DLcFixcNE38Na59Hu+F68lhb4XQ9IExg2w51mvfXlTVVExOsFbpx2NrvQs4r 2uItFHpHcLKUuYj10t640jB6uEJIonyuxQ2v0skKfmR5kkMt4hnoNfXmMREdWvBAqpHE /tXLRA1qpq70ZsbQ2p7VXRZR8fLTaCdYhvo/PRvTK3kE2azWuYT3eAYGnOx8qIkAh0Zd Rg1NgU9S19SkjrKmEG1EFWJzf8zVl8Wk5Xm/qOxusKZSIMXEgOf/O/JKusUP6XwPOVIm vA0l8/dKgSw5m3gNlunxBnzHZvT8rzOzZnroPLAltrhvYNcPVmziXW5C46ejfEX6fzP+ pScQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=okIjNpZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id di22-20020a170906731600b0073d68aa1384si10001588ejc.185.2022.09.13.08.42.20; Tue, 13 Sep 2022 08:42:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=okIjNpZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232184AbiIMPBw (ORCPT + 99 others); Tue, 13 Sep 2022 11:01:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235217AbiIMO7b (ORCPT ); Tue, 13 Sep 2022 10:59:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34EE974365; Tue, 13 Sep 2022 07:29:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D94D614D4; Tue, 13 Sep 2022 14:25:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88EC8C433C1; Tue, 13 Sep 2022 14:25:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079147; bh=thDh15MSPH6KZKlEJMV8KoCLQ1nMTMaT1qagdRvUDu8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=okIjNpZRhfgAQuUnkigYOUql0hEtUb2Q5pP2G5pyhbOrGmce50yJ2CU79tzPS2fp4 eqv4JkXrt5yHZjnzPf4rxvDaGNfhBkn4Bmww1pyu70bK6BgLzEJfwWyq6fJTS4F+Ck RkAgk67xFpPm4YRrXAVXL+6jEmw3FU3adrrcUOfU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Nicolas Diaz , Shenwei Wang Subject: [PATCH 5.4 021/108] serial: fsl_lpuart: RS485 RTS polariy is inverse Date: Tue, 13 Sep 2022 16:05:52 +0200 Message-Id: <20220913140354.519307517@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140353.549108748@linuxfoundation.org> References: <20220913140353.549108748@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shenwei Wang commit 846651eca073e2e02e37490a4a52752415d84781 upstream. The setting of RS485 RTS polarity is inverse in the current driver. When the property of 'rs485-rts-active-low' is enabled in the dts node, the RTS signal should be LOW during sending. Otherwise, if there is no such a property, the RTS should be HIGH during sending. Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485") Cc: stable Signed-off-by: Nicolas Diaz Signed-off-by: Shenwei Wang Link: https://lore.kernel.org/r/20220805144529.604856-1-shenwei.wang@nxp.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/fsl_lpuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1277,9 +1277,9 @@ static int lpuart_config_rs485(struct ua * Note: UART is assumed to be active high. */ if (rs485->flags & SER_RS485_RTS_ON_SEND) - modem &= ~UARTMODEM_TXRTSPOL; - else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) modem |= UARTMODEM_TXRTSPOL; + else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) + modem &= ~UARTMODEM_TXRTSPOL; } /* Store the new configuration */