Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6772279rwn; Tue, 13 Sep 2022 08:49:47 -0700 (PDT) X-Google-Smtp-Source: AA6agR4I9MnbhMufonkfMJvAqF/YYejamSBedQ3EH3dV1BVkf69XImJoCt0U+7JPu2ZGZKNeQrqE X-Received: by 2002:a17:907:1c9b:b0:77c:59aa:c016 with SMTP id nb27-20020a1709071c9b00b0077c59aac016mr9363614ejc.152.1663084186776; Tue, 13 Sep 2022 08:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663084186; cv=none; d=google.com; s=arc-20160816; b=M4El2skHkoL6ix3H39v6HkK800A8Z2KIsjXpXC5LzJSK6+YqGg3umHxZ13zD2up9DH iiB4AiP7GK+sJkcqFMRndpXrbte9p7qcR0ZkCHiZfifXEFWgW4YxSuvSJ+L32N/r1WkA vjGv+buVgWFK0QFA6Wzll3MJ+jdoD4zqUJDZceWyj2akbI+xESUzbWhYMq5Om/NurDO2 ALX5Y3GYNerlFaYOcI15i5CwKBKESzUos1sjwkfjH/4oBU+2arZsJYey7jAJc+2tOtuw vg03pGuHFVm4dLb7+Hc4qhK6/IpR5wMf5mnLGIn8hhzz7gSEEYkHZIwatQRoZXQ9QbWZ 4aeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dUnN3T2w6TSHDUC8jpLmnKv9ifDhQ64GOVrhSc5qfwc=; b=iRmQK9VO5dZf2IY3Vwx/JdhTlUclPRBJIwJUJ+DTy0lRykGkaVsfnJQ8HUxmL2cDCz 6fB5hhvLz0X5YsMU4rWnHp9ffjd2exq0h6e+a2KyItBJ1z/YaNzVKKDl12f5iN0WxEFA nJlVQpVPsNJ4jzyFnBw5SNvqNxqbiDMceGCh9HHo58IwBaXaPVdu7/Rdn3WAz8i4AxkQ 7Ynhk81+8xCkn0viggHwrBS5WDiEIH1bIE4d9VTB+MDutHBK80aYsJed+MAXLJXfUIPg Op4TP0INjSKmyjtU+PDdNrHNpotV8LSfNi5bG3TKLLzPhXsL2vpOJ6oj4rDQcztaf+Cf aERw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0+ARJjVK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a170906244c00b00730936657d1si8720202ejb.552.2022.09.13.08.49.19; Tue, 13 Sep 2022 08:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0+ARJjVK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235905AbiIMPXO (ORCPT + 99 others); Tue, 13 Sep 2022 11:23:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232717AbiIMPW2 (ORCPT ); Tue, 13 Sep 2022 11:22:28 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AF4B7C18F; Tue, 13 Sep 2022 07:36:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB320B80EF6; Tue, 13 Sep 2022 14:26:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D701C433D6; Tue, 13 Sep 2022 14:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079176; bh=IAl9JR/9+CaPsYkduoGeeN391yAFQWonsVOOP0SplyY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0+ARJjVKMOg0kpdDygmvvqBUbpXE2VFLEqlOkc0XwOqTkRvD5s37hFau7dgT/xlf/ +Y4bu2Xh/sFhxQx/j3GScGl+enuVqBiyNwnh5XPsvjeshBZlbOjrP/ck5NUf56c2mV CrRPjel2M9g7TOKxvxEjRw+npc2Pxvcf4BWyM2XE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Sherry Sun Subject: [PATCH 5.4 025/108] tty: serial: lpuart: disable flow control while waiting for the transmit engine to complete Date: Tue, 13 Sep 2022 16:05:56 +0200 Message-Id: <20220913140354.718685266@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140353.549108748@linuxfoundation.org> References: <20220913140353.549108748@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sherry Sun commit d5a2e0834364377a5d5a2fff1890a0b3f0bafd1f upstream. When the user initializes the uart port, and waits for the transmit engine to complete in lpuart32_set_termios(), if the UART TX fifo has dirty data and the UARTMODIR enable the flow control, the TX fifo may never be empty. So here we should disable the flow control first to make sure the transmit engin can complete. Fixes: 380c966c093e ("tty: serial: fsl_lpuart: add 32-bit register interface support") Cc: stable Signed-off-by: Sherry Sun Link: https://lore.kernel.org/r/20220821101527.10066-1-sherry.sun@nxp.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/fsl_lpuart.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1981,6 +1981,7 @@ lpuart32_set_termios(struct uart_port *p uart_update_timeout(port, termios->c_cflag, baud); /* wait transmit engin complete */ + lpuart32_write(&sport->port, 0, UARTMODIR); lpuart32_wait_bit_set(&sport->port, UARTSTAT, UARTSTAT_TC); /* disable transmit and receive */