Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6775336rwn; Tue, 13 Sep 2022 08:52:24 -0700 (PDT) X-Google-Smtp-Source: AA6agR5vhD0sZ//LEYJ5iYUNCBXptrQHGeNOU4AiY8q2cmJTXhpJFbmP1WmPXxYKuvJcbklu8sc/ X-Received: by 2002:a17:906:ee81:b0:77e:829a:76e9 with SMTP id wt1-20020a170906ee8100b0077e829a76e9mr6371405ejb.207.1663084343884; Tue, 13 Sep 2022 08:52:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663084343; cv=none; d=google.com; s=arc-20160816; b=u8W5hxKROaJuzuklt0De13BZi0D+vLG0dfnRMHmHash+mciGPTLfS83y1ZL9mPtVWj ksBu/f1UUjMx59ounulPQ7w74F6afV5bLP8PFRWA0TgBBuL5lLK1Uy5hb6HPikn8p+Yo 9b8iBwPuKN51ld6Mhnj9G4lKwchqUWUHxVhMK8HJALPMjMBwjjNEET/RV1bUDdAK9rQU FI2EyTHHEGIJaRyc+iodtFUmOtPqRPqBUkSyJ/gKcb1VDEpq1TRC63nWlZFFTwLku241 9i7fe0g35kQyWcLMs5rNac0iJ7aAflHRWOvPUawLClcSdD/Yfd4/11v6FEVVin8/W5li kkRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VWiDNJoVrg3Yfh3dVvakCc92Fv7EhEVGSwLJy25BbsU=; b=VuLjOMMaPJRHr/yZ7DM1Mu8BDi+sZFDjiNSQsXmoR9AQxy7nZqVclQwkSgjT3Bou35 1K7Tp9wdIUuAmr1ylbCG0qJcu53GzgfDcT8/IQVHpZfZiabhgwSlloTghLIwjjrE4HeS 1GQ7LV26vFNv+N03SUHlrCYae24TNP9vWOaYfrhzqCu56Uu/Mxx3boGj7DQ06jCJG7JB DGTgAYr8yK9i7Xay0pFmgymq+sV4AVyPNkXSllZ7dJf8y+Pzr7Ai1PmuimO5/OcQ2BoY 0RUiDB6cdOGkHxsr+ZTW7iKpycTGjkmWGnf+1H4bpEQEVZJjBlTQFlB3pXkjthKqG4/C eb0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XyIgdVgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd8-20020a170907628800b00740110c599bsi10049376ejc.146.2022.09.13.08.51.58; Tue, 13 Sep 2022 08:52:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XyIgdVgd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236447AbiIMPaW (ORCPT + 99 others); Tue, 13 Sep 2022 11:30:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236415AbiIMP21 (ORCPT ); Tue, 13 Sep 2022 11:28:27 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED9147DF7D; Tue, 13 Sep 2022 07:39:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 49B14614B7; Tue, 13 Sep 2022 14:30:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48D2FC433D6; Tue, 13 Sep 2022 14:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079401; bh=+JRUnhSsb3qZnjCJWE7V6Qy4eCV8rMWMOG6/1fnFw8Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XyIgdVgdKCdGCqy10r83g3KtLn6NJP9VZzHYw6jv35tZWPb4sLuvkYr4xQidUt5eg mSSZ022arcuKlkSo2nqN3ElOkT3/HFDjyqlT6A5deJl4WTFWFgZ5vlvSG/9JJAHweI u1b3+hD4HyCdfxNZN/DZCLnsC47gaZGLz16ndcwQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Johannes Berg , Sasha Levin Subject: [PATCH 4.19 12/79] wifi: cfg80211: debugfs: fix return type in ht40allow_map_read() Date: Tue, 13 Sep 2022 16:06:30 +0200 Message-Id: <20220913140349.443475434@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140348.835121645@linuxfoundation.org> References: <20220913140348.835121645@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit d776763f48084926b5d9e25507a3ddb7c9243d5e ] The return type is supposed to be ssize_t, which is signed long, but "r" was declared as unsigned int. This means that on 64 bit systems we return positive values instead of negative error codes. Fixes: 80a3511d70e8 ("cfg80211: add debugfs HT40 allow map") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/YutvOQeJm0UjLhwU@kili Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/wireless/debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c index 30fc6eb352bcc..e6410487e25da 100644 --- a/net/wireless/debugfs.c +++ b/net/wireless/debugfs.c @@ -68,9 +68,10 @@ static ssize_t ht40allow_map_read(struct file *file, { struct wiphy *wiphy = file->private_data; char *buf; - unsigned int offset = 0, buf_size = PAGE_SIZE, i, r; + unsigned int offset = 0, buf_size = PAGE_SIZE, i; enum nl80211_band band; struct ieee80211_supported_band *sband; + ssize_t r; buf = kzalloc(buf_size, GFP_KERNEL); if (!buf) -- 2.35.1