Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6779582rwn; Tue, 13 Sep 2022 08:56:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR51XsybPlD4tshDcbFBEWxDjsmlY6KVBxshxkdTKmdNP8tyhy1D2XNu4ftW1c7Q3JxcNo/Q X-Received: by 2002:a17:907:983:b0:77b:6e40:8435 with SMTP id bf3-20020a170907098300b0077b6e408435mr10319943ejc.570.1663084563274; Tue, 13 Sep 2022 08:56:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663084563; cv=none; d=google.com; s=arc-20160816; b=SFLF7T3OrMG72qeaqzhEHi2M5Hq2xdn+HkfBnnG3F7AacpjyzYLdKeFd/B+tH4WhQJ k1BBFMgMcyo3miY39Rm/b1HE3leO+MzggSuxX57pv8fPVS+ZZJ2bVe8XVV/fPa7aeX+Y EZW5a19Bw6fEtsuj7LWMh2wrN+nLZfpc6r7xeSCBKfQT4s503XIrmddp7voemQK3rb0H jaaQGSvVD7Devbfw/+uTM2IUldO4x5GHxL9Y0h6XP2g0YIaEgJRqL/yADzupUnWcq/0c ux177q8sWuIyL1pqcvhxwsLB45/CL/YN9oeoOqMlXg+tbbhf6Zykoro5tO/lXSoZaWbx aDkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=y5C/0OWF9+iTy0ZIqj6YHS7Tdbg4KO9TUxaVjWd6GXY=; b=SkCrh+MX6F52zJONmT0DGn7hRqqwAiJWBlvYts3bHF1ORSjUp8xRkxEyj8ZzalCXel gMXZ//zYBryTiqJdSHC0ImY6thJPUAVZ9UhJKIuCoWiBh1XIMrjdtT6JEgn4VAiqnM1j fxUyx2+viy7A8auDCM7H9W583rJjGZ5/ktAN/dReJw6QeJk37kMUeNE2mieW/Gdh/FQt c8tIq5ruqHGVpvp3Dqp+wDF0NtZJTvewPXP8lb3KO5PiEy6lI6spSpLczPoxHPgnU5fb PsW0BR8KzeAfhaqTc2NtASr8p6pQaNtwyYmZ1P4crJNqSIb3we/8Mo2bKM3KbYVyOxdW sydg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SopX2Q+5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb11-20020a170907160b00b0077e29d27c39si4788336ejc.5.2022.09.13.08.55.35; Tue, 13 Sep 2022 08:56:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=SopX2Q+5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234127AbiIMPjp (ORCPT + 99 others); Tue, 13 Sep 2022 11:39:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236723AbiIMPis (ORCPT ); Tue, 13 Sep 2022 11:38:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA84D186F3; Tue, 13 Sep 2022 07:44:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95253614EA; Tue, 13 Sep 2022 14:30:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEC43C433C1; Tue, 13 Sep 2022 14:30:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079424; bh=qUDf5XTkMr1y3mYRDLD8wyQJgOaBBW1W3YD8wCMg+Ko=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SopX2Q+5zCHd5dLoPS+tM5a9R8mVjATtkEon8LRpKvdCSnozkCohW0MqYoSt8GhNO Xd7c1NjiBaa8IWGa9+FYFb90ZLm3sD3HflphxFpInUJZbPgJ1bXR+NgIxt4kHnMLGA bg7E7ARHYUhcczaQ72H/sr+Dyr9Hr6AJTri/pgug= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Nicolas Diaz , Shenwei Wang Subject: [PATCH 4.19 20/79] serial: fsl_lpuart: RS485 RTS polariy is inverse Date: Tue, 13 Sep 2022 16:06:38 +0200 Message-Id: <20220913140349.855097989@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140348.835121645@linuxfoundation.org> References: <20220913140348.835121645@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shenwei Wang commit 846651eca073e2e02e37490a4a52752415d84781 upstream. The setting of RS485 RTS polarity is inverse in the current driver. When the property of 'rs485-rts-active-low' is enabled in the dts node, the RTS signal should be LOW during sending. Otherwise, if there is no such a property, the RTS should be HIGH during sending. Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485") Cc: stable Signed-off-by: Nicolas Diaz Signed-off-by: Shenwei Wang Link: https://lore.kernel.org/r/20220805144529.604856-1-shenwei.wang@nxp.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/fsl_lpuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1102,9 +1102,9 @@ static int lpuart_config_rs485(struct ua * Note: UART is assumed to be active high. */ if (rs485->flags & SER_RS485_RTS_ON_SEND) - modem &= ~UARTMODEM_TXRTSPOL; - else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) modem |= UARTMODEM_TXRTSPOL; + else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) + modem &= ~UARTMODEM_TXRTSPOL; } /* Store the new configuration */