Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2b67dfcc-9027-6bb5-d42b-7465f2236747@redhat.com>
Date:   Tue, 13 Sep 2022 16:46:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2] drm/plane-helper: Add a
 drm_plane_helper_atomic_check() helper
Content-Language: en-US
To:     Harry Wentland <harry.wentland@amd.com>,
        linux-kernel@vger.kernel.org
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org
References: <20220913093339.106625-1-javierm@redhat.com>
 <b81591c4-934c-4b70-fbf0-b0f4663a6d1c@amd.com>
From:   Javier Martinez Canillas <javierm@redhat.com>
In-Reply-To: <b81591c4-934c-4b70-fbf0-b0f4663a6d1c@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/13/22 15:49, Harry Wentland wrote:
> 
> 
> On 2022-09-13 05:33, Javier Martinez Canillas wrote:
>> Provides a default plane state check handler for primary planes that are a
>> fullscreen scanout buffer and whose state scale and position can't change.
>>
> 
> Even though this might be how some drivers are handling the primary
> plane this assumption is not universal. For example, on ChromeOS when
> the (default) underlay strategy is selected the compositor will
> position the video plane as the bottom-most plane and mark it
> as primary, while the desktop plane is marked as overlay and
> will contain an alpha cutout to show the underlying video.
>
> In this case the video plane (primary) won't span the screen
> and is regularly panned and resized.
>

I see. Interesting.

> No objections to this change as it helps share code between drivers,
> but maybe specify that this behavior is a unique requirement of
> these drivers.
> 

I tried to make it clear in the comment by mentioning that this helper
is applicable for drivers whose primary plane is always fullscreen and
can't scale or change position.

Any suggestions of what's missing in the helper kernel-doc comment to be
more clear ?

> Harry
> 

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat