Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6783493rwn; Tue, 13 Sep 2022 08:59:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR5qMj9iclAZKSU9rg23I9mXSXcU8GeAGkXiGJjdb2qvJyWjKnOPM/ag+Q3AuAVZUBs4s7R3 X-Received: by 2002:a05:6402:1044:b0:44d:925c:41bb with SMTP id e4-20020a056402104400b0044d925c41bbmr26869990edu.245.1663084767605; Tue, 13 Sep 2022 08:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663084767; cv=none; d=google.com; s=arc-20160816; b=c6dvIxz0OUYcdCD2DjszDeE5JEnHIobDEnmsk8PSY/FQndgCzTPglIpkVLkO7p7gRS oJwjHNzYIgGC9gsOQgyH9c5HysiE97IajqmgAxhfNlQrblxExheq42xsc0mK/bpDSR+b ba9FheEX8Hw+QziCXU0UoDn24cdmc1LvCJpZpeF0V3hsCv5J8aeVwF0apePVzrQ1MRF+ Nb9v+gOrUCJkUOVJmswJsC3i1PlHoboX9B4TVOkYMZrJKoiH0t6au9vXwxccH1ZjrBsD 4kIhS9qu5zmJm+sKX8W4X32lQuEcX2Di/ia1vUGzJhR6+k5iTc7RVrAxsUnpib2lP7xK VN8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=N+dz0FR43zqSmaCipV51CZ9vqs8m43WzLH1W5Xsidp4=; b=vYX7fGsI4Tz55OVf/JBfKPhvY805WzYKFrznFByXELmtQniWqu/6V3vJvR0kwA8s9n dXU2OAHmRnnMREAtqiHUzgcTswQoCjxQ8MILkTa4IDqbeBTkEUSCycUjuGHo/0QZ56Bg E2MP1m9OmDzuJjg4lYOxw3Wm8Q7nNatmOrckXMzcSO7y3BnaQ793UdH88BCw8RlqEQeZ 1KgTYWxGiXxqXGb+VuFignIZnl/nb9tvacrI9G8IHJwuoYF8Efyzpxq2JcfMrr203eYZ 2EjOX7uQdNpjZYwePueZ+P8L53mSTE3kttKzXjMyHnplFQQRgNLmWNQqyesmaJHQiSAu DXyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dP3y5AoA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a056402274800b0043d9ec0eb4fsi11101911edd.16.2022.09.13.08.59.01; Tue, 13 Sep 2022 08:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=dP3y5AoA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232149AbiIMPnG (ORCPT + 99 others); Tue, 13 Sep 2022 11:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236627AbiIMPmj (ORCPT ); Tue, 13 Sep 2022 11:42:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3888265806; Tue, 13 Sep 2022 07:46:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 426B2B80FD3; Tue, 13 Sep 2022 14:34:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AB52C433B5; Tue, 13 Sep 2022 14:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079665; bh=EBD/uRGnid9f/eQA+YR/a315JnnSHdbyyJVR57L4o00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dP3y5AoAx6eOuPnH8pi+SdekBnYLOzY836ssxeAEZp2PVMTHB5wU8LWJa2WYf9uqe cTd2sDex9Nc1w3idnSu6YdXLTrvwngwbRCktc9IYvn67Su8ohwnlvzuwIQq0BCrKwr cp2l1x/JxS8UeNVDb58/3Obk50m/CXDe01ULevv0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Nicolas Diaz , Shenwei Wang Subject: [PATCH 4.14 09/61] serial: fsl_lpuart: RS485 RTS polariy is inverse Date: Tue, 13 Sep 2022 16:07:11 +0200 Message-Id: <20220913140346.938446978@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140346.422813036@linuxfoundation.org> References: <20220913140346.422813036@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shenwei Wang commit 846651eca073e2e02e37490a4a52752415d84781 upstream. The setting of RS485 RTS polarity is inverse in the current driver. When the property of 'rs485-rts-active-low' is enabled in the dts node, the RTS signal should be LOW during sending. Otherwise, if there is no such a property, the RTS should be HIGH during sending. Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485") Cc: stable Signed-off-by: Nicolas Diaz Signed-off-by: Shenwei Wang Link: https://lore.kernel.org/r/20220805144529.604856-1-shenwei.wang@nxp.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/fsl_lpuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -1106,9 +1106,9 @@ static int lpuart_config_rs485(struct ua * Note: UART is assumed to be active high. */ if (rs485->flags & SER_RS485_RTS_ON_SEND) - modem &= ~UARTMODEM_TXRTSPOL; - else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) modem |= UARTMODEM_TXRTSPOL; + else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) + modem &= ~UARTMODEM_TXRTSPOL; } /* Store the new configuration */