Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6801827rwn; Tue, 13 Sep 2022 09:10:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5plNO7BRsb6FZx3obFAnNd9W6oqfMOASjC4E+mfXoH2YnAlxx73TwWn9hZCV7mZ4YDsfGB X-Received: by 2002:a17:90b:390:b0:200:4c58:efb with SMTP id ga16-20020a17090b039000b002004c580efbmr24388pjb.97.1663085431420; Tue, 13 Sep 2022 09:10:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663085431; cv=none; d=google.com; s=arc-20160816; b=YBwKeom/cVIQx+hZZM1Lzdyv0FhkVhPHGllqQIf8BUwPfQOHehSyL+wRviS8t96dEe xXXES5APwfJqg/mEf1VZOXwwfmdXozhnHH3fx88YqASqfk+s+Ooe7i8r7tD4OlpsSJFC VQNaMkfROml0VobQmQvuUY7gVD/27brnqYJi1Wtnr23YoOkSUkbAJua0k10YQhH71mC0 TaIvkuq2IrRWmnxH2NLHX3UUs0h50BWkf3w0+VD/AY2W5vljzmV7mDjRvAui2GngkUx0 rfjP4OnsBnLY3wC43AKMcybtQv4P6eQwc3WEihLQGOmHRoqROkglEGB8/EdtAf9PIIg7 Wx6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sQDEuTSJW9qJgNkGdyAVcAglX4D+80ncrlNiMgBQcFs=; b=Wx2h42Ry+FWNn4VszTO8z+Z/RNiPXM7ruhYwNpdBzX1DmdYEV9uIheTruEHTtP91wA XomnHFu9WBbTnITpcEmwzJ+vhkukmmQnmrpHGUdE+4zEudoFzxcSGhfTrFjk0RHHIiRA ohV602FPlepHREA1rrvRiUzrKLF79w7GeiRP7tTSnWhCaFAM0GTj/TP0j4ulWWnxBjK8 wudMFxVk8Ofq8hZAnMgXfEYIBvmwm58YEzYA1ygtQTKgOvVp4fixpAE8mVBjqRkgtpVj FjoVdvKj2YjMLedFvUSgixl/iVB1IKoy6KowhZa/aUAHQc+xw+lKGUgQra9omzItYPp4 7KtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q4VKmnzT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 128-20020a630186000000b00438ce28756csi9863770pgb.646.2022.09.13.09.10.19; Tue, 13 Sep 2022 09:10:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q4VKmnzT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234989AbiIMPBa (ORCPT + 99 others); Tue, 13 Sep 2022 11:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235182AbiIMO7Z (ORCPT ); Tue, 13 Sep 2022 10:59:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AFC74375; Tue, 13 Sep 2022 07:28:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 24416B80F9F; Tue, 13 Sep 2022 14:27:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6698EC433C1; Tue, 13 Sep 2022 14:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079264; bh=LszwIUf0eKjljYdr0JRDc31G7ffCLdWv84uL0twAOtc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q4VKmnzT2acJg1EfGdjh5yvAOJ+iC2DvD12fsrkM9hOCnw0UDEzmuauugKSgh0X3a RFXk4n4XTQsovO0+e8BAn5LLj6hQFeRl3GNJKYQS38DwPLk6I/p/KGTBETzRhRqIXZ TDpuxbl+Gyn+F1T0MUxcBL6XkKEe6YFMSXP92cE4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sumit Saxena , Guixin Liu , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 067/108] scsi: megaraid_sas: Fix double kfree() Date: Tue, 13 Sep 2022 16:06:38 +0200 Message-Id: <20220913140356.497622082@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140353.549108748@linuxfoundation.org> References: <20220913140353.549108748@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guixin Liu [ Upstream commit 8c499e49240bd93628368c3588975cfb94169b8b ] When allocating log_to_span fails, kfree(instance->ctrl_context) is called twice. Remove redundant call. Link: https://lore.kernel.org/r/1659424729-46502-1-git-send-email-kanie@linux.alibaba.com Acked-by: Sumit Saxena Signed-off-by: Guixin Liu Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c index a78a702511faa..944273f60d224 100644 --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c @@ -5182,7 +5182,6 @@ megasas_alloc_fusion_context(struct megasas_instance *instance) if (!fusion->log_to_span) { dev_err(&instance->pdev->dev, "Failed from %s %d\n", __func__, __LINE__); - kfree(instance->ctrl_context); return -ENOMEM; } } -- 2.35.1