Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <39b0bfef-be7d-05a9-d964-19a74757bb8d@intel.com>
Date:   Tue, 13 Sep 2022 16:03:35 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.1
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in
 probe_codec
To:     Gaosheng Cui <cuigaosheng1@huawei.com>,
        <pierre-louis.bossart@linux.intel.com>,
        <liam.r.girdwood@linux.intel.com>,
        <peter.ujfalusi@linux.intel.com>,
        <yung-chuan.liao@linux.intel.com>,
        <ranjani.sridharan@linux.intel.com>,
        <kai.vehmanen@linux.intel.com>, <broonie@kernel.org>,
        <perex@perex.cz>, <tiwai@suse.com>
CC:     <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
References: <20220822035133.2147381-1-cuigaosheng1@huawei.com>
Content-Language: en-US
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220822035133.2147381-1-cuigaosheng1@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qk5KUFRqS2JqaWQ0RmdSWEgzajFSR05XeUNJOVZ6ZW80QndYSTkxekkwRGpk?=
 =?utf-8?B?YVJMYXBSdk9HN2gvbURsT1FLTGtNTUdUMDlDV01SeFAzQ2NNMzMvb3NIMjF6?=
 =?utf-8?B?Y0dXWlkwOW44RnlrOU9zRThUN3IwMmY2OTlsV21GNng1a0lyZExQUG5ZK1ox?=
 =?utf-8?B?ZUVxa0tOSFVINE5nR2V5NFNoenpXTHFIV2dlUXp0Y3BGZXdKNlBuanZqSUJW?=
 =?utf-8?B?WnVjd3hDZWlHZ0c1bStma2JKZGt1bVVkQ3BHMlRPSVhxSWFJb08vdkZrWk1k?=
 =?utf-8?B?OWRGOExWMklDMENDU1dZVk9JMVVDOEJFK2J3aG1LaUZVQ21UUUkwQ3drSmlU?=
 =?utf-8?B?WFdmcUx0by9hcTdOVE5xM2FxSWtjalBUaktzZHI1akg4cjNiZUpyc0hIOTM5?=
 =?utf-8?B?MS9MUGxPeGdMZ0ZJbGtlOXAyMGJmV1hPVVVoczJSeWtOTnd3d21ITW83QnZG?=
 =?utf-8?B?OTFwVkZ3TTlYblYxOXlEVjdPeU9MVjdUcCs5L1JsTUR0MXljMElCZHZLN0o3?=
 =?utf-8?B?ankxU1ExdVVFUWdLdm5zVlN1STNndUxqUThwM3ZPQWVadXgrNHh6bDdyMXda?=
 =?utf-8?B?RTVMY0llQUlsZ3NkWG4yYU5ycWg4Z2NDTlpMZmxtZFZZNit3VGpvcUxISjFN?=
 =?utf-8?B?K0FzaDRMczBML01Ud2gvU2VvK0RXbXdtUVFGdFdyT1BFV3I4NVU0Y0xaSnVv?=
 =?utf-8?B?Y1dqTlRPV3JUTFcrd25LT2ZWSmJBUCtXQVpXSXRON2ZJODdLVlN4K1VPTVFE?=
 =?utf-8?B?SllqRzBXL2xZZDBoU0wxNkN2T25BNDVGNjVldUhxZ1dERGw4UkhXMys4M2Fr?=
 =?utf-8?B?a0luWmlXNmpyNFVnTElmWDFnalQrWlYwV0tmQUJCTTdseXkrL0Q2QzEwZ1BW?=
 =?utf-8?B?SG9DTTg2K2dZcjduNnpKcVh1ZTM1am9NajZFTzFtV1VuOHNuK3JaU05wQVVZ?=
 =?utf-8?B?SlhCZVZxbmNjZFd1b0lhdEh2WlZBQmxDMC9GMFB3amg0MWsxRlFZcU12Wkc0?=
 =?utf-8?B?aGJXdjAvOTJ1NkZQZmh5VWxidEhVaHovaDkvQkxWUTU3dkRqbjgvc2xKS0VX?=
 =?utf-8?B?TUw1aVVwTHpybGZveWw1dlpYek1NTWE4MlZCUk0xa3hsREFyUC9udUZ3K3A5?=
 =?utf-8?B?RkNHTFF0cXk3eTN6YUtXeHUvRlRLU0o3U1UvSGNkR1A2elFsT21RSG5jM1pt?=
 =?utf-8?B?Q1YxOEJobGwyK2F0cG1XZHl1VDFqcFdqb21vckZlR3JUeGRNbkcxWmNiQjVN?=
 =?utf-8?B?MlorWFpBc0VhV0xlK1QybmxqQlZ1aWN0MngzZUlWQWhJQ3NQekFVSEt6Qi91?=
 =?utf-8?B?VGhpRkZBcjNMSGhyM1dQYmhNbitUa0h1aTh3cVM3SWlqeUVpb0krNlZiSTBZ?=
 =?utf-8?B?QU9BWXR2VnQyeFNqN0lFd1JzNVMycEpKbytPMTdFb0Mwb215TUx1cEhvdXI4?=
 =?utf-8?B?M21WdE0rd3FHbk85VVRjR1N1NW5HVmtObzhqSnpWbjd1TURTbUFmNmFRSGtB?=
 =?utf-8?B?WTlST0JNQ1VvUDUzdGRwdU5ZNVMzeGwxd2tCWWZjY2psRExzK2x4ZTFDSElu?=
 =?utf-8?B?UnUzVk9GOS9ZaHN4dktpVjZJV1RkSFNFbWhXcm1mS0QvKzdkQVZLZEYrTVBk?=
 =?utf-8?B?dzE4d3RPNnNML0NpRXo3NnpWcndMRFpOQVRSNk9iUHVNZ1dPc3BmNEFjTnFi?=
 =?utf-8?B?THlVWG1Ta1EzbGh0dnZFN2JTbS9jQWtKRG9lbm1mVXJndkdPS2Qvb3A5V3dR?=
 =?utf-8?B?UGZmOTFvRjR2aUZxUU8zMk9XK28rVWJEbUtWYUN2NG5oQnVRdVBGMG9IT09u?=
 =?utf-8?B?cUZJc05BbFNhZk9UdHRscit4S2J2aVBHNWxLaWtWR0QzQWhqZ0h6WS9HSEpT?=
 =?utf-8?B?dTdiTG9ESHc5SnEwditNU21lWGg1Yk85S2xKYzVtZWNZdUlicUh1VzBlOWlI?=
 =?utf-8?B?a1RvSTE3OVBFU3ozb2g2L0ZaZmx2TU4wMlJTMHB3TVMvWHdKK0NkQUxOZHNi?=
 =?utf-8?B?djl6ekpTY3YxeUVyWThraEs1SUp6RDR2STUwUGtCb3JhdWk3Tjd6VU5tNFI5?=
 =?utf-8?B?Tm0xbTEySjlTVmZjY2xNaUxqVlFhcVVxbmhuRWFsalRiUWEyNzlsamZzbFRU?=
 =?utf-8?B?YTdTZlBnSkZJQm0wRXpTMGJ6V0dJdXBDRlk2QVZrQTVQMy9XTnlESHZYbms1?=
 =?utf-8?B?OEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d61e368d-9ae9-49c4-a0b1-08da9590c478
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 14:03:43.3539
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EIB5o1S1+Xj9hdbulwZX4jub1cnlKSSbUM2VAdhG66xrO0F5J+0sKX8GVnelL7tx6DM/UWpzs53VYxx3tjUTuena7Q60/uwcpMcCGwC0n0c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4949
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-08-22 5:51 AM, Gaosheng Cui wrote:
> In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> gcc warns about an unused variable:
> 
> sound/soc/intel/skylake/skl.c: In function ‘probe_codec’:
> sound/soc/intel/skylake/skl.c:729:18: error: unused variable ‘skl’ [-Werror=unused-variable]
>    struct skl_dev *skl = bus_to_skl(bus);
>                    ^~~
> cc1: all warnings being treated as errors
> 
> Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>

Thanks for the fix.

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

> ---
>   sound/soc/intel/skylake/skl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/skylake/skl.c b/sound/soc/intel/skylake/skl.c
> index c7c1cad2a753..52a041d6144c 100644
> --- a/sound/soc/intel/skylake/skl.c
> +++ b/sound/soc/intel/skylake/skl.c
> @@ -726,8 +726,8 @@ static int probe_codec(struct hdac_bus *bus, int addr)
>   	unsigned int cmd = (addr << 28) | (AC_NODE_ROOT << 20) |
>   		(AC_VERB_PARAMETERS << 8) | AC_PAR_VENDOR_ID;
>   	unsigned int res = -1;
> -	struct skl_dev *skl = bus_to_skl(bus);
>   #if IS_ENABLED(CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC)
> +	struct skl_dev *skl = bus_to_skl(bus);
>   	struct hdac_hda_priv *hda_codec;
>   #endif
>   	struct hda_codec *codec;