Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6824898rwn; Tue, 13 Sep 2022 09:27:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR7cfV8hr55bbjtWoEQ2HatCGeyEcZiiGfSavB0LglNM1sSij2VkZbuwWegeKwemVlU31rHi X-Received: by 2002:a17:902:ceca:b0:177:fa1f:4abc with SMTP id d10-20020a170902ceca00b00177fa1f4abcmr24833156plg.99.1663086474969; Tue, 13 Sep 2022 09:27:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663086474; cv=none; d=google.com; s=arc-20160816; b=y2iCCsWD2jp1q3zSLt651Lg4ESDBNy6IIJHt053GdpIG8rOcq+phrGXO84m2iZ94HN sqC2m4m5nMm/3i1Lv6GfZbXZhkakBGR7sAH51SA5l7e9h4VrE8+ECbRwNJEfxU0SfIE5 Sd537sU9HKZntP4aoel27Dh/KfhPtqPKnetxL9R7u8hAVtKF406p40l3MuqCGTZu6BQ6 i38VTNV7+JAmTATUpz4eTSrHIrLucRnBXq0QqEavM4Xnmbtfkr4jTvY7C5VFbbZVD7KK TBkdnWqyi/GMJtRWHCZf+6N+nk1eZ5cqaZn8w6pjKH1oms/KDY5d/t85itJxrdmAoo9a Hyqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wHIUwBlqx2HpzPpa94apLrLGdDBR1YCZyRCYl7LMX6w=; b=JyOyT/fKl20BCr2ttIkiwB0lEtUSetAzWcjHsrP7rFEIXq2iPngGkbdOA6ulP6VsPu rsuSWAdwBtelsDvAutcyvEUQWyDZHIzgCK44UL4jiKSPC5UNc8GqcZ692S7WbjBoWez+ VNSF0HQtbb2I8INaJiDeB2FVq93+CxYEw9nC+pRZVnhcL5RcZgKI0wTPJYFVnRDJv50l z8FKNYkfPX+7Zml5JloGIxLacVvgcl+/XgE5P6dTRjzcWXrxU3FnWtZJX5ZCmesNxH56 AGz3sVx29uCSMj+M/ny9alVKhdR7o4n4a1/12Pujg9ffR8kuI+dIAreTFdRiuU65lP0z 5xCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v8u7tUxa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d32-20020a631d20000000b004301e6b2ec6si1366899pgd.601.2022.09.13.09.27.42; Tue, 13 Sep 2022 09:27:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=v8u7tUxa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234838AbiIMP3i (ORCPT + 99 others); Tue, 13 Sep 2022 11:29:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236337AbiIMP1q (ORCPT ); Tue, 13 Sep 2022 11:27:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8457DF6F; Tue, 13 Sep 2022 07:38:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1D528B8100F; Tue, 13 Sep 2022 14:36:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82E6FC433C1; Tue, 13 Sep 2022 14:36:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079814; bh=kTlwYCdkvEMfgQrk4jUIzACSTPPkBkveoQ3qvraNI+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v8u7tUxaRVwMklX678qmZudeIYFF5jd/QK9Z2AaS2s+CbaaPRY8C2o0qAdKoxL5Sn WmnGE7xEwSy0cieYyD7fgNhSEiSziEH3JZCbVdHkj5hMQeHuFYfWYxQrCk83OfOOR0 JtFWpztR7xNpOEANgC1rC4hokQVeRloEWquUzM5I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Nicolas Diaz , Shenwei Wang Subject: [PATCH 4.9 04/42] serial: fsl_lpuart: RS485 RTS polariy is inverse Date: Tue, 13 Sep 2022 16:07:35 +0200 Message-Id: <20220913140342.463369308@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140342.228397194@linuxfoundation.org> References: <20220913140342.228397194@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shenwei Wang commit 846651eca073e2e02e37490a4a52752415d84781 upstream. The setting of RS485 RTS polarity is inverse in the current driver. When the property of 'rs485-rts-active-low' is enabled in the dts node, the RTS signal should be LOW during sending. Otherwise, if there is no such a property, the RTS should be HIGH during sending. Fixes: 03895cf41d18 ("tty: serial: fsl_lpuart: Add support for RS-485") Cc: stable Signed-off-by: Nicolas Diaz Signed-off-by: Shenwei Wang Link: https://lore.kernel.org/r/20220805144529.604856-1-shenwei.wang@nxp.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/fsl_lpuart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/tty/serial/fsl_lpuart.c +++ b/drivers/tty/serial/fsl_lpuart.c @@ -951,9 +951,9 @@ static int lpuart_config_rs485(struct ua * Note: UART is assumed to be active high. */ if (rs485->flags & SER_RS485_RTS_ON_SEND) - modem &= ~UARTMODEM_TXRTSPOL; - else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) modem |= UARTMODEM_TXRTSPOL; + else if (rs485->flags & SER_RS485_RTS_AFTER_SEND) + modem &= ~UARTMODEM_TXRTSPOL; } /* Store the new configuration */