Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6830602rwn; Tue, 13 Sep 2022 09:32:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR7t4+CJjel5oWviUQlztKSQzummniZH4h/G6yM7f62/xLZzRD+R7dQE61b50rnVro9pwmMu X-Received: by 2002:a17:902:ecd2:b0:178:3b53:ec0d with SMTP id a18-20020a170902ecd200b001783b53ec0dmr8007685plh.167.1663086739382; Tue, 13 Sep 2022 09:32:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663086739; cv=none; d=google.com; s=arc-20160816; b=QNDSYDHlbbchHKc8Y5+qVaUf0ua2bw538KQ6zGyCLsfUiCR8DQ74xrlO/O0IKKHrtT qvf7rkjsUeVf70oJ+Sz/WuXeCmepYQOvhaC0UPqMr2Fk0/B+Pa73CnySjAly6pKdl4aF sE9Y8Sb5W90n3jVmS8Fs+y/RVTpcMlu1liT1wbLQwhrFREIJJW77psctWpNfvqx30Cew zbGksnzg4SdubXCH26yicCrFWrBWtDKBPsLhy57WZt8FDxo719RWspUjAwsMRrRWo/eL cD+YofA5OX/u2DfU8TLt0F36FKl5jdM0rzz4F33s2yHSUS4aMTWL/H3lqVOeSWKctvji FpOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+HBkN/zl33RUwHuEmf4mSA/aoVPiMbBegUC5w8roQ/g=; b=n7J5wwTBKxC4g75PMrVd9wFUoqpKl20u36bu7UZobrl9syq24XqWF+08HbsyW1d+Xt axVefmNPFyB0A15X6uU+lZ07bP6RWvYfVWoND+e+t9foEgydZ4/CcYgpsGogxegqi2e4 SL2jWW+frh+m32m4hDBnpQ+4whZHJhlt0q4j08YhOeiBrjSWdGvFrAoFpIkmGqifmlP3 tdFDb30Ed5+lJ0lCgh8HeR9qC8KFkDKTAsCHF/J9LP3irm9fE7MlYCnuwdteOiSqdT4P gxkMoSxcaYrCrfUSgOfb3t3JBBr9xqfDFFfoWdYCqMd3ePGGUeebmQiGK7ysy1xEpqep /y3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="brn7s/hk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u41-20020a056a0009a900b0052f0fa0c853si12730762pfg.241.2022.09.13.09.32.06; Tue, 13 Sep 2022 09:32:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="brn7s/hk"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233651AbiIMPVJ (ORCPT + 99 others); Tue, 13 Sep 2022 11:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231443AbiIMPTS (ORCPT ); Tue, 13 Sep 2022 11:19:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 835937A755; Tue, 13 Sep 2022 07:35:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C72FB80FA1; Tue, 13 Sep 2022 14:34:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7E21C433C1; Tue, 13 Sep 2022 14:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1663079639; bh=O5f0jtSE1uRp2jrEftSCTllACyDU9RvDwCQ38tjT/Uk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=brn7s/hkvqvhvVKf6OYAsNMRGtfHnU1Bqs/tMP6o0q+Dszetm8OGS+csQxOFw7L2w vjWcMmTpJSIGWrzdA8zRYO2xK899BR38g8vaB6s3KYPqDqqS7dA4/64CluafsV0nam cf63g9D2B6UT6xzcvGjWC3JgVg4pTP2v/yAGYQVc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mika Westerberg Subject: [PATCH 4.14 17/61] thunderbolt: Use the actual buffer in tb_async_error() Date: Tue, 13 Sep 2022 16:07:19 +0200 Message-Id: <20220913140347.385907952@linuxfoundation.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20220913140346.422813036@linuxfoundation.org> References: <20220913140346.422813036@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mika Westerberg commit eb100b8fa8e8b59eb3e5fc7a5fd4a1e3c5950f64 upstream. The received notification packet is held in pkg->buffer and not in pkg itself. Fix this by using the correct buffer. Fixes: 81a54b5e1986 ("thunderbolt: Let the connection manager handle all notifications") Cc: stable@vger.kernel.org Signed-off-by: Mika Westerberg Signed-off-by: Greg Kroah-Hartman --- drivers/thunderbolt/ctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -401,7 +401,7 @@ static void tb_ctl_rx_submit(struct ctl_ static int tb_async_error(const struct ctl_pkg *pkg) { - const struct cfg_error_pkg *error = (const struct cfg_error_pkg *)pkg; + const struct cfg_error_pkg *error = pkg->buffer; if (pkg->frame.eof != TB_CFG_PKG_ERROR) return false;