Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4d4e7550-4d70-1f0b-0d84-4d700a99d74b@amd.com>
Date:   Tue, 13 Sep 2022 11:08:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH v2] drm/plane-helper: Add a
 drm_plane_helper_atomic_check() helper
Content-Language: en-US
To:     Javier Martinez Canillas <javierm@redhat.com>,
        linux-kernel@vger.kernel.org
Cc:     Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org
References: <20220913093339.106625-1-javierm@redhat.com>
 <b81591c4-934c-4b70-fbf0-b0f4663a6d1c@amd.com>
 <2b67dfcc-9027-6bb5-d42b-7465f2236747@redhat.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <2b67dfcc-9027-6bb5-d42b-7465f2236747@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?blJyV3QxU0g0YlJuQUpxSHh2TGwrY2s3YzdMS3E2clRCNmdxek1yekJ0Zzlq?=
 =?utf-8?B?ak9DMGFLSUxPenRsWUFFaHJuN1dOU25YQTZkUllZcEJrampEcktCQWJZTmpp?=
 =?utf-8?B?NmhjS2xNSkpQYVUrTXo1cVUxNmxLR1NPVE03bytObWp5ZUtESW1iWG9lUElF?=
 =?utf-8?B?TDIyK2xLU1FEVUhLcStYNjRTV1RKb2VkcmZ3Tk9KcXQ1S1hBN0ZueUJXMkpn?=
 =?utf-8?B?T3R5RU40Q0hidm5sckxid081aEZvODkwZnRxclpRaTQ4TzI4RkRhTFdnV2xT?=
 =?utf-8?B?TkNaK2JjZG8vT3BpZzh5U1lzWW11aHhzUnNaMkpoT1hheEZ3MmZxTk4zcTRp?=
 =?utf-8?B?OE5WZ0hJazFtZEJBSjR5MGVkbXdwUmtTK0RlZVkvMVBOd1lIUFIrMWhKWXhx?=
 =?utf-8?B?cGF0OE1scnRvMjV2WnRBM3VwUllUUDREeGtXaTZ1QTJoVitHYlZGODQ3WkJR?=
 =?utf-8?B?NTA0NkR0czhvRHJkOSswVEU0VnRUaStjamhoTFhrRWN4cTRXK1RCVzlIaHRu?=
 =?utf-8?B?SVUxbmN0N3ZpMU9GZUpnWHZldFRTR0p2K2lpOVQ3SnlhczQyVGVvWCtwcmI0?=
 =?utf-8?B?b01pTFhsTEh5WUlIMUtxaHNBeGQ4MTFVQ3lpcVhrdG9IaGdQOUZDaUU0bHRI?=
 =?utf-8?B?LzBQT1NkVDI3MkQ5dkgwT3hzZUhneXdtMUVrQ0YwWHJmWWRkQ0o3Nys2d013?=
 =?utf-8?B?VjE0UUM1M0JjOUlBRWE1NDdza0xxNUlyOTZTanR1NE5tUUsvODNVLzh2UXE4?=
 =?utf-8?B?anpzZG9iVXBvL1VqR0lIZk15QzJ1azk0S2p2MEdiNUxTV2paa3RRNUVtM0FG?=
 =?utf-8?B?MWZCWHR2UGQxd293ZmlvMXp4YVk5ZTdoODkxOEk4eTZ5aFNkcklxQzI1aW5C?=
 =?utf-8?B?cXVlbFg2VUdCcXB4K1EvL1llelZHT0lVU00yTGpOeGgzOVBzL2doOHNrZTN3?=
 =?utf-8?B?YjVYTXdOSXhLdFR1VnZjamVZVEpVL1VRQ1REMzh4U3ZQL0VoREh2TUtVa0s3?=
 =?utf-8?B?Q2N3cFVWY2dxM2paZzFVUjB4TWdra1p5QU9ZcjdWZGl6N2tMa0pTcFdlMGV2?=
 =?utf-8?B?STNITG5uOVc1QjJlL2FlcHRYZ0FHMWxtZXdpeG95ZjBrSktKSiswRHh6K1ND?=
 =?utf-8?B?ajBEekNCOUwrNEJBNWs2bE5wd2lMUmhaSUVtR0tyMUs2UWpMLzRYSXJucCtl?=
 =?utf-8?B?eW1LTFI4ei8zRU5nT1lYcUVUNi9qb2Q4VXFQUC9TdWU4c0hxUUNNK2JoQTB1?=
 =?utf-8?B?MDFxQWo1SXpFdEtMU0dUL2I0YUhQUnJGTm9UZElhM1B4S3ZVbElzSlJEM2Fw?=
 =?utf-8?B?MEFQbE1SZDl6WnZFTXdVWEVUeDFNVjh1OVYzdnBwUEFCVTA4bUVVYjZjSWha?=
 =?utf-8?B?ZCt6SURZK05hb0poeFN3OE1kQ05FVFNFZSs4ZzBjSGFqVkNlVXFCZXdyc2FE?=
 =?utf-8?B?MmQ0NHFCSFBYYkNBdEZQSzBvbjJjUlB6OTFLUVlRR1cyVDZqZ3M3bjN1c3Zz?=
 =?utf-8?B?bGZBelE2dnA1TGdXOWlCZTN5NG5JclhmSnA2R1hKVGJZL2hMUEdpQzZmYURu?=
 =?utf-8?B?dmd4V3pLcU5lbE9nZWo0MnJPbVcxc1ovOTRwcG8ydGl0WWFNRjZocmZ3Sm9Y?=
 =?utf-8?B?blVDdU5BOFRuODVyMUhyeFhmd0pXcmlvUzJLcE84RXkzc0NnMmFpVFZUZzRl?=
 =?utf-8?B?V2puS2tNYmhjTUtZQXJJMHprakFYdlVIeFE2SmYyNnZYZWFxYWp4Y2w0bzgr?=
 =?utf-8?B?aThKdFNVWWtJL2VFdnZGT0tlN3l2ZTVsS1A3d0FLRDBHSEkzemxJb3BJb0Vt?=
 =?utf-8?B?dnhVeDV3YTR2MW1VOVNGb2xkUFE0WmIwd2MrT1lHdVdhLzRaWmlBWWtUUERP?=
 =?utf-8?B?L3JKWnhEWExQQkV1YStTT3NKTUdtUkxlQUxKZUt4eHl0UCtyZlY3bjRsQ3hK?=
 =?utf-8?B?ZjBzbEcwREp5L0p3Wm8zUWdaK3ZNWElTRzU2cXdxbFE3c3VoK242YkF3MGdU?=
 =?utf-8?B?dHlvSHd5MXZDNzYyWTZNUDcvdE9yaktydEJpRXdDdlJtamhKa01ibzB1MFNU?=
 =?utf-8?B?YUdtajB3OXhBeWJ6VWExMDd1a0RtUThKL2pWY2R4clVxRExUclg1eDhBVWlP?=
 =?utf-8?Q?WZToMM6QVaBhqwGX/w/+8QPDS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 737b7617-676e-4795-4853-08da9599c46a
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 15:08:09.0117
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D4N+xLSsykYKA8SZDFCgFVFnxtbmCinjCCFXfdHw2wdrw1l3DWHWBfIA//hqTQfLAMjm0cnq+rzgg3vNu+QXVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5247
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2022-09-13 10:46, Javier Martinez Canillas wrote:
> On 9/13/22 15:49, Harry Wentland wrote:
>>
>>
>> On 2022-09-13 05:33, Javier Martinez Canillas wrote:
>>> Provides a default plane state check handler for primary planes that are a
>>> fullscreen scanout buffer and whose state scale and position can't change.
>>>
>>
>> Even though this might be how some drivers are handling the primary
>> plane this assumption is not universal. For example, on ChromeOS when
>> the (default) underlay strategy is selected the compositor will
>> position the video plane as the bottom-most plane and mark it
>> as primary, while the desktop plane is marked as overlay and
>> will contain an alpha cutout to show the underlying video.
>>
>> In this case the video plane (primary) won't span the screen
>> and is regularly panned and resized.
>>
> 
> I see. Interesting.
> 
>> No objections to this change as it helps share code between drivers,
>> but maybe specify that this behavior is a unique requirement of
>> these drivers.
>>
> 
> I tried to make it clear in the comment by mentioning that this helper
> is applicable for drivers whose primary plane is always fullscreen and
> can't scale or change position.
> 
> Any suggestions of what's missing in the helper kernel-doc comment to be
> more clear ?
> 

After re-reading I see what you mean.

A sentence to the effect of "Some drivers require the primary plane
to be a fullscreen scanout buffer..." or similar might help clarify
that this isn't universal but helpful for drivers who require this
constraint.

Harry

>> Harry
>>
>