Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 17:21:40 +0200
Message-ID: <874jxbfgfv.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Cezary Rojewski <cezary.rojewski@intel.com>
Cc:     Gaosheng Cui <cuigaosheng1@huawei.com>,
        <pierre-louis.bossart@linux.intel.com>,
        <liam.r.girdwood@linux.intel.com>,
        <peter.ujfalusi@linux.intel.com>,
        <yung-chuan.liao@linux.intel.com>,
        <ranjani.sridharan@linux.intel.com>,
        <kai.vehmanen@linux.intel.com>, <broonie@kernel.org>,
        <perex@perex.cz>, <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec
In-Reply-To: <39b0bfef-be7d-05a9-d964-19a74757bb8d@intel.com>
References: <20220822035133.2147381-1-cuigaosheng1@huawei.com>
        <39b0bfef-be7d-05a9-d964-19a74757bb8d@intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-7
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 13 Sep 2022 16:03:35 +0200,
Cezary Rojewski wrote:
> 
> On 2022-08-22 5:51 AM, Gaosheng Cui wrote:
> > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> > gcc warns about an unused variable:
> > 
> > sound/soc/intel/skylake/skl.c: In function ?probe_codec?:
> > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ?skl? [-Werror=unused-variable]
> >    struct skl_dev *skl = bus_to_skl(bus);
> >                    ^~~
> > cc1: all warnings being treated as errors
> > 
> > Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> 
> Thanks for the fix.
> 
> Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

Applied now.


Takashi