Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757957AbXFSKEP (ORCPT ); Tue, 19 Jun 2007 06:04:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755962AbXFSKD6 (ORCPT ); Tue, 19 Jun 2007 06:03:58 -0400 Received: from TYO201.gate.nec.co.jp ([202.32.8.193]:50900 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755950AbXFSKD5 (ORCPT ); Tue, 19 Jun 2007 06:03:57 -0400 Message-ID: <4677A9ED.80208@bx.jp.nec.com> Date: Tue, 19 Jun 2007 19:03:25 +0900 From: Keiichi KII User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Satyam Sharma CC: Matt Mackall , Andrew Morton , David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RFC][PATCH -mm take5 3/7] add interface for netconsole using sysfs References: <466FC455.5060001@bx.jp.nec.com> <466FC6BB.4040105@bx.jp.nec.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 33 Hello Satyam, First, I'm sorry I couldn't reply to your comments. I'm so appreciate for your comments. I will fix my patches following your advices. But, I have some questions on the another patches. So, I want to ask you some questions and answer your questions. >> +static int miscdev_configured; > > Is this really required? We just return with error if misc_register() > fails during module init time itself, so it's not really useful ever, is > it? You're right. It isn't required. Thanks -- Keiichi KII NEC Corporation OSS Platform Development Division E-mail: k-keiichi@bx.jp.nec.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/