Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 18:13:21 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        =?iso-8859-1?B?Q3Pza+Fz?= Bence <csokas.bence@prolan.hu>,
        Jakub Kicinski <kuba@kernel.org>,
        Sasha Levin <sashal@kernel.org>,
        Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [PATCH 5.19 123/192] net: fec: Use a spinlock to guard
 `fep->ptp_clk_on`
Message-ID: <YyCsIZnjR11y8obI@kroah.com>
References: <20220913140410.043243217@linuxfoundation.org>
 <20220913140416.124325107@linuxfoundation.org>
 <20220913141917.ukoid65sqao5f4lg@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220913141917.ukoid65sqao5f4lg@pengutronix.de>
Precedence: bulk

On Tue, Sep 13, 2022 at 04:19:17PM +0200, Marc Kleine-Budde wrote:
> Hello Greg,
> 
> On 13.09.2022 16:03:49, Greg Kroah-Hartman wrote:
> > From: Cs?k?s Bence <csokas.bence@prolan.hu>
> > 
> > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ]
> > 
> > Mutexes cannot be taken in a non-preemptible context,
> > causing a panic in `fec_ptp_save_state()`. Replacing
> > `ptp_clk_mutex` by `tmreg_lock` fixes this.
> > 
> > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock is disabled")
> > Fixes: f79959220fa5 ("fec: Restart PPS after link state change")
> > Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@pengutronix.de/
> > Signed-off-by: Cs?k?s Bence <csokas.bence@prolan.hu>
> > Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> # Toradex Apalis iMX6
> > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@prolan.hu
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> there's a revert pending for this patch:
> 
> | https://lore.kernel.org/all/20220912070143.98153-1-francesco.dolcini@toradex.com
> 
> ...as it causes troubles in 6.0-rc4:
> 
> | https://lore.kernel.org/all/20220907143915.5w65kainpykfobte@pengutronix.de/
> | https://lore.kernel.org/all/CAHk-=wj1obPoTu1AHj9Bd_BGYjdjDyPP+vT5WMj8eheb3A9WHw@mail.gmail.com/
> 
> please drop this patch.

Now dropped from all 3 queues, thanks.

greg k-h