Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6921944rwn; Tue, 13 Sep 2022 10:53:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR5eXtRBa9w0yJ42NMxHDNJ2priRPqTVGmy9DN/qk9Thjqskqp52KrhyOl/kFzAH+gDNIC6Y X-Received: by 2002:a17:902:b942:b0:178:4a7e:da04 with SMTP id h2-20020a170902b94200b001784a7eda04mr3237138pls.8.1663091610448; Tue, 13 Sep 2022 10:53:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663091610; cv=none; d=google.com; s=arc-20160816; b=W4W1u4FYn9Dg+qV7fWrbK6y4qv5I0ZCl2rBRQ3ils3DwX4kn+VCI3twJp/Otp0/T9n /6HnUcMl6f1I8YAoqVblPCRxGoSAZAqsv4vYxajtqZ/1VU50D6oWBlE4Et48rifhZggz kj7I/7ROy06UmNpUoMjFkywtDhKw8z7dW3jdDf2IdE+0ysnZC0W+7aWNXMl1hGLYpz9s rD0Ck2a05ABmaRvfA1TDIBT3TsRLULvAlARsCmF7EwYor3/F3Z57ODqSNfLZaT9qJNPC P6Qm28gH0OWcmBYIvTrp51fm5cfC7hSHv/nveo44tbGEjSMu2MxUyNvSIELhVaur/eI4 zJnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=96FHg4PwZf78HwOyzcRDqObFpkp/iVj6dw232Z0WivE=; b=dULDW5FZi//gT1yUE44hyvBYbyVTHICYb4Rj7YR7MIRwVg7TauXTAZwtRm7ID1ZF9y QjhrXga8ztcf8qu13A5zW5ktH+022E71oJOvbOQ+juVCylXNaDwsxH05gH651n3oywxU S2zzPhNVujYhgHuPtX1IZoTSqf829YT71tHnJ9JRYqo9+fQ5wX6sCgdk1diUivwSR5h2 pKbH5LwV1uoysr7cADYumoQUzSD8ZAx7ump2GFlK/mKm5YKnMAhwhhiQAHMKWjXS9cct SdW6tGrTyDrTWZiCaW8CMTjrigegYBQFllBOM9tTHttWWoZBzvtFQnDwW7fWkMfd901V SZYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mu9-20020a17090b388900b001fbbcd6f8eesi14138274pjb.73.2022.09.13.10.53.18; Tue, 13 Sep 2022 10:53:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232735AbiIMRPw (ORCPT + 99 others); Tue, 13 Sep 2022 13:15:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232713AbiIMRPU (ORCPT ); Tue, 13 Sep 2022 13:15:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDB0525E94 for ; Tue, 13 Sep 2022 09:03:30 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY8HN-0003Bt-IC; Tue, 13 Sep 2022 17:56:53 +0200 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:e27a:1417:2420:c072]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 5AD49E2362; Tue, 13 Sep 2022 15:56:52 +0000 (UTC) Date: Tue, 13 Sep 2022 17:56:43 +0200 From: Marc Kleine-Budde To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, =?utf-8?B?Q3PDs2vDoXM=?= Bence , Jakub Kicinski , Sasha Levin , Francesco Dolcini Subject: Re: [PATCH 5.15 084/121] net: fec: Use a spinlock to guard `fep->ptp_clk_on` Message-ID: <20220913155643.yxl27etklqql63fb@pengutronix.de> References: <20220913140357.323297659@linuxfoundation.org> <20220913140400.979880696@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uetahg2uluswqgbg" Content-Disposition: inline In-Reply-To: <20220913140400.979880696@linuxfoundation.org> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --uetahg2uluswqgbg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 13.09.2022 16:04:35, Greg Kroah-Hartman wrote: > From: Cs=C3=B3k=C3=A1s Bence >=20 > [ Upstream commit b353b241f1eb9b6265358ffbe2632fdcb563354f ] >=20 > Mutexes cannot be taken in a non-preemptible context, > causing a panic in `fec_ptp_save_state()`. Replacing > `ptp_clk_mutex` by `tmreg_lock` fixes this. >=20 > Fixes: 6a4d7234ae9a ("net: fec: ptp: avoid register access when ipg clock= is disabled") > Fixes: f79959220fa5 ("fec: Restart PPS after link state change") > Reported-by: Marc Kleine-Budde > Link: https://lore.kernel.org/all/20220827160922.642zlcd5foopozru@pengutr= onix.de/ > Signed-off-by: Cs=C3=B3k=C3=A1s Bence > Tested-by: Francesco Dolcini # Toradex Ap= alis iMX6 > Link: https://lore.kernel.org/r/20220901140402.64804-1-csokas.bence@prola= n.hu > Signed-off-by: Jakub Kicinski > Signed-off-by: Sasha Levin If possible please drop this patch, a revert for this is pending. For details see: https://lore.kernel.org/all/20220913141917.ukoid65sqao5f4lg@pengutronix.de/ regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --uetahg2uluswqgbg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmMgqDkACgkQrX5LkNig 011kTQgAr+tN3ojAjG2S+H30WKTvScjR7KCyHl4RLOfLIFqgWKs3KAY9dhd7ip23 JM79wMWuL9WpKxcpIy3UfXV/iPdLmHHUTdKMRAbVYlb9swFgG2IeZ8w+yUM94F+r 5NoKxO6hVchIrqPviRClHFIavASBY1XWdY2SDpcKXLUAky7QxgrDTz7DNgKGgjbW WIwlOHTBySwLQvrEcZ9b7rAvHIDarcIY2Kt5pbtT+wf2wtjxEkp9rNhV+KtWlBMR RqXuXp3FtDUjFnG+vvlny2Qx5l5gNGbZ+Q0vIZ+lCSQRjrgppCtwGG2fne0a0gcs F1fQxAv/U8qMln19a6siozLVv2cKtQ== =1bl0 -----END PGP SIGNATURE----- --uetahg2uluswqgbg--