Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b1c243b0-2e6e-3254-eff0-a5276020a320@nvidia.com>
Date:   Tue, 13 Sep 2022 18:00:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH V1] PCI: dwc: Use dev_info for PCIe link down event
 logging
Content-Language: en-US
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Vidya Sagar <vidyas@nvidia.com>
Cc:     jingoohan1@gmail.com, gustavo.pimentel@synopsys.com,
        lpieralisi@kernel.org, robh@kernel.org, kw@linux.com,
        bhelgaas@google.com, treding@nvidia.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20220913101237.4337-1-vidyas@nvidia.com>
 <20220913165159.GH25849@workstation>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220913165159.GH25849@workstation>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VnhUT3dEbVAzV2xyT0Ixb1BHMDUxQkR0MWxVTTJIUUZvOWpoTk1BTFZianlv?=
 =?utf-8?B?UXBZYzlWeU5naUV1QXcvTEVYaWwzYnZ0UXBXT2Rrd0V1d251aTFNL1pSb1la?=
 =?utf-8?B?NzJsMVAwdmdObXNKRURoYno4YkR1bVp4elY5M3B2ZVJZSmlzYlFSUDFSQnYy?=
 =?utf-8?B?dlVVbHpLQkd3cXpPSUZ1WFdpUG9JZDI3MWVSZzRKNmgyUTh3NXRreHJGZThW?=
 =?utf-8?B?aVIxdDFmR1I3MXN5MUpmcWVSaUFGVnhSMmVmOHlMb1JrK2xyYWptNXdGSkJ0?=
 =?utf-8?B?eFo2bGZMK0QyRXZNb003cUFoOUhseEhLdVNmeFBSamxrSXAzaWlrakluWCtJ?=
 =?utf-8?B?cjEzRmgvY0k0eVA2Z0pqdW1URlpzVElPOE9UdXEvY0tiVHZWOGdSUUJ6WXNq?=
 =?utf-8?B?Z05tazZiUktBZStLUXpOYkJXMjFrZXl1Y2ZxSEk5UjRMbTBxSEZGVnAwMzIr?=
 =?utf-8?B?aVlQK29VKy84WWRPTHcwYmxQYitJQ0hSbTQxbnlDcGEybnhsN0k0d1djbkNT?=
 =?utf-8?B?d0xCcHNKMW1yNlpzd1lrOFArQkt2ckdzN1NJVlMrT3dsbTBDSzZJdXlla0dE?=
 =?utf-8?B?anRnd0RqbWJuSGV4UGIzN2NlZVE2VHgvWDhJSm01dFVLWTZtdFd2cHlaZ3E5?=
 =?utf-8?B?czZlamNTODdPNWdNZjZrQjBndlVFZnN2T0xQcWk1WTNBMU5xMmxvYysxb09l?=
 =?utf-8?B?TFBCNzZSMTM1ZHp1VEdCWTNBTnpYbi9lcUtRU3pJdEhZV3Mwc0pWckdMMDY2?=
 =?utf-8?B?L1BySmtKem1mSUVYbVJQNTB4dFExa2h1ZG5DdVhtYWJHNWlRdnJ4eVpLeTgr?=
 =?utf-8?B?UHZmbS8zelByamcrRkdCR0NKRjI0RGFhR29FMVZIQk4wQ1hJc1Q1MGFOVDFF?=
 =?utf-8?B?bkd0cG8yZThkeHk3dUpTSWk1TjBwSHB0NmpsVlRzL1FhbHcvSlR4WUpzVzdj?=
 =?utf-8?B?TnZNNlY5WFQrVUloYlRkMXhXNWhXVFRuTW9OVTRNTDNxdjZEeHUwWW5BOTVz?=
 =?utf-8?B?eFcya2ErV1FVQ0dGUTNxOS9YKzN1WWVxeGovSGlBcDZGNFQ1cHF5SDdaLy9w?=
 =?utf-8?B?WmFGdXNFSE0yR3hSaG5DNUFWWjBtVkQrRTRUNXdaaFg1TVppZDhRdmxORFFN?=
 =?utf-8?B?ZnFPdUpXeVhaMmlWZElPRkFjMjNQNG5HNkYzc2YvY0IrWmJNazFlbVJSazJZ?=
 =?utf-8?B?U0EvTW1OZzlueWd6Zy9hNXpCbUtQMVZ0ODN4WTExVlZhTXA0a0lYQlpJakx6?=
 =?utf-8?B?aU8ydGk3Vm9UY3FsZzNxenFGYjFXTkp1VjhHUEd6K3FRRW0yUDlzdGlHRGhw?=
 =?utf-8?B?UGRFKzR4TC9udTVtTjhEMUh0QUdQVjU3VXAwZUU3WTd3akpqZjJ2VmZuRVp1?=
 =?utf-8?B?cDY5amFHUnNuY1lCUDRNVE9kMHh4dllmUFhFbE13YVUvWnJ0VmlCM09oTlgx?=
 =?utf-8?B?ZGlwdktZN0FuQUJiLzFsTFc4WGpRZXlIbS9MTVhyK2VsNTV0Y1p6dk9nWk1N?=
 =?utf-8?B?ZzhPbkt4QkhVZ0RmL00vNlY1S0E3MTRVc1laUFpVakRpQkVZYTZFZVFJNlFV?=
 =?utf-8?B?eDBYQmV3TFd5VFhRTmpkeVRsVjE1NG5ZTHI4bVlNd2ZkRG40SnVObUZuQUlW?=
 =?utf-8?B?ellaeVFCQjdBb241VnNWZHVuNm03MnpsQ1NoR0FlNUhDQUlzREh3bTJlTmFB?=
 =?utf-8?B?RFpXTjJEZHQwS3dMWktBSU1Lb0s0OCtkWUpnbUNwR1k2M0NvNUl6ZmgrZUww?=
 =?utf-8?B?dEJ4Z0JjeEhBdU16ejBIdVRwclVoU25VOWtub2lKSWJ1MDRLVSs3L2F6VUpE?=
 =?utf-8?B?N2t6cDBWWm0rUmRnZHF4QXFDZGtCNVBPZEtOQUJyMVRpenQrMnBWbmpwUWVm?=
 =?utf-8?B?TTFYOHRHV3MyMmd0eXY1d3JPYVMrTmxGdHcwK0tOazI3bU9zMG9PTUx0Ynh6?=
 =?utf-8?B?TFF6RmljRHppTDZVTzIwbHo3NFVOQVBlczdUbi8zaStyMTBUeHhBaGk2VElr?=
 =?utf-8?B?cEI5V1dxZXZSUGk0UFUrbFh2ZWtGQ25yQlRJY3JINTVhUkRqNTR0L25JTXA4?=
 =?utf-8?B?N1ZIMVVIV1ppRmFJOW1GMkEzQkFLUmFzM0Y0KzN1Q1huY1hzdDFuOHpTVUNH?=
 =?utf-8?B?R09oUU1lWnU0azNkZHhuekV1Z2RSb2t4cHF4ZDZNd0ltQ3lpUUczYlBKR2hz?=
 =?utf-8?B?bmc9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2fa4b74-7f3d-42a1-af06-08da95a97aed
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 17:00:37.3879
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CMQKfvZJoNWD1v+mzP6HRHJKPOvaNWTrDX85vYGMyJrM7cmmFvnfyeaICwr2jB6YCBrPCnUFrjS5BKICzq884g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7197
X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 13/09/2022 17:51, Manivannan Sadhasivam wrote:
> On Tue, Sep 13, 2022 at 03:42:37PM +0530, Vidya Sagar wrote:
>> Some of the platforms (like Tegra194 and Tegra234) have open slots and
>> not having an endpoint connected to the slot is not an error.
>> So, changing the macro from dev_err to dev_info to log the event.
>>
> 
> But the link up not happening is an actual error and -ETIMEDOUT is being
> returned. So I don't think the log severity should be changed.

Yes it is an error in the sense it is a timeout, but reporting an error 
because nothing is attached to a PCI slot seems a bit noisy. Please note 
that a similar change was made by the following commit and it also seems 
appropriate here ...

commit 4b16a8227907118e011fb396022da671a52b2272
Author: Manikanta Maddireddy <mmaddireddy@nvidia.com>
Date:   Tue Jun 18 23:32:06 2019 +0530

     PCI: tegra: Change link retry log level to debug


BTW, we check for error messages in the dmesg output and this is a new 
error seen as of Linux v6.0 and so this was flagged in a test. We can 
ignore the error, but in this case it seem more appropriate to make this 
a info or debug level print.

Jon

-- 
nvpublic