Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6945327rwn; Tue, 13 Sep 2022 11:14:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR7YQvCTVykbGFPQf5ShKNF5Ndrw+w9BnJz4ujmLVwOAjp7zFlZ1UyGe2VdCuWM3Rddz7F8u X-Received: by 2002:a17:907:d02:b0:77e:b65c:41c9 with SMTP id gn2-20020a1709070d0200b0077eb65c41c9mr5978314ejc.535.1663092875597; Tue, 13 Sep 2022 11:14:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663092875; cv=none; d=google.com; s=arc-20160816; b=jG1YD+rAL/naB4gusJmoeS1iTZtQbgbusHXOytYkOeowIU0OQVN+RJ6//hZWEdGAbE Nt8pGJeSUm35USpAov7lKBGGxLyvJ+7vUTkJLTI3b6KpUg1y6aKmWYwP/SdSg9aOD3Ag 8VRSWriEb6F6DCSrwnslacJ6qOWDHJ0rIrMTBMRrGIF2Y+l2V/MiTP190GbCM/1gkVji 2NFFXDb6ITE1eqdPmbmhF4uJn032rtaFJ83x6I/dgbe2jNkjSg3+IzlW6aPKCxcKToOo yfL07CNVE/iFgXdEpXl84/TabIvt/F9n6PfRkonjtvtHUeagEN8Ch0bmCIaeK1sRIeZP Lmpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=OUm/L4lBPETC9zhbscfUHy8ra4VQ4efSGIut2mAAWEs=; b=hvSNi6GfQEvBaBCJaDNy0HUtNTTEaV7h8AU6ax7O7kYj8ObU6fnaPdyLs3jj8u6F1D +Kthd0gknerL+EKm57F59XMbvwVkqGJGbjml85tzEgcdtSIn3feLoSbcNZa4gKGQqKwe VGdPk1Qn39WjNNeg0GPSo+gm3N5SkOFCjOF3k4gW2Hp9UV1bv8HQ8QESbiuMyAbOSsLu iD+YPV0xoV2qNmVOTjqO9AD9zDMn0WEAzOghZ+FoaoLhj1ddbh/g4QM7sTI0KkYdnGHx SviB2Rg1Yixn+ldtzZxKW3KZngQRz2DrjKSdvXjdUy8ZI6WQ+B3CC7fF8/tufW3WSp+c B9Dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ToR+bgp2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm12-20020a170907948c00b0073d74bcac8dsi11088382ejc.513.2022.09.13.11.14.08; Tue, 13 Sep 2022 11:14:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ToR+bgp2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233442AbiIMRl4 (ORCPT + 99 others); Tue, 13 Sep 2022 13:41:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233362AbiIMRko (ORCPT ); Tue, 13 Sep 2022 13:40:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E37F5D4A; Tue, 13 Sep 2022 09:34:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1C18B80EF6; Tue, 13 Sep 2022 16:34:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10255C433C1; Tue, 13 Sep 2022 16:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663086866; bh=4yJETbBECttQFo+n2AKxq36MbZwpbmzoK/+wm/PtUoQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ToR+bgp2XhdybgWJOjGlIjjN1yZyXIFCXXbV1copC4mQWjRjM8IxiiR3cbldoDz0U kkdAenU37q4bjV4zvV4As44zG1hW+gGFyf2Kj1BkBYjtY6/8XCG8bu3ZfB4eTJcJ9d eQYz6AvsFyuNhyZAnzsOATFbCYbCTs1q6Rtfe73ruLnAEsNAP1cWVRvXEkuSxpFVuM K/JKclINt+4fIA9JYNZK1pSAAug+GpFM0o8hXKJsNe+74PpUGxLNxuqCNQabeH4Zx9 sadSMDhixF8O9JMNwg8QDTOYtjhEz1iduaM2T571UjSJSWJfbqUtz1/xGo2znAYCjR oNUmfjiYmeUBA== Date: Tue, 13 Sep 2022 11:34:24 -0500 From: Bjorn Helgaas To: Manivannan Sadhasivam Cc: Krishna chaitanya chundru , quic_rjendra@quicinc.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, mka@chromium.org, quic_vbadigan@quicinc.com, quic_hemantk@quicinc.com, quic_nitegupt@quicinc.com, quic_skananth@quicinc.com, quic_ramkri@quicinc.com, swboyd@chromium.org, dmitry.baryshkov@linaro.org, Bjorn Andersson , Andy Gross , Konrad Dybcio , Michael Turquette , Stephen Boyd , "open list:COMMON CLK FRAMEWORK" Subject: Re: [PATCH v6 5/5] clk: qcom: Alwaya on pcie gdsc Message-ID: <20220913163424.GA602259@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220912170437.GA36223@thinkpad> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 12, 2022 at 10:34:37PM +0530, Manivannan Sadhasivam wrote: > + Rajendra > > On Fri, Sep 09, 2022 at 02:14:44PM +0530, Krishna chaitanya chundru wrote: > > Make GDSC always on to ensure controller and its dependent clocks > > won't go down during system suspend. > > You need to mention the SoC name in subject, otherwise one cannot know for > which platform this patch applies to. Also: s/Alwaya/Always/ s/pcie/PCIe/ s/gdsc/GDSC/ as you did in commit log I might use "ALWAYS_ON" in the subject to make clear this refers to a specific flag, not a change in the code logic, e.g., clk: qcom: gcc-sc7280: Mark PCIe GDSC clock ALWAYS_ON