Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6953000rwn; Tue, 13 Sep 2022 11:21:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR7EDu7TyM9BgyTY0O/0jli+uS7qVrIt+67xVzSuHCzORnbZ4P+4Mkz0G7hEfNpNeEJn8oTI X-Received: by 2002:a05:6402:524a:b0:450:bab6:cd5f with SMTP id t10-20020a056402524a00b00450bab6cd5fmr22461395edd.233.1663093310189; Tue, 13 Sep 2022 11:21:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663093310; cv=none; d=google.com; s=arc-20160816; b=vl3rFZtous510K4zruoeKe5OYg+Ca1N3vVyWXa8nOw0TKNIs7IIqHZ/VYPvhyjVx37 HconcNf9+oFQuVDaEgfGS5h+AC1yrrgAAbioeVme13Jn5c4LUlmCIZ7thYJD1hT4ONGb c9gZOk0c7GsubfRqslMEWuP8g2mHrp/cRyJxkjepftzIJeKzxfjeNws1/wnY/oMGCxUq rJffRO+BXiDULyQmK3OFNS8mB7rQHpOJK5cmhKi25rVTqrymY71izh2ZKswm6W/O2t5Y gi8MpqLBjktRlYe1XDBHLhHvYW6b6SU+eVaOSrd1JbpUG6hMwP2lQvIMqUhp7VB0yZ3H QttQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=2onBbphacXq4LsUXqAjvL0+N2/MJz17fHHudwl0kp84=; b=SfPwPwusGDYUKK0nP0OtYZhfQ9DW9W1LnrNUbXP0uUO3OTTRCgpfs+93u9dlKelsbM h5qTsM8KMIrZ4vE5dXhn6q14XMkwGoM8LeQ6oUoK2KHP3duJijlD1WMEn7f5N1UsqBSG SzhsWDbCokPv8Gn6VFyGJ6lX4ZO42d1X2JH5K5YiMzxMB3tAyGByXY/oFGET4FkDx1/8 4OsVhcZOk+Hp0bt7HNuKzhAHZsJpXBP2/kc04uFJhDI5A2Uq1ws5NlEvEtr+bVXnE4yE bmgmbs7GkfbGxqlPqxyrQuaoYLqHzhZnda7yN1Ttql2z91RWZZ1me4THVj7/tMEZ55aZ Jbkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IGLP0E6B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b14-20020a056402278e00b00447e8ccf579si11109035ede.568.2022.09.13.11.21.24; Tue, 13 Sep 2022 11:21:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IGLP0E6B; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbiIMSLh (ORCPT + 99 others); Tue, 13 Sep 2022 14:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230483AbiIMSLH (ORCPT ); Tue, 13 Sep 2022 14:11:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 956E172FD0; Tue, 13 Sep 2022 10:17:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3155E61525; Tue, 13 Sep 2022 17:17:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66A0FC433D6; Tue, 13 Sep 2022 17:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663089475; bh=W5O5q1S7tLTEXTSypm8r+8EveveNHQIfVB/39PA8/sc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=IGLP0E6BOH/LbW3OJSyw8cj5IxqOlvnmuQakefWfzE74DStvQ8BBFHn3S0AcT/QTw 3k6qBwgLO6ip8Kk0HGVGlZZ0ZANGLxJX1kwbNBIQS/obl5gkPWcuoBezOO4kGrECPp x9WmUD/VmM1ec4T4LvNWqYzmwSmvBXnJxuYhdcXbccG/nD3MSSRuQ85jYgbfAJ4h39 Qjfl8NcqvHWuKqNqE6hT82cbeen7vbmLHrk9XCodDKmBN1E6Pnfngzs5IVYJHdoPSK gSSzaoPa0sZw/rN+CpwqmVAz/gL8EPDXOUGDvXpY+mSoE/x6NDdSfyPGRd1o691wwP C4bAAYx092Twg== Date: Tue, 13 Sep 2022 12:17:53 -0500 From: Bjorn Helgaas To: Vidya Sagar Cc: bhelgaas@google.com, lorenzo.pieralisi@arm.com, refactormyself@gmail.com, kw@linux.com, rajatja@google.com, kenny@panix.com, kai.heng.feng@canonical.com, abhsahu@nvidia.com, sagupta@nvidia.com, treding@nvidia.com, jonathanh@nvidia.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com Subject: Re: [PATCH V4 0/2] PCI/ASPM: Save/restore L1SS Capability for suspend/resume Message-ID: <20220913171753.GA609036@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913131822.16557-1-vidyas@nvidia.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 06:48:20PM +0530, Vidya Sagar wrote: > This patch series saves and restores the ASPM L1SS capability registers > during suspend/resume cycle of the system. > First patch refactors the existing L1SS register programming code to > take out the common code. > Second patch adds support to save and restore of the L1SS registers using > the common code extracted in the first patch to restore the registers. > > This patch is verified on Tegra194 and Tegra234 platforms. > > Vidya Sagar (2): > PCI/ASPM: Refactor ASPM L1SS control register programming > PCI/ASPM: Save/restore L1SS Capability for suspend/resume > > drivers/pci/pci.c | 7 +++ > drivers/pci/pci.h | 4 ++ > drivers/pci/pcie/aspm.c | 106 +++++++++++++++++++++++++++------------- > 3 files changed, 83 insertions(+), 34 deletions(-) Applied to pci/aspm for v6.1, thanks! I dropped the pci_is_pcie() testing since pci_configure_ltr() only sets dev->l1ss for PCIe devices.