Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220912224745.2716345-1-jthies@google.com> <Yx/1neGOF+0jsqvz@google.com>
In-Reply-To: <Yx/1neGOF+0jsqvz@google.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Tue, 13 Sep 2022 10:16:28 -0700
Message-ID: <CACeCKaey3XHBT7u6t9k65CYXTgZ1pUaRGDear+S8L7XjukYjXg@mail.gmail.com>
Subject: Re: [PATCH v2] platform/chrome: cros_ec: Notify the PM of wake events
 during resume
To:     Tzung-Bi Shih <tzungbi@kernel.org>
Cc:     Jameson Thies <jthies@google.com>, chrome-platform@lists.linux.dev,
        linux-kernel@vger.kernel.org, bleung@chromium.org,
        groeck@chromium.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 12, 2022 at 8:14 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Mon, Sep 12, 2022 at 10:47:45PM +0000, Jameson Thies wrote:
> > Update cros_ec_report_events_during_suspend to notify the PM of wake
> > events during resume by calling pm_wakeup_event.
>
> Could you add some more details about "why"?
>
> > Signed-off-by: Jameson Thies <jthies@google.com>
> > Reviewed-by: Prashant Malani <pmalani@chromium.org>
>
> I didn't see where the R-b tag comes from which has been attached since
> v1.

I asked Jameson to do so, after having reviewed the patch off list.

> You shouldn't attach the tag even if the patch may have been
> reviewed somewhere but not in the mailing list.

That is not a requirement (at least, it is not stated anywhere in
kernel documentation).
There are plenty of examples of patches being uploaded after being
reviewed. Here
is just 1 recent example [1] but I'm sure you can find plenty more.

[1] https://lore.kernel.org/linux-usb/20220913055316.23050-2-shruthi.sanil@intel.com/