Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp6976370rwn; Tue, 13 Sep 2022 11:45:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4hmqB+JM1eHfw5fiRg4RDz6upb81gHK5yfr+9fzGDN5+9Qmtp09VWsv6oFKxXOLFjDzH55 X-Received: by 2002:a17:90b:16d3:b0:202:9e20:704b with SMTP id iy19-20020a17090b16d300b002029e20704bmr608080pjb.141.1663094759546; Tue, 13 Sep 2022 11:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663094759; cv=none; d=google.com; s=arc-20160816; b=nuXUCrTwLeaYUzbkBdqjbge1nuvdUgLCyZsPuUuRxcpn4b66mknOqm3aRfzQa2pfeI +BkLF8op+ZojyIU83w6/hNk8KL1vY+FMRzFVdXdqYBlT1TMwyBHUcuHs0kBGf3Q5yXRr YgjbybN+PhvgxgpGmxxGxkroVbeA6CmGKPksR9Mn7fcSJwmmToHVhB7Jqc8CVoZgT7kF pp4RdJ4XJTFiiA1LV2wxe5GnO09sHpnSMD4X2YPpQl1iwssi3wAAQcHZtk1cuT4n1Ott ZJLCms9g7S8H9sztSXL2fi+HhjnxS4B/G/H6rx97v6M5zUbUT7SObfOMJuIUpUR0/UDC 82xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DRrSt1g1MwWWIcrp8RvrIGoWocVBN6Pz07Q5HTcSUe4=; b=YpD7ooyH+G4mUGd7uor/AcT0mY8V7JmXWwukqcI1SQowG+SKoKh38qrPgjROvq88wW 7Mqu6yPqaxTXwVEzpj6WD1zlgiWvl0yDWsDowPja9CdJTCwIclGM6z04ozL6XIvN3uMw oUlTLrafzlaNbBnuHf77ykplDLo0sf7AXr21HzqmU4CBTmRIzTucHyExIx/LL3Nyl1sf bzYD8cmBm3FG82Q4fWZQ4YkzH2bznu47j0Noqs6UOo7dPhlo1X7rb4PgRRVw5Nyb0Gmg 4SiERo9163VERhupNX6ph+oNkbsO8lXQittFbADVW3n3Xao4T6tckJKLjO52aJ27Pajw lx0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OgNrTzva; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020a170902cecf00b00177f3349f28si5875367plg.264.2022.09.13.11.45.48; Tue, 13 Sep 2022 11:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=OgNrTzva; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbiIMSLd (ORCPT + 99 others); Tue, 13 Sep 2022 14:11:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230095AbiIMSLF (ORCPT ); Tue, 13 Sep 2022 14:11:05 -0400 Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0E74642D3 for ; Tue, 13 Sep 2022 10:17:49 -0700 (PDT) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-1278624b7c4so33985437fac.5 for ; Tue, 13 Sep 2022 10:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=DRrSt1g1MwWWIcrp8RvrIGoWocVBN6Pz07Q5HTcSUe4=; b=OgNrTzvafqsbqCKy9d8AO957d5rSQDMlcymT2RJaj627dRsLVvZwbojoy3oDjPb2LY 9kYbZN+9OotFDdln4t7sWUr30bJjf/A+X5uQT5MEgD/otHEy57ZBdTEDrlfsa2l85MtE /XtetIM2X/Odqh1MZkDS5gfQCk2qjrZW3aAmk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=DRrSt1g1MwWWIcrp8RvrIGoWocVBN6Pz07Q5HTcSUe4=; b=FUtXthJBtuQ7d3CxiTEvSnMBdzWyGa6FVuGR2/QDSumxwNyRLwu8z4MSjP07Smb5P0 0+q5I5cpQrbFpyy8vCzVBYOe1kqGf9Fjfk8PmXrvwIVwv0hIl3mkDzfkLcTMruf7iCJc cw1cPjcgRrcbG7e6lunIgv4CMKLRq1WQIa5jl1esdXmNgrxA+X8/EnvAEh0NZYNmV2Mv neP12913UuU90Tz9uokNYoN8eJemOaLW23GoOwmN427D2XF5oKo2Q7T/yGhMJKX16Q+G R/+bzKLA0jLnoC1RcAXQvH+rROeX/Uhnix2cVZGlQHtg3v3Mwj9tOsRU3NjLcjqa5LTw rSiA== X-Gm-Message-State: ACgBeo38RwGbHEBlfswUx7FcFjxG2VR07fSfdmepGfekvz8+zaNJdcSP X9HJy/qaoRLZGHS4kZfyLrCJU55l30w6clvJgGUlYQ== X-Received: by 2002:a05:6808:3021:b0:335:182f:a66a with SMTP id ay33-20020a056808302100b00335182fa66amr137569oib.295.1663089469116; Tue, 13 Sep 2022 10:17:49 -0700 (PDT) MIME-Version: 1.0 References: <20220913145549.2839948-1-jthies@google.com> In-Reply-To: <20220913145549.2839948-1-jthies@google.com> From: Prashant Malani Date: Tue, 13 Sep 2022 10:17:37 -0700 Message-ID: Subject: Re: [PATCH v3] platform/chrome: cros_ec: Notify the PM of wake events during resume To: Jameson Thies Cc: chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, bleung@chromium.org, groeck@chromium.org, tzungbi@kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HI Jameson, On Tue, Sep 13, 2022 at 7:55 AM Jameson Thies wrote: > > cros_ec_handle_event in the cros_ec driver can notify the PM of wake > events. When a device is suspended, cros_ec_handle_event will not check > MKBP events. Instead, received MKBP events are checked during resume by > cros_ec_report_events_during_suspend. But > cros_ec_report_events_during_suspend cannot notify the PM if received > events are wake events, causing wake events to not be reported if > received while the device is suspended. > > Update cros_ec_report_events_during_suspend to notify the PM of wake > events during resume by calling pm_wakeup_event. > > Signed-off-by: Jameson Thies Although I've already provided the tag, here it is again: Reviewed-by: Prashant Malani