Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7006862rwn; Tue, 13 Sep 2022 12:14:37 -0700 (PDT) X-Google-Smtp-Source: AA6agR7oK8kgCPv6GJSUT+WKMxVVYrZvYxozqyowyBpfxf79/lClP30w4c4QT9VxbwhOXP0O8Qh4 X-Received: by 2002:a05:6402:5243:b0:451:6d52:5928 with SMTP id t3-20020a056402524300b004516d525928mr13002318edd.328.1663096477697; Tue, 13 Sep 2022 12:14:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663096477; cv=none; d=google.com; s=arc-20160816; b=BbixBWnFKCRzRff7rTv6fPzqzXJhyiQqTk5sFrOaROD2puiy2b+ARNklVR9xMA5VyY Z3Yn339pucBqT0vtp0inhcycndeW36aq1RiLnBV2I/0Ozs2nBV+Ny8X9+ku3lvbXSZ1V Gg6Awzyx5eVrvL0ux3DNQrta25U88mlOMiPtcm2k9dOQ6eYVA/H96y05KXgsAltdey4B zUbg6hHa+PCIaEaxRco0xJ6Q7BjWW8TkPbs78ts4OMWGlL7ciaChLbezo5ld/Nbs1cFF sHHzwVEbU31K/MRxAbrotcWVuwjz9ge03PAmB9ztLFx98YG2ahsoZkkNir37b822XVLY OPDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RK8HL1F3M1TdUKlkjzvVy3Mv1UGK5lskuBgs4dh2sRI=; b=fslRJfH7ySp2u6fMH0m5XNwVBSiYjx1h3PLvupzvXXGGCZzYvhKh3mlTHSa9g27IwL 7KsE+QsE9XLd/eX81XtpgFzWM1bMWi/o31vc0sp2RAibpNprY7/6rbzI71Q5ja0/xgdz nHJQgViX7zrLkjP0GzOZ+IqtOnsZjwNMSCJJ2e+cQq+Ov1D6j11MSEhcrNtmKFkPe4Sc xEm1060VHZIG5Q6kNIcPXHd1x4DhueifGQe/les1s9OQkaw1CFkD67C4ctZNljfQ32/0 LIlnWbd6HHf6urmx8yvO22B1RRWpU4/+//r/xpFued2AlNmwttI6py5sQFZX7q2UGmfE lESQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=0kyX9qxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa33-20020a17090786a100b007707c682264si223484ejc.298.2022.09.13.12.14.11; Tue, 13 Sep 2022 12:14:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=0kyX9qxP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233145AbiIMTDO (ORCPT + 99 others); Tue, 13 Sep 2022 15:03:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232481AbiIMTCm (ORCPT ); Tue, 13 Sep 2022 15:02:42 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A062384; Tue, 13 Sep 2022 12:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RK8HL1F3M1TdUKlkjzvVy3Mv1UGK5lskuBgs4dh2sRI=; b=0kyX9qxPF6heEV9PGyQXRhz4zt jwinzSE2M7041xLdAS2rgVJw+mXQcalx+8X+vy2yNXMP6rRZxotRtycGoEHhC6Ba68FGMoQUt6qZC 0u8SOQuuq0OfoTNYyUm7zVaWihqfS4Mvwd8x5nywwqa7q6f9QRQesOwW8opQX+ZMfBcOjcLjgHRuh kBc3kbad56Ghn0c6fDUU7If1d9UkgFWuQC8acDoRBDJwi4LyjgOVyyBzhOY6yvGKRX48otdLgiHAi p2DZK+w+B1/dOH1QzDgo6GPuqzUSTlAYbhbGfbV0RWi61ehoV03wageHLD5Gs+Z4/NGCgf4RdpfB9 b4E64dHA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34304) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oYBAK-0003QE-5E; Tue, 13 Sep 2022 20:01:48 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oYBAJ-0000uI-Dm; Tue, 13 Sep 2022 20:01:47 +0100 Date: Tue, 13 Sep 2022 20:01:47 +0100 From: "Russell King (Oracle)" To: Oleksandr Mazur Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, pabeni@redhat.com, kuba@kernel.org, edumazet@google.com, davem@davemloft.net, hkallweit1@gmail.com, andrew@lunn.ch Subject: Re: [PATCH 2/2] net: sfp: add quirk for FINISAR FTLF8536P4BCL SFP module Message-ID: References: <20220913181009.13693-1-oleksandr.mazur@plvision.eu> <20220913181009.13693-3-oleksandr.mazur@plvision.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913181009.13693-3-oleksandr.mazur@plvision.eu> Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 09:10:09PM +0300, Oleksandr Mazur wrote: > The FINISAR FTLF8536P4BCL reports 25G & 100GBd SR in it's EEPROM, > but supports only 1000base-X and 10000base-SR modes. > > Add quirk to clear unsupported modes, and set only the ones that > module actually supports: 1000base-X and 10000base-SR. This description does not match what the patch is doing. I see no modes being cleared. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!