Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 15:13:25 -0500
From:   Bjorn Andersson <andersson@kernel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc:     Johan Hovold <johan@kernel.org>, konrad.dybcio@somainline.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        johan+linaro@kernel.org, steev@kali.org
Subject: Re: [PATCH] arm64: dts: qcom: thinkpad-x13s: Update firmware location
Message-ID: <20220913201325.ip66pzu7owm4t33h@builder.lan>
References: <20220913054030.3234-1-manivannan.sadhasivam@linaro.org>
 <YyBWZOMz3mKlje05@hovoldconsulting.com>
 <20220913105734.GD25849@workstation>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220913105734.GD25849@workstation>
Precedence: bulk

On Tue, Sep 13, 2022 at 04:27:34PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Sep 13, 2022 at 12:07:32PM +0200, Johan Hovold wrote:
> > [ Resend with Bjorn's address updated as the Linaro one now bounces. ]
> > 
> > On Tue, Sep 13, 2022 at 11:10:30AM +0530, Manivannan Sadhasivam wrote:
> > > The firmware location in linux-firmware has been changed to include the
> > > SoC name. So use the updated location in Thinkpad devicetree.
> > > 
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > ---
> > >  arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > I guess we should pick a commit prefix that we stick to for changes to
> > this driver.
> > 
> > 	arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s:
> > 
> > is arguably unnecessarily long even if it follows the pattern of some
> > other qcom dts.
> > 
> > Shall we just use
> > 
> > 	arm64: dts: qcom: sc8280xp-x13s:
> 
> This looks looks better. I did look into the earlier commits but I found
> the prefix to be too long, so went with the last commit prefix.
> 

+1

> > 
> > which matches sc8280xp-crd? Or stick "lenovo" in there as well? Or just
> > keep the whole thing unchanged?
> > 
> > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > index c379650e52b1..3b7943d6e164 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> > > @@ -554,13 +554,13 @@ keyboard@68 {
> > >  };
> > >  
> > >  &remoteproc_adsp {
> > > -	firmware-name = "qcom/LENOVO/21BX/qcadsp8280.mbn";
> > > +	firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
> > >  
> > >  	status = "okay";
> > >  };
> > >  
> > >  &remoteproc_nsp0 {
> > > -	firmware-name = "qcom/LENOVO/21BX/qccdsp8280.mbn";
> > > +	firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
> > >  
> > >  	status = "okay";
> > >  };
> > 
> > Change itself looks good otherwise:
> > 
> > Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
> > 
> 
> Thanks! I will respin with the agreed prefix.
> 
> Regards,
> Mani
> 
> > Johan