Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aedb7677-528a-75b7-6517-ab1865515ad4@amd.com>
Date:   Tue, 13 Sep 2022 18:32:04 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.1
Subject: Re: [PATCH v2 13/23] KVM: x86: Disable APIC logical map if vCPUs are
 aliased in logical mode
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Maxim Levitsky <mlevitsk@redhat.com>,
        Li RongQing <lirongqing@baidu.com>
References: <20220903002254.2411750-1-seanjc@google.com>
 <20220903002254.2411750-14-seanjc@google.com>
From:   "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <20220903002254.2411750-14-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmN6V1lKQndhbkhOaGsxMjF0WWIzU1RRQmJpM0hrckh6djY5N01OWXA1MFZa?=
 =?utf-8?B?d0FqeUJQZVJac1JsN0IrRlVmVTFuY25ySm0ycUs5VGFLQ09TSUVUVWlHbnJP?=
 =?utf-8?B?Ty9XTHNpTkRHUmNmZE9qV3dkNC91dVN2OXA5cUpzNXkrWjhTNFhjUzFzbHc5?=
 =?utf-8?B?SFV2cklDQjI1Z1VEOEZsd0NtTzIzR2l3eWlBRi8wL2ZtVUZCVkNJd1FBVDEx?=
 =?utf-8?B?Q2l6Vk5ZcGVXVmJWbFU3T0RlNnFMNHNiUFZ4aThVSTBqOHZNRXh4M0hOSE1L?=
 =?utf-8?B?aDF0MWpESEdLTlpFK0M1Q2lEZmdKRXJUVjhiS3RYYlB1NUNrYlhVLzVVc3RD?=
 =?utf-8?B?Wm53aFlPd3JtY3ptaExFVVZuVkNYT1F4SEY4WEVVMWFZMUlpem5KZ3RmK2lw?=
 =?utf-8?B?WENUSmNFV0s3M2N2a2JuUmN5SDVYTWtoaDRGNmRTTWoyTzdoVUhtSkl1c3Vt?=
 =?utf-8?B?Y3BDbWZXaDRmM2QvSmx3RjdkTVVKUVJKeVcxcFk1MXlkYUNqZG00MGRaZFpr?=
 =?utf-8?B?c1Q0UGgrVXc1WG9mVm0yTHEzSEhKSElyWVlkWWZGRytvd3ZGd3JHUUo1cG82?=
 =?utf-8?B?MlhNQ3k4c3R3TWtxWTJRWW5ZVkxTZHpoWXlDeEw0a1Y1amNhRHZKdkxxbXZ1?=
 =?utf-8?B?cHB4NlUvRjFwVkpzc0R3SUxvWURBMXY3RjVpMGltMDVGdm9mdENqbUZyOVhQ?=
 =?utf-8?B?QXR3QnROOVpUM1BVK0oyUkZBZlUrMXNJWXNWbDk0ejFRZ2RZSWRIOTZXZk0v?=
 =?utf-8?B?Vy9DM2w1QjhhOU9xYmJJRy9EQm53M3Zua1JocW95T1ZYb2JkV003RWVvSXZI?=
 =?utf-8?B?U2kyeStDcW1LMzUzQklHMkdXMGlCTmdSY2JxYjVLbm9ibHFqWG9zbVVEYjZX?=
 =?utf-8?B?WUdOeStKSlhnSldUZDNHd2d6OWZPbnZZazRCc240a0JsWVNKRUUzY3ZsdEpO?=
 =?utf-8?B?UGVXSyt4OVlpMWVZZHhjQlNJM2pMRDhKVU5FMVpGSmxkWVowV3lORWFROVJ2?=
 =?utf-8?B?RGNsUVZJY2k2a3ZOVEdWY2ZMWXJkeGN2UVZnR04zSnhYaHAwb2ZQaC8vRkx5?=
 =?utf-8?B?RStha250eDh5K3M2N0xzOXFzTmV2R0VpK0ZQNmJzcUFyaHhwaUhESlZjMkE3?=
 =?utf-8?B?ZDBpREl5cVdQdjIxWVN0NEcybU1aTXh5UnY4akF2eDI5eGVWU2RPOHFUV29L?=
 =?utf-8?B?c3oxUk9KR1ZDK1N4VjUrRXRHVkxoMmF5djhmUmtRbWNiOWdyNVFjOUtoZjNI?=
 =?utf-8?B?WWRxOHVLREdQRnMvenJEb2hFZlQ5K0c4VkFxMFlScmJ1eVJQQkFLSSs4ZnRs?=
 =?utf-8?B?NjVpeHRndUJlNm1hNmJJWUxrTlZSckJ0ejdkRWRhTDVZOWgvbFdGTnJrdnBB?=
 =?utf-8?B?Nlo1K01UZGZMdmhwZjRXUmNJc1c2SVlHOEc5TUdTczZTOWFMZ1BXVklCYWVG?=
 =?utf-8?B?TlVJVGxmeXdFNStiU3U1R2N5NU1HTU9xMkN5RFp4N0V0c0JhZVhtNUVSWEQ0?=
 =?utf-8?B?dVVBcjRteVB5Tk1TcW0wN2dLbGowRkR6NnczZEJobWMyUDN6UU0wMW1DYWlO?=
 =?utf-8?B?NGFNRWFkR3lTZmdoQVU4QmNyOVRWYVhoMGZTczcvcEZTSlJZUDc4eFZpdW92?=
 =?utf-8?B?MkhSOXUwYmFJeVlIZzYraXI3TWcxcnBWaldMTzBTVms3K0hnQmFUV2c1Mk5H?=
 =?utf-8?B?VXpFT3hRSWVNckdGRXNtd0hTc2hoaXE4TEFKVmI5THN4alQ0bW9SclVzVXZT?=
 =?utf-8?B?aUhXVHhmUmYxYmpmMGFDU0VsUCtJdmpuSTRTK1luOXlGWVR5R0VCSnQzZ1Zv?=
 =?utf-8?B?ek9hZE5HUnhWdVovU0cvbFd1MGdkbTQxZlhYcnY1c1JRbGRIUzc4YTk0UUkr?=
 =?utf-8?B?clczbjhFYUN5SE1uM1E5L2VoRXhCd1NzM2U0YzZxcFpYaXl1Q0kzTDhOWmZ3?=
 =?utf-8?B?WVlwaWRucnlSUGJUdStta0pkUEoySW52YlF5SjUrVjUyK1ZoQVRLc01QTnhP?=
 =?utf-8?B?Y0FmMDFYd2p5ZWxrMjRFVy8yeUdsMXdIdEZydnhxRTEzS1pmY2VaVnFhVHVi?=
 =?utf-8?B?THNTUVhQVHAwT1JyWXFhYk1oVDN1WmJUOVZRZTg3eHJGZ1dtS21xUWluRjRm?=
 =?utf-8?Q?7PejfRKj7zlHoyJRpUYc1WrE4?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48128192-02d1-4bba-dd48-08da95e02b9b
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 23:32:06.4757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9g9WpNy7CVOvMuNoHAOTK8OfWGu+5D3UeaU5SjwLT4kLs/fI6AaqZijOF0iMZZhv/9IMxvAgaj00tenLxGWngg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6821
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sean

On 9/2/2022 7:22 PM, Sean Christopherson wrote:
> Disable the optimized APIC logical map if multiple vCPUs are aliased to
> the same logical ID.  Architecturally, all CPUs whose logical ID matches
> the MDA are supposed to receive the interrupt; overwriting existing map
> entries can result in missed IPIs.
> 
> Fixes: 1e08ec4a130e ("KVM: optimize apic interrupt delivery")
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
> ---
>   arch/x86/kvm/lapic.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 6b2f538b8fd0..75748c380ceb 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -303,12 +303,13 @@ void kvm_recalculate_apic_map(struct kvm *kvm)
>   		if (!mask)
>   			continue;
>   
> -		if (!is_power_of_2(mask)) {
> +		ldr = ffs(mask) - 1;
> +		if (!is_power_of_2(mask) || cluster[ldr]) {

Should this be checking if the cluster[ldr] is pointing to the same 
struct apic instead? For example:

		if (!is_power_of_2(mask) || cluster[ldr] != apic)

 From my observation, the kvm_recalculate_apic_map() can be called many 
times, and the cluster[ldr] could have already been assigned from the 
previous invocation. So, as long as it is the same, it should be okay.

Best Regards,
Suravee

>   			new->mode = KVM_APIC_MODE_XAPIC_FLAT |
>   				    KVM_APIC_MODE_XAPIC_CLUSTER;
>   			continue;
>   		}
> -		cluster[ffs(mask) - 1] = apic;
> +		cluster[ldr] = apic;
>   	}
>   out:
>   	old = rcu_dereference_protected(kvm->arch.apic_map,