Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7336946rwn; Tue, 13 Sep 2022 18:54:43 -0700 (PDT) X-Google-Smtp-Source: AA6agR4lphLXDficdZSp0Fzg3cUMndDBTLr0MiTzAe+djhT1MUbLzBdZrg9RASiuXVFdSXnutYbv X-Received: by 2002:a17:907:7f88:b0:77f:c4c7:9176 with SMTP id qk8-20020a1709077f8800b0077fc4c79176mr5229244ejc.238.1663120482835; Tue, 13 Sep 2022 18:54:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663120482; cv=none; d=google.com; s=arc-20160816; b=QMvWrdu9AoBJSR4RuTSvryIWMpc5DAHvfoael5aQakY+DvUgGrRftO1hAGuBxKbCyH kLx67e7XyVjm/Cz0u8sqPuF9LL76r5SDCYxh6BGqwENAfhY5R2qJmoVgtobBkxsFrcL4 yHoEO4PP/bBXDt943lWD/5f+4pnmUmzjsGm0imW0PwZqP8/YVkPeRZHpM6VIHvjB3Vl2 09QqaSBRglONwSVsQUSuTqFNLZoP3704NTH+sPQqfVibESICS51QkZbIoTsxaBmw2C+8 X9E43y1IrR1a9/VJ+NwNnjmZip4DBxYorR+jcy3DLdZZrwh7TUCQtTbYujL1ZhAvp3Lu RCzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=s+NpRRd30KZbhoU8Kq+ChKPrJ+iu3zBasORTuwmzU6Y=; b=eUu1AdJCzlhRrAYS7NTlBwXDtTUFWH8goWwMtq+Fc+d7b4jnp+ZApnYpinIDzRODkU A93IrAYW5xhrCZBSZzCyKijp9ZyodB0BTnP+EApqRJ/RR8GilDqETXhr/NQaBghWL0IQ ZrOAmIjJzBYqJT4W1pFGf/XYxg2ShTXLzvq95TkDg1rQxLSBRlj2+afTfcQ9HRGrrohU oBYIxEyGN8Ur7CgQF9cG4eOWuL5yvRZhVZksKPJdEBNV0EOFuhgwhXTeshkBdehWC8rQ AIqd9lZqfclX7QvwMwfmhySTJeKtnuDFM1AZ4/4gUBgTsBvp9lWEXnX7QIDN8s3VkPIH tjIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f18-20020a056402355200b00447e24d55eesi12570197edd.81.2022.09.13.18.54.13; Tue, 13 Sep 2022 18:54:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229738AbiINBV4 (ORCPT + 99 others); Tue, 13 Sep 2022 21:21:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiINBVz (ORCPT ); Tue, 13 Sep 2022 21:21:55 -0400 Received: from mail.nfschina.com (mail.nfschina.com [124.16.136.209]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BC9F165569 for ; Tue, 13 Sep 2022 18:21:53 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id 8CD771E80D5E; Wed, 14 Sep 2022 09:19:34 +0800 (CST) X-Virus-Scanned: amavisd-new at test.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (mail.nfschina.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ifbq9yNsUG8n; Wed, 14 Sep 2022 09:19:32 +0800 (CST) Received: from localhost.localdomain.localdomain (unknown [219.141.250.2]) (Authenticated sender: xupengfei@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id B06711E80D58; Wed, 14 Sep 2022 09:19:31 +0800 (CST) From: XU pengfei To: mike.kravetz@oracle.com, songmuchun@bytedance.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, XU pengfei Subject: [PATCH 1/1] mm/hugetlb: Remove unnecessary 'NULL' values from Pointer Date: Wed, 14 Sep 2022 09:21:14 +0800 Message-Id: <20220914012113.6271-1-xupengfei@nfschina.com> X-Mailer: git-send-email 2.18.2 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pointer variables allocate memory first, and then judge. There is no need to initialize the assignment. Signed-off-by: XU pengfei --- mm/hugetlb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index e070b8593b37..a05f22b1ab1e 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -257,7 +257,7 @@ static inline struct hugepage_subpool *subpool_vma(struct vm_area_struct *vma) static struct file_region * get_file_region_entry_from_cache(struct resv_map *resv, long from, long to) { - struct file_region *nrg = NULL; + struct file_region *nrg; VM_BUG_ON(resv->region_cache_count <= 0); @@ -339,7 +339,7 @@ static bool has_same_uncharge_info(struct file_region *rg, static void coalesce_file_region(struct resv_map *resv, struct file_region *rg) { - struct file_region *nrg = NULL, *prg = NULL; + struct file_region *nrg, *prg; prg = list_prev_entry(rg, link); if (&prg->link != &resv->regions && prg->to == rg->from && -- 2.18.2