Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Sep 2022 20:47:01 -0500
From:   Rob Herring <robh@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Manivannan Sadhasivam <mani@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH] dt-bindings: pci: qcom,pcie-ep: correct qcom,perst-regs
Message-ID: <20220914014701.GA853152-robh@kernel.org>
References: <20220911135547.23106-1-krzysztof.kozlowski@linaro.org>
 <11e61fa5-f770-9c9f-23b9-3d1dcb205bc5@linaro.org>
 <20220913152054.GA3736444-robh@kernel.org>
 <d22ed818-1a8d-4af8-d41d-2268806f3dea@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d22ed818-1a8d-4af8-d41d-2268806f3dea@linaro.org>
Precedence: bulk

On Tue, Sep 13, 2022 at 06:25:49PM +0200, Krzysztof Kozlowski wrote:
> On 13/09/2022 17:20, Rob Herring wrote:
> > On Sun, Sep 11, 2022 at 04:14:54PM +0200, Krzysztof Kozlowski wrote:
> >> On 11/09/2022 15:55, Krzysztof Kozlowski wrote:
> >>> qcom,perst-regs is an phandle array of one item with a phandle and its
> >>> arguments.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >>>  Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 6 ++++--
> >>>  1 file changed, 4 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> >>> index 3d23599e5e91..077e002b07d3 100644
> >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> >>> @@ -60,8 +60,10 @@ properties:
> >>>                   enable registers
> >>>      $ref: "/schemas/types.yaml#/definitions/phandle-array"
> >>>      items:
> >>> -      minItems: 3
> >>> -      maxItems: 3
> >>> +      - items:
> >>> +          - description: Syscon to TCSR system registers
> >>> +          - description: Perst enable offset
> >>> +          - description: Perst separateion enable offset
> >>
> >> Unfortunately this still complains:
> >>
> >> qcom-sdx55-t55.dtb: pcie-ep@40000000: qcom,perst-regs:0: [28] is too short
> >>
> >>
> >> where 28 is the phandle...
> > 
> > Meaning the dt is wrong or there's a tooling issue?
> 
> I think tooling issue. I looked at this many times and code (schema and
> DTS) seems to be correct, but tool doesn't like it.

Okay, I found the issue. Will test it a bit more and apply it tomorrow.

Rob