Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7408142rwn; Tue, 13 Sep 2022 20:37:08 -0700 (PDT) X-Google-Smtp-Source: AA6agR6hSE7v45zyr22HL76yhT/KXl9SWgG32/4P7JbMjnsO5LMdG1f3YpPBXE6D0vulmns5NnTk X-Received: by 2002:a17:906:7945:b0:73b:e605:f31 with SMTP id l5-20020a170906794500b0073be6050f31mr24328888ejo.129.1663126628213; Tue, 13 Sep 2022 20:37:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663126628; cv=none; d=google.com; s=arc-20160816; b=GVr18sYJpXogvwhA3jnxAd+Xwte2j9NH0NXa7hQrir9p02Rf6kwTfKigvU+CFNaIU4 crte3NOFvb1BZ6nQ+jGO9jcKVwWWJoz0UySKAaHC0h1SBJJVQEOfV9hORJbja0gk/b5j syfsLcafzTHm5fkdc6LHTGLPOgH7WcD4aOO5++MTcAYe+CxwMcq6U/TEEBMA6BePX50n L9c1AElLOUDhM6mdfUN5ANCyPQmGGa0i28lxqODSimc4F0nnOY2Ahui/VCaL6OnzQ0Dr w/rvq/bd3doGuRRHc5s1TioNULKVQdgpzv2NWD5UVMKI3Im8xrze9vIzfo+T+QKHUe1N Aplg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=aK8XrDdH4aT9lKFOTPjmxF+X9nNvd7VDRoazl66hZpc=; b=iH0bZ0RenidE6NCutD6TxL/E0ofQTUKYvoTNDlW8st6SklSpIpLymUVNTHNgXyZqPN o6Smwlkxy0yAbXRHA6jwQitL6Oi4f8khbRh6vsWE8+tXu56Yf6Wqmi6gx3xCpDmN9mjS Gs0hU722R7DN1IbKZ9dTF9aEu5hkIqHJuP3010eqamaFIGqnPcS8XrOPwwimRBXKFmUI 8MvfIC16SAIBAt/IqqRjDP6eCUdUryCdG/x0AGTDVs2bsS9g7uFHE333Ut5ICk417Xmx S5TXNKrvM241dS4kddwFiMPWxUKUFSpYu5jn6g+DcUJFaZA84Q+uJjtWpr96fyi+4NX4 8NAw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw15-20020a170906478f00b0073ddf3ccee9si2461606ejc.308.2022.09.13.20.36.42; Tue, 13 Sep 2022 20:37:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbiIND2S (ORCPT + 99 others); Tue, 13 Sep 2022 23:28:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiIND2P (ORCPT ); Tue, 13 Sep 2022 23:28:15 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA9132496F for ; Tue, 13 Sep 2022 20:28:14 -0700 (PDT) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MS5KW4GbhzlVkv; Wed, 14 Sep 2022 11:24:15 +0800 (CST) Received: from dggpeml500010.china.huawei.com (7.185.36.155) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 11:28:11 +0800 Received: from huawei.com (10.67.175.33) by dggpeml500010.china.huawei.com (7.185.36.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 14 Sep 2022 11:28:11 +0800 From: Lin Yujun To: , , , , CC: , Subject: [PATCH -next] pxa: Release platform device in case of platform_device_add() fails. Date: Wed, 14 Sep 2022 11:24:37 +0800 Message-ID: <20220914032437.95609-1-linyujun809@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.175.33] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500010.china.huawei.com (7.185.36.155) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform device is not released when platform_device_add() fails. Use platform_device_put() to release these resource. Fixes: 49cbe78637eb ("[ARM] pxa: add base support for Marvell's PXA168 processor line") Signed-off-by: Lin Yujun --- arch/arm/mach-mmp/devices.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-mmp/devices.c b/arch/arm/mach-mmp/devices.c index 79f4a2aa5475..e918f419bc4c 100644 --- a/arch/arm/mach-mmp/devices.c +++ b/arch/arm/mach-mmp/devices.c @@ -53,20 +53,23 @@ int __init mmp_register_device(struct mmp_device_desc *desc, } ret = platform_device_add_resources(pdev, res, nres); - if (ret) { - platform_device_put(pdev); - return ret; - } + if (ret) + goto err_put_pdev; if (data && size) { ret = platform_device_add_data(pdev, data, size); - if (ret) { - platform_device_put(pdev); - return ret; - } + if (ret) + goto err_put_pdev; } - return platform_device_add(pdev); + ret = platform_device_add(pdev); + if (ret) + goto err_put_pdev; + return ret; + +err_put_pdev: + platform_device_put(pdev); + return ret; } #if IS_ENABLED(CONFIG_USB) || IS_ENABLED(CONFIG_USB_GADGET) -- 2.17.1