Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752860AbXFSNr5 (ORCPT ); Tue, 19 Jun 2007 09:47:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751026AbXFSNru (ORCPT ); Tue, 19 Jun 2007 09:47:50 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:33713 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbXFSNrt (ORCPT ); Tue, 19 Jun 2007 09:47:49 -0400 Subject: Re: [patch 2/2] kprobes x86_64 quick fix mark-ro-data From: Arjan van de Ven To: Mathieu Desnoyers Cc: prasanna@in.ibm.com, Andi Kleen , Andrew Morton , Chuck Ebbert , linux-kernel@vger.kernel.org, ananth@in.ibm.com In-Reply-To: <20070619133020.GA22368@Krystal> References: <20070615202310.178466032@polymtl.ca> <4676D2A9.6090403@redhat.com> <20070618115632.7aca8c0f.akpm@linux-foundation.org> <200706182132.56559.ak@suse.de> <20070619100644.GA5478@in.ibm.com> <20070619100810.GA301@in.ibm.com> <1182259288.3014.7.camel@laptopd505.fenrus.org> <20070619133020.GA22368@Krystal> Content-Type: text/plain Organization: Intel International BV Date: Tue, 19 Jun 2007 06:44:30 -0700 Message-Id: <1182260670.3014.10.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 (2.10.2-2.fc7) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 45 On Tue, 2007-06-19 at 09:30 -0400, Mathieu Desnoyers wrote: > * Arjan van de Ven (arjan@infradead.org) wrote: > > On Tue, 2007-06-19 at 15:38 +0530, S. P. Prasanna wrote: > > > This patch is a quick fix for x86_64 to enable kprobes only if DEBUG_RODATA is > > > not configured. Since DEBUG_RODATA markes the kernel text pages as read-only. > > > > > > it does?? > > > > I don't seem to be able to find this in the source code..... > > > See arch/x86_64/mm/init.c:mark_rodata_ro(). eh woops PATCH] x86: tighten kernel image page access rights author Jan Beulich Wed, 2 May 2007 17:27:10 +0000 (19:27 +0200) committer Andi Kleen Wed, 2 May 2007 17:27:10 +0000 (19:27 +0200) commit 6fb14755a676282a4e6caa05a08c92db8e45cfff changed it to include text (even though Andi vetoed that before when I asked for it on grounds of breaking kprobes)... sounds this really wants to be a 2nd config option to seperatedly do code and data. -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/