Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <621867a7-e513-c0c8-fb4f-2116d3aa8c7c@gmail.com>
Date:   Wed, 14 Sep 2022 11:10:12 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH 2/2] USB: serial: option: add support for docomo L-03F
Content-Language: en-US
To:     Chris Packham <chris.packham@alliedtelesis.co.nz>,
        johan@kernel.org, gregkh@linuxfoundation.org
Cc:     hyamamo@allied-telesis.co.jp, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220914025541.1018233-1-chris.packham@alliedtelesis.co.nz>
 <20220914025541.1018233-3-chris.packham@alliedtelesis.co.nz>
From:   Lars Melin <larsm17@gmail.com>
In-Reply-To: <20220914025541.1018233-3-chris.packham@alliedtelesis.co.nz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/14/2022 09:55, Chris Packham wrote:
> Add support for the docomo L-03F modem.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
>   drivers/usb/serial/option.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 2065f0fb2fa0..14eaff50820b 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -527,6 +527,7 @@ static void option_instat_callback(struct urb *urb);
>   /* LG products */
>   #define LG_VENDOR_ID				0x1004
>   #define LG_PRODUCT_L02C				0x618f
> +#define LG_PRODUCT_L03F				0x6366
>   
>   /* MediaTek products */
>   #define MEDIATEK_VENDOR_ID			0x0e8d
> @@ -2079,6 +2080,7 @@ static const struct usb_device_id option_ids[] = {
>   	{ USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID, VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(ZD_VENDOR_ID, ZD_PRODUCT_7000, 0xff, 0xff, 0xff) },
>   	{ USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L02C) }, /* docomo L-02C modem */
> +	{ USB_DEVICE(LG_VENDOR_ID, LG_PRODUCT_L03F) }, /* docomo L-03F modem */
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x00, 0x00) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a1, 0xff, 0x02, 0x01) },
>   	{ USB_DEVICE_AND_INTERFACE_INFO(MEDIATEK_VENDOR_ID, 0x00a2, 0xff, 0x00, 0x00) },


Hi,
this doesn't seem to be correct. Since this is a LTE CAT3 highspeed 
device and the modem manual mentions MS Win NDIS driver then one 
interface is likely to be a QMI interface which you must blacklist in 
the option driver.
Please provide a usb-devices or verbose lsusb output for the modem.

thanks
Lars