Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7587463rwn; Wed, 14 Sep 2022 00:46:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR5fcJrH3wSQZSiSnjUIITExUZFPx6ngQnIywk03ZzUZYuV55mQ48y/eo9mDQKObZb9L16w+ X-Received: by 2002:a17:907:a40e:b0:779:d3e1:3413 with SMTP id sg14-20020a170907a40e00b00779d3e13413mr16990334ejc.642.1663141563086; Wed, 14 Sep 2022 00:46:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663141563; cv=none; d=google.com; s=arc-20160816; b=kcB6hbSKUGllq4Y7mSNA2b2oJl6FJoT6Zf3iBmo9pAQTaQrLiENLxgWQw3cZp+YzM+ +EU8OPtiaFo+qLqj8JLt0gcwLe0roQ4Kq7Khz70HZUHXVSShogsQ/sbpB9jD1esAq4/1 Dpdbms1nMYqEq0QLN7coQP++iZTWSpTjza0sHBlz+HGZnZw53xT+8eTrYo59spewregG JPyFRaKTzOlG77dSR+Q/M0L4Va6fSt+346puJnOZLrXOCB9wX1KhjAUt3uSV5GP7uG7r qeBCZjD/kUauTIK47xCVPefhdrtpNtJBS1aLN3FouPpdiTc5833FhZQetG7EzLYOsTQI sZ+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AhzMBhpxQIZGzblSGXJmT/FAJ97HThQ7oI5AhNR6LBA=; b=nMhUOfd7aVvOQtmMEISfxQ5ADeVCTTdjQ6EXmRunmnugBU4ioFx58VpnFLn/DyuL6n mhDXm3QEgJQ+ArLbgLq8h3rKrB8N1wVlLkvHZnHHyTeiKLYvcSK2Xuah19jA5dlXew8E Ey1eNz2TzaTuF4dRB/1v+1cLHNbdnXfuMhcm6FtjvlI7K9Y6J5Ycfs8OwxUJeTLi2Nwh TZga20+FpOeH+3ngaJGfGqXdS2JZXnvv+hE+3ndPoESDKSajZUcLDe/hzOBaYvq5MfEA 0LKRF0SogIPEzhiEbRr9QSlpQrQrFdPpDFiBOag8feY5/CB6dpo8a62EIUoS1Smiv8tG C+iA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="vz/ydC4N"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1-20020a170906268100b00741a0c28f07si6966773ejc.943.2022.09.14.00.45.37; Wed, 14 Sep 2022 00:46:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="vz/ydC4N"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229607AbiINHfy (ORCPT + 99 others); Wed, 14 Sep 2022 03:35:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiINHfw (ORCPT ); Wed, 14 Sep 2022 03:35:52 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAFCF5A2E0 for ; Wed, 14 Sep 2022 00:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AhzMBhpxQIZGzblSGXJmT/FAJ97HThQ7oI5AhNR6LBA=; b=vz/ydC4NUg3N/inWnCZZctr8BL 32yXu7cj0sdBK0ASYgQBmfeVlIDmIY2a/snafAqAM/BegoJgmMuq+a5wZ+MxSUqowSPx3kAUm8X8X kTosJJ//e1HTAFzap9kGN6tgkPNkBbXaM+WtNrHBIMyPljRtrFUS/5io4SNzyAHuRDmu8vBUGEjzk Gdgd39DQXxJalyDDpJEWcr4NVrLrUI4sS6PVa+E2jnjgBtr2sf7Xp4NZ0a3Oc3JnEcazcce8605xm DsEqicg4aWMehheYgkkuU8Yxao4bWgK/KhZJgeDsVkJs9tCLexX9/J4K2ZPJoU/xSSzRZDnhU319z ivpKtKcA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYMvo-00HZr5-SM; Wed, 14 Sep 2022 07:35:36 +0000 Date: Wed, 14 Sep 2022 08:35:36 +0100 From: Matthew Wilcox To: "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Subject: Re: [PATCH 1/2] mm: fix logic error of page_expected_state Message-ID: References: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2022 at 11:37:00AM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > The page with special page type will be deemed as bad page wrongly since > type share the same address with mapcount. That's not wrongly. You didn't clear the bit. I told you you would need to do that in the first version of the patch you sent.