Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7597255rwn; Wed, 14 Sep 2022 01:00:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR7O0qhcQvbMP9eSTekyBlwWwTFvhvyvVSgp8zC0f7eOpWVU28QaD86HwxpVw4FfolGCIz7Q X-Received: by 2002:a17:906:ef8c:b0:77c:7b35:8b04 with SMTP id ze12-20020a170906ef8c00b0077c7b358b04mr10522305ejb.573.1663142427157; Wed, 14 Sep 2022 01:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663142427; cv=none; d=google.com; s=arc-20160816; b=LNJseiydXbIgU/WMP6YNNnJ26qSVHwMIfnupGRafv7Z+Z+7rlhhKXfIRJTYAtacUSm c89lJMgb8Lpc+VpIWAI151vvH6vUsddWjc4kZpKZZ5N7GkN1t8l0MN82P1CSeqjr5cti aGB4ATIbxp3PZdEOs/JESa9eAx7Fz7QUiRdCHMt5wyPVfUDTmCykqcGGksW44M0E9A9V n4TiGMaj6EiRaoqVALHtTegZm76e8SVrdRw/3VtdAVj/saTbK+N38gjpbyaMMPv9h27K Svv4mGv4bHOVAbR8TRx9SOsVmzXiER3B81ECNBa6aa3BZmulFOE7vpKsru8VMUkz2gaB zNCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xK6rQZk9RPmXG6rMhe5oBA83BpczBJE39eGNhUm9qAw=; b=zEKMwUZKPlPOnn3V2c3+rcJYBTTvLHZIxmBLv7MxrmKRXrX7k1V3O/1i/nc352cfKz W6wP6DTdH6BLqYLpr0HRbXToi78WGHHY41FFH7fTFl8d8OSCdoxCwXuRKDBdDTOIwQO2 qjX+I0QU1eg3n8h18KjjS+9XyzJkVAzXmQQJa0gg07HovEPPRDGyKeJ4/P8FtmUsXpLl TuZxCA5ptdvCSNKhxWyyhOTBet8I1CJp0E6ohpGdfWxcHmpSrCjhZOrMkHfPCSKgjvE8 O44PWgyCMtnmcBbTMUuBK/Gj82b4JIhjaNFVyY2mmviKSV6GNMVUuJXA1YIWwul6Ga+g 5seA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eyCp0nex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mf23-20020a170906cb9700b0077e94a4867csi4790997ejb.796.2022.09.14.01.00.01; Wed, 14 Sep 2022 01:00:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=eyCp0nex; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbiINHy6 (ORCPT + 99 others); Wed, 14 Sep 2022 03:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbiINHyf (ORCPT ); Wed, 14 Sep 2022 03:54:35 -0400 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E161A73324 for ; Wed, 14 Sep 2022 00:54:25 -0700 (PDT) Received: by mail-pg1-x532.google.com with SMTP id r23so5012877pgr.6 for ; Wed, 14 Sep 2022 00:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=xK6rQZk9RPmXG6rMhe5oBA83BpczBJE39eGNhUm9qAw=; b=eyCp0nexB3UmAfcdR3XWqu7f1E63DpnHWURGP0djm9lVIERmy+zhUEaipxpBzDxi5T TlXOUZuT5FOF3S56Wn8dfKGJzUmUng8wKJfah7s1EGe/CEBOy6T7QLD1unO+9zjL0YRk TdFN2pj6zNeONQPUR9rLI87Yyu4H2ms/528+iixQjZ4u8gTGDxMhsv2CRauCna7PdtoR OIrFI3TphvaRon5hch1jNEsGbzGjsI2Ax9Dhc/ST96qmjkxAIkiyTTkBTfI7vhWTM2Is GbNZcoDijA3FFkHZOaadeV8NplXr9BlV3WecY7FtKk0+NZiKC0ye0mffUyiCD0CL1x8S ZJDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=xK6rQZk9RPmXG6rMhe5oBA83BpczBJE39eGNhUm9qAw=; b=rR5xvx2jXa6O5OdOnenipOTnbzPA2+1JykaeSy8lGcys3t6a9Edgz0vCeQFlQHCVQ1 XFyGHeZIXnUNhMpH9OkjhVePYic6Awrz6QtM2Xm0LRCu7vqL2jvlN/m2enZhMzJGgUj4 sREGsMU2QJQOjPZgd/6wz+4fFZP+nC2MA1ferVDthe29cXBiVKRzhl4fCq/TIANjasAn g6U04RMXahV1BH0895w7toK/RZ2ytmGDaB90Dg6bUHUS72Pph0npDKk7RzP2w65A/OuU VU6FA82IRQpx5epw3GbcAHEvsR43BVng63lw5bgnQzOW0/5WzrdPn5WRCrV18FqTTruO iQtw== X-Gm-Message-State: ACgBeo1lH1qXuqueP5jKax7fhNlWfHQy1Sbi/Yh8XgkykGQ32G8dGhId vDgV+pjkvkHi3KxugMpsbpKg X-Received: by 2002:a05:6a00:e1b:b0:537:7c74:c405 with SMTP id bq27-20020a056a000e1b00b005377c74c405mr36025101pfb.43.1663142064806; Wed, 14 Sep 2022 00:54:24 -0700 (PDT) Received: from localhost.localdomain ([117.202.184.122]) by smtp.gmail.com with ESMTPSA id p8-20020a1709027ec800b00174ea015ee2sm10119054plb.38.2022.09.14.00.54.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 00:54:24 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, robh@kernel.org, andersson@kernel.org Cc: kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org, Manivannan Sadhasivam Subject: [PATCH v4 04/12] PCI: qcom-ep: Disable IRQs during driver remove Date: Wed, 14 Sep 2022 13:23:42 +0530 Message-Id: <20220914075350.7992-5-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220914075350.7992-1-manivannan.sadhasivam@linaro.org> References: <20220914075350.7992-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Disable the Global and PERST IRQs during driver remove to avoid getting spurious IRQs after resource deallocation. Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pcie-qcom-ep.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom-ep.c b/drivers/pci/controller/dwc/pcie-qcom-ep.c index 1e09eca5b3b2..72eb6cacdb3a 100644 --- a/drivers/pci/controller/dwc/pcie-qcom-ep.c +++ b/drivers/pci/controller/dwc/pcie-qcom-ep.c @@ -585,11 +585,11 @@ static int qcom_pcie_ep_enable_irq_resources(struct platform_device *pdev, { int irq, ret; - irq = platform_get_irq_byname(pdev, "global"); - if (irq < 0) - return irq; + pcie_ep->global_irq = platform_get_irq_byname(pdev, "global"); + if (pcie_ep->global_irq < 0) + return pcie_ep->global_irq; - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, + ret = devm_request_threaded_irq(&pdev->dev, pcie_ep->global_irq, NULL, qcom_pcie_ep_global_irq_thread, IRQF_ONESHOT, "global_irq", pcie_ep); @@ -698,6 +698,9 @@ static int qcom_pcie_ep_remove(struct platform_device *pdev) { struct qcom_pcie_ep *pcie_ep = platform_get_drvdata(pdev); + disable_irq(pcie_ep->global_irq); + disable_irq(pcie_ep->perst_irq); + if (pcie_ep->link_status == QCOM_PCIE_EP_LINK_DISABLED) return 0; -- 2.25.1