Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b13fa907-6893-c4e2-4da5-204e15271a11@linux.intel.com>
Date:   Wed, 14 Sep 2022 09:51:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH linux-next] soundwire: intel: Remove unused parameter ret
Content-Language: en-US
To:     cgel.zte@gmail.com, vkoul@kernel.org,
        yung-chuan.liao@linux.intel.com
Cc:     sanyog.r.kale@intel.com, Zeal Robot <zealci@zte.com.cn>,
        Jinpeng Cui <cui.jinpeng2@zte.com.cn>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20220914015256.22378-1-cui.jinpeng2@zte.com.cn>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20220914015256.22378-1-cui.jinpeng2@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 9/14/22 03:52, cgel.zte@gmail.com wrote:
> From: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> 
> The parameter ret = 0 has not been used.
> Return 0 directly instead of returning ret.

That code will be modified by a cleanup series that is going to land
upstream shortly, see https://github.com/thesofproject/linux/pull/3835

It's not an incorrect change but it will introduce unnecessary churn IMHO.

> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Jinpeng Cui <cui.jinpeng2@zte.com.cn>
> ---
>  drivers/soundwire/intel.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c
> index b006ae6efcb0..26fdf3577454 100644
> --- a/drivers/soundwire/intel.c
> +++ b/drivers/soundwire/intel.c
> @@ -395,7 +395,6 @@ static int intel_shim_init(struct sdw_intel *sdw, bool clock_stop)
>  {
>  	void __iomem *shim = sdw->link_res->shim;
>  	unsigned int link_id = sdw->instance;
> -	int ret = 0;
>  	u16 ioctl = 0, act = 0;
>  
>  	mutex_lock(sdw->link_res->shim_lock);
> @@ -427,7 +426,7 @@ static int intel_shim_init(struct sdw_intel *sdw, bool clock_stop)
>  
>  	mutex_unlock(sdw->link_res->shim_lock);
>  
> -	return ret;
> +	return 0;
>  }
>  
>  static void intel_shim_wake(struct sdw_intel *sdw, bool wake_enable)