Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7628476rwn; Wed, 14 Sep 2022 01:38:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR4XwKx+YgavDQSop9Pp9xbeFD7lA0e2/uPsFJdt98gaiW2nd2wN+pnrRXmBcmeJnumP0ZPU X-Received: by 2002:a05:6a00:124f:b0:542:6c43:5be8 with SMTP id u15-20020a056a00124f00b005426c435be8mr17266088pfi.5.1663144730388; Wed, 14 Sep 2022 01:38:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663144730; cv=none; d=google.com; s=arc-20160816; b=onFuXpMnatgVj1k5i0JTBdjqHiaD38IFekLSAX8WlhOMDQLaZk4MgvvwTp2/IOEoyv WgLtfMXbA9vEg1E8BVLMsPaN1ChuKxvJYK/hpPKpOzpvQfZPgvXdBYGGwbE00Mb6HzqQ e/9RAVTGX9y6LPfIY2ZdqXYxz5aVetlW1siiRcCodDeXnFPqWF3jlrQN3HMeMZXhAjSL XIR8mx3zsy96j01niyn9P9c33WHmWJhAZGnoBOUT0v3yWsf0YKGBeVIegYOi5EVUHkP1 R514MtpU9ZwrHO1kvGwwjZZsTxfeL3Aod5UUhv+AZhbIQz0weaoLmutBUQN3SfIR5nvZ preg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gdXKGj9UVTzuUiW5uUdlSuJRenGy+NzCqxW+E3MayDc=; b=gpKa0XmHXmaplX64wWrQXFlOCn14/DDibsM/ZBeYnAGgT7nPFFUCk4rXL/nHbX2U+m OEwh6jI5kX0ZeyhYn5D6G3h8j4WLuVgjOb8ijyK7mmyO6HrzPvoVEx1qn6C5TLCY2Buk YQefJ1yODta3XvpT0AUZMlycjz9MS+4h0ZEkMsPHsgEGvFDybiamnhqQsVhwoOmOcPpb 6KHyHybQW7l9Ydnp3tv5J7UDkATSZSHP6iJM8FIlha6B+Q760HzTu4vPSUJr0xuZq7zM tXLRCATZX/YAQVQmmmwwcHnutKlONdUOx5rMkjAnr0qIsArPkXO8igNZQ5vi7bW7LAry Uozg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pu0zULfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g10-20020a056a001a0a00b0053fafd6a529si13763684pfv.24.2022.09.14.01.38.38; Wed, 14 Sep 2022 01:38:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=pu0zULfY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230258AbiINHvt (ORCPT + 99 others); Wed, 14 Sep 2022 03:51:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbiINHve (ORCPT ); Wed, 14 Sep 2022 03:51:34 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6FCB72EFE; Wed, 14 Sep 2022 00:51:23 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id q11so7208633qkc.12; Wed, 14 Sep 2022 00:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=gdXKGj9UVTzuUiW5uUdlSuJRenGy+NzCqxW+E3MayDc=; b=pu0zULfYPDmGATtFEVxA/ovR08fqreDUy27T8WPwd3RWNm5Nvd0zYYp8RtxLZOiOiO wzwmun1tLkSi/P7mhYpA2TgLywo2P3Lqe4CgDdldLGN0FcO0QBWnNR3Of80mGvPW8eKQ ERAstnZLUDgWQJ6UNpLIj5LdG0JQcerfPDHQArA29lYjNPhzVS9qat/piy7wmoU5ZW+v /96rNozxDF9g+qUCO5WvW409EMw8/FI0/hfz+fSjp35h2meYw2V1Vm60rs+ly+pFgRMG F6J50Pb4PrR5NF23IvZSjHxqiYBO3mw+nopEiUYDHXCkO7w/ButX0axtZwfM39GvyT/q y7kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=gdXKGj9UVTzuUiW5uUdlSuJRenGy+NzCqxW+E3MayDc=; b=YcxL/WaWlTjYLEwHcfSRehEgo4qeHDCbzJIfG4/7+Yr/lMvkvykB0pXTaanlU3edC6 +jer9JkuyaczJ5zozKGQm5W/LqWjosCHpWG/mipqFLX5AD5zOXVOtwpPHBPUHQrzG+0x RA9+qr+F6L+vwN7WwuivNj5PimYt8JR/SX1Vu2XFXzGWEsDEnT2nW9usccCMoI1cPCxD 7QHWbxhAs0TAYpjKzX6w9bidxCj7MKPl5LGCt9e/PfFbFOMUkhneHO2D6q4d7PWHHNm/ gHnzGaeZd6nVKRFshe/gTIuc6s/ftEAe6ggeSqr5G/DCzoiP2IjRUaVU93vXlX6A1gF4 ZfHg== X-Gm-Message-State: ACgBeo2c8WpJemL0XgOjSyoVh5VSHrU77rubKZbsrk+dsdDuss8IwZFq uO8igJwccSkd0OaLR316VWQl5ziemQ== X-Received: by 2002:a37:4349:0:b0:6ce:4c0a:3abc with SMTP id q70-20020a374349000000b006ce4c0a3abcmr8408010qka.706.1663141882298; Wed, 14 Sep 2022 00:51:22 -0700 (PDT) Received: from bytedance (ec2-52-52-7-82.us-west-1.compute.amazonaws.com. [52.52.7.82]) by smtp.gmail.com with ESMTPSA id i10-20020a05620a404a00b006b98315c6fbsm1455786qko.1.2022.09.14.00.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Sep 2022 00:51:21 -0700 (PDT) Date: Wed, 14 Sep 2022 00:51:18 -0700 From: Peilin Ye To: Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni Cc: Peilin Ye , Cong Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2] net: Use WARN_ON_ONCE() in {tcp,udp}_read_skb() Message-ID: <20220914075118.GA17613@bytedance> References: <20220908231523.8977-1-yepeilin.cs@gmail.com> <20220913184016.16095-1-yepeilin.cs@gmail.com> <20220913193050.GA16391@bytedance> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220913193050.GA16391@bytedance> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 12:30:50PM -0700, Peilin Ye wrote: > On Tue, Sep 13, 2022 at 11:40:16AM -0700, Peilin Ye wrote: > > Suggested-by: Jakub Sitnicki > > Signed-off-by: Peilin Ye > > Sorry, I forgot to add Fixes: tag. > > Those WARN_ON() come from different commits. I will split this into two > in v3 to make it easier. Cong suggested not sending v3 since this is not fixing a bug, and thus no need to add Fixes: tags.