Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp7679341rwn; Wed, 14 Sep 2022 02:45:03 -0700 (PDT) X-Google-Smtp-Source: AA6agR6KHVu+bsPa2ZgZ6kNYdtbiJODDux1eB70zvIYmf6fORj9/Ryv4x6UT8jE6sC0wlary6dNL X-Received: by 2002:aa7:88c7:0:b0:542:3229:8d0f with SMTP id k7-20020aa788c7000000b0054232298d0fmr18106271pff.74.1663148703440; Wed, 14 Sep 2022 02:45:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663148703; cv=none; d=google.com; s=arc-20160816; b=UHto7dz6oMRkpNr4pSYqdTtM2JZpuOJQddMWpYcJNf0SEVNjzNKIZYWVATGPl8A8Sw UyKCHiXszXKcugMzRS2AnjTUkLTVMCzv/tuz/8EaGvQGXmkrKfqUvssu1Z9HnhP72WKf pPHFCMMXMigfabb54AjtCsAr09SCqlJ1pdO1eIFJLDr9RvEHehYDXmyjqZ8emGA6WESr xF+8Er+cFL+ulAZGE9/H/AemvE+mxYam12tG3hENT9MmGMDmOd3chPgVRYXzf0HV7akB FhXZlRHDPR/YgZQyKzNA5AXeiDwvpubweEOHehWPxPtsHWpLCFOZ+D8oboTm2mABe+S7 wjcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=hHiFxLoQl7nFkGX8kgtVUXbRSPMp0KpED73uMSjHu+w=; b=TsElSvefIESPODgPjZJYoFCsMPN12dYT+N3DPdVEoDBHOjWV2RVKhYcRgzhtf4jyf6 Xzlba8m3kUXcpBEKSa1V3tF7gXiKdW56Vhh0Hjp2N057bdL4+R6fbN5iqdw4Vc28xIX3 c+xnq/StcIl8fvA6N/4+WhIlZVtw7t7Ba7vhVhN0Ea2REFd74hB9zURTHIqVOF8ki+CD 2INe3T0p9VWlaH8nOPTYt+VJ4UueLXrnubEMX33m0wwBlehKNTFfr5QZ9MTU6XXSLO/b fZocIqb8onILWhn28lJzQg7V9gkV+k3gsN1SQvB/4egPfdjCHwln1DHVacEnxVASwBEJ DAnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=VoSrXwXu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id on11-20020a17090b1d0b00b001fddf1a3380si13557612pjb.109.2022.09.14.02.44.51; Wed, 14 Sep 2022 02:45:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=VoSrXwXu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231502AbiINJif (ORCPT + 99 others); Wed, 14 Sep 2022 05:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbiINJiQ (ORCPT ); Wed, 14 Sep 2022 05:38:16 -0400 Received: from out0.migadu.com (out0.migadu.com [94.23.1.103]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A84BFB1ED for ; Wed, 14 Sep 2022 02:37:13 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1663148231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hHiFxLoQl7nFkGX8kgtVUXbRSPMp0KpED73uMSjHu+w=; b=VoSrXwXuRHkuMJqgFeh5tLtjh1NB+Ha72/uvICQk9QNQ0pkQ03EOA93YfkOxxjmDqWxgrR 8MYTYS34zwlstEhfu5gl+oJ43Iu4OeA6gADuRa1He9hy+nycYoP5A6zpOG5V9cmFBsW2yk h4tFSd/Q9+2rr/XMyyF4obkf2M4yTOk= From: Yajun Deng To: sj@kernel.org, akpm@linux-foundation.org Cc: sieberf@amazon.com, shakeelb@google.com, foersleo@amazon.de, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH] mm/damon: fix missing damon_del_region() Date: Wed, 14 Sep 2022 17:36:36 +0800 Message-Id: <20220914093636.1184590-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It should be called damon_del_region() before free each region, so use damon_destroy_region() instead of damon_free_region(). Fixes: f23b8eee1871 (mm/damon/core: implement region-based sampling) Signed-off-by: Yajun Deng --- mm/damon/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 0b1eb945c68a..e62e7ebf4b12 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -361,7 +361,7 @@ void damon_free_target(struct damon_target *t) struct damon_region *r, *next; damon_for_each_region_safe(r, next, t) - damon_free_region(r); + damon_destroy_region(r, t); kfree(t); } -- 2.25.1