Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Sep 2022 11:47:42 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     John Garry <john.garry@huawei.com>, joro@8bytes.org,
        will@kernel.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/iova: Fix module config properly
Message-ID: <YyGjPoM6ooNeJKhT@orome>
References: <548c2f683ca379aface59639a8f0cccc3a1ac050.1663069227.git.robin.murphy@arm.com>
 <4740744e-2e12-520d-8598-188b8d2ebd6b@huawei.com>
 <38988c89-ec61-faa1-6b15-2fd3aa51eede@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="wxiM4cf+GB3fdexT"
Content-Disposition: inline
In-Reply-To: <38988c89-ec61-faa1-6b15-2fd3aa51eede@arm.com>
User-Agent: Mutt/2.2.7 (2022-08-07)
Precedence: bulk


--wxiM4cf+GB3fdexT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Sep 13, 2022 at 03:15:18PM +0100, Robin Murphy wrote:
> On 2022-09-13 14:01, John Garry wrote:
> > On 13/09/2022 12:47, Robin Murphy wrote:
> > > IOMMU_IOVA is intended to be an optional library for users to select =
as
> > > and when they desire. Since it can be a module now, this means that
> > > built-in code which has chosen not to select it should not fail to li=
nk
> > > if it happens to have selected as a module by someone else. Replace
> > > IS_ENABLED() with IS_REACHABLE() to do the right thing.
> >=20
> > Hi Robin,
> >=20
> > Recently you mentioned "I wonder if we couldn't replace the IS_ENABLED()
> > with IS_REACHABLE() and restore some of the previously-conditional
> > selects", and pointed me to 84db889e6d82 as an example of when a
> > conditional select was made unconditional.
> >=20
> > So will you also restore some previously-conditional selects next?
>=20
> I figured I'd leave that up to Thierry (and/or anyone else with a vested
> interest), but having mulled it over since that previous thread, there's
> really no excuse for the API itself not to do the right thing either way,=
 so
> I felt compelled to write up this much.

On Tegra specifically, as the commit message says, we don't really care
about the conditional selection because practically we always want IOMMU
support enabled. So instead of adding back the conditional select it
would make more sense to select IOMMU_API instead and then get rid of
the handful of #ifdef blocks we have for that.

On a side note: I'm looking at a subtle regression right now where some
corner case no longer works and that's primarily due to the fact that we
can have four different scenarios: non-IOMMU, IOMMU, DMA/IOMMU and IOMMU
but devices with no iommus property in their DT nodes. This has all
become very unwieldy and becomes increasingly difficult to test. So
anything that we can do to keep down the number of permutations is
welcome.

While that's not directly related to this issue, the lesson learned is
that, at least on the Tegra side, we have in the past made things
unnecessarily difficult for ourselves based on the misguided assumption
that maximum configurability is key.

Thierry

--wxiM4cf+GB3fdexT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmMhozsACgkQ3SOs138+
s6FWXw/+PHWdbXa32ZnwndVQaRUolrlckoZxu6Zna5i4/G4JMrLTHtebY+3qNguZ
kuDNz42qizMH/XB138WCGZ6715CVOExNaW6Rqugu3gemSe6k7/aRZPcZ7Hw6Fn83
HDXiY09X4notns4v5nO6bnFIv+Bb5ZIS42yngcvi8yrdhm/wmzr0GxPBH7GY5cSG
gU1JcwyxzFDKsyWely/U2G6+11yzuuxuS3vraGpEL+fZEd3XlCts08kyL0bdrPbo
kSXmE88eMmq1yS6bTiro13gjbO8ar4NBiNnoaYMNJEGjA9cLXxZvETUH1Ka9nyHC
bTj1BeuG5JM5Rdky+uMHGgYRmA+kXp2cI1admgoo5sX4k42xD31WAHDYTCNba0TN
GIJF6mbfWj4Kq7F6RuCA+QQzT+W+Gw0V13xprLHFZHtUGnlcV6GtpXeeTpEpjQs7
6HFRSGri/H7YZiFILLnU0O30nSqSrzLn7NgdiGfGGUsKJM8tyGeBro/cYlbprMMA
NTFL6j/tHO6A/mAdVLxcPMAKheXrP+jDKdVptrEzwxRQ9UM7NtMrXfv+bHRhGUZA
oLE8iS99gktA1TaOhODkOmyqInt6+HvZe2C92YTGt+psQNsX58sUolPOI9GCTDCD
0h5T+ykW9TG7U+ZcVlApvAS0wE7U1zXdfDzTRzjJcCzrXPEGQjQ=
=OYgt
-----END PGP SIGNATURE-----

--wxiM4cf+GB3fdexT--